* [PATCH v2] cgroup: avoid cgroup root name longer than max
@ 2017-12-08 10:04 ` Ma Shimiao
0 siblings, 0 replies; 2+ messages in thread
From: Ma Shimiao @ 2017-12-08 10:04 UTC (permalink / raw)
To: tj, lizefan; +Cc: cgroups, linux-kernel, Ma Shimiao
v1->v2:
- only copy maxlength-1 to name, otherwise have problem to print it
cgroup root name has max length limit, we should avoid copying
longer name than that to the name.
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 0b1ffe147f24..f5b0478c89b7 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -1866,7 +1866,7 @@ void init_cgroup_root(struct cgroup_root *root, struct cgroup_sb_opts *opts)
if (opts->release_agent)
strcpy(root->release_agent_path, opts->release_agent);
if (opts->name)
- strcpy(root->name, opts->name);
+ strncpy(root->name, opts->name, MAX_CGROUP_ROOT_NAMELEN - 1);
if (opts->cpuset_clone_children)
set_bit(CGRP_CPUSET_CLONE_CHILDREN, &root->cgrp.flags);
}
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] cgroup: avoid cgroup root name longer than max
@ 2017-12-08 10:04 ` Ma Shimiao
0 siblings, 0 replies; 2+ messages in thread
From: Ma Shimiao @ 2017-12-08 10:04 UTC (permalink / raw)
To: tj, lizefan; +Cc: cgroups, linux-kernel, Ma Shimiao
v1->v2:
- only copy maxlength-1 to name, otherwise have problem to print it
cgroup root name has max length limit, we should avoid copying
longer name than that to the name.
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 0b1ffe147f24..f5b0478c89b7 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -1866,7 +1866,7 @@ void init_cgroup_root(struct cgroup_root *root, struct cgroup_sb_opts *opts)
if (opts->release_agent)
strcpy(root->release_agent_path, opts->release_agent);
if (opts->name)
- strcpy(root->name, opts->name);
+ strncpy(root->name, opts->name, MAX_CGROUP_ROOT_NAMELEN - 1);
if (opts->cpuset_clone_children)
set_bit(CGRP_CPUSET_CLONE_CHILDREN, &root->cgrp.flags);
}
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-08 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08 10:04 [PATCH v2] cgroup: avoid cgroup root name longer than max Ma Shimiao
2017-12-08 10:04 ` Ma Shimiao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.