All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Mylène Josserand" <mylene.josserand@free-electrons.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
	wens@csie.org, dmitry.torokhov@gmail.com,
	linux-input@vger.kernel.org, simon.budig@kernelconcepts.de,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	thomas.petazzoni@free-electrons.com
Subject: Re: [PATCH 5/5] arm: dts: sun8i: a83t: a711: Add touchscreen node
Date: Mon, 11 Dec 2017 08:16:35 +0100	[thread overview]
Message-ID: <20171211071635.4ntdksmjino4uh2i@flea.lan> (raw)
In-Reply-To: <20171208215419.30396-6-mylene.josserand@free-electrons.com>

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hi,

On Fri, Dec 08, 2017 at 10:54:19PM +0100, Mylène Josserand wrote:
> Tha A711 tablet has a FocalTech EDT-FT5x06 Polytouch touchscreen.
> It is connected via I2C0 so add his node in i2c0's node.
> 
> The reset line is PD5, the interrupt line is PL7 and the power
> supply is the ldo_io0 regulator.
> 
> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index 84cca1a48cea..738359917a34 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -110,6 +110,17 @@
>  	pinctrl-0 = <&i2c0_pins>;
>  	clock-frequency = <400000>;
>  	status = "okay";
> +
> +	polytouch: edt-ft5x06@38 {

You're not using that label anywhere, so you can drop it, and the node
name must be the class of the device.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Mylène Josserand"
	<mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	simon.budig-t93Ne7XHvje5bSeCtf/tX7NAH6kLmebB@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org
Subject: Re: [PATCH 5/5] arm: dts: sun8i: a83t: a711: Add touchscreen node
Date: Mon, 11 Dec 2017 08:16:35 +0100	[thread overview]
Message-ID: <20171211071635.4ntdksmjino4uh2i@flea.lan> (raw)
In-Reply-To: <20171208215419.30396-6-mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Hi,

On Fri, Dec 08, 2017 at 10:54:19PM +0100, Mylène Josserand wrote:
> Tha A711 tablet has a FocalTech EDT-FT5x06 Polytouch touchscreen.
> It is connected via I2C0 so add his node in i2c0's node.
> 
> The reset line is PD5, the interrupt line is PL7 and the power
> supply is the ldo_io0 regulator.
> 
> Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index 84cca1a48cea..738359917a34 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -110,6 +110,17 @@
>  	pinctrl-0 = <&i2c0_pins>;
>  	clock-frequency = <400000>;
>  	status = "okay";
> +
> +	polytouch: edt-ft5x06@38 {

You're not using that label anywhere, so you can drop it, and the node
name must be the class of the device.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] arm: dts: sun8i: a83t: a711: Add touchscreen node
Date: Mon, 11 Dec 2017 08:16:35 +0100	[thread overview]
Message-ID: <20171211071635.4ntdksmjino4uh2i@flea.lan> (raw)
In-Reply-To: <20171208215419.30396-6-mylene.josserand@free-electrons.com>

Hi,

On Fri, Dec 08, 2017 at 10:54:19PM +0100, Myl?ne Josserand wrote:
> Tha A711 tablet has a FocalTech EDT-FT5x06 Polytouch touchscreen.
> It is connected via I2C0 so add his node in i2c0's node.
> 
> The reset line is PD5, the interrupt line is PL7 and the power
> supply is the ldo_io0 regulator.
> 
> Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index 84cca1a48cea..738359917a34 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -110,6 +110,17 @@
>  	pinctrl-0 = <&i2c0_pins>;
>  	clock-frequency = <400000>;
>  	status = "okay";
> +
> +	polytouch: edt-ft5x06 at 38 {

You're not using that label anywhere, so you can drop it, and the node
name must be the class of the device.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171211/fc3bc50e/attachment-0001.sig>

  reply	other threads:[~2017-12-11  7:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 21:54 [PATCH 0/5] sun8i-a83t: Add touchscreen support on TBS A711 Mylène Josserand
2017-12-08 21:54 ` Mylène Josserand
2017-12-08 21:54 ` Mylène Josserand
2017-12-08 21:54 ` [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node Mylène Josserand
2017-12-08 21:54   ` Mylène Josserand
2017-12-11  7:15   ` Maxime Ripard
2017-12-11  7:15     ` Maxime Ripard
2017-12-11  7:15     ` Maxime Ripard
2017-12-11  8:31     ` Chen-Yu Tsai
2017-12-11  8:31       ` Chen-Yu Tsai
2017-12-11  8:31       ` Chen-Yu Tsai
2017-12-08 21:54 ` [PATCH 2/5] arm: dts: sun8i: a83t: Add I2C0 pins group Mylène Josserand
2017-12-08 21:54   ` Mylène Josserand
2017-12-08 21:54 ` [PATCH 3/5] arm: dts: sun8i: a83t: a711: Enable I2C0 Mylène Josserand
2017-12-08 21:54   ` Mylène Josserand
2017-12-08 21:54   ` Mylène Josserand
2017-12-11  7:18   ` Maxime Ripard
2017-12-11  7:18     ` Maxime Ripard
2017-12-08 21:54 ` [PATCH 4/5] Input: edt-ft5x06 - Add support for regulator Mylène Josserand
2017-12-08 21:54   ` Mylène Josserand
2017-12-09  1:16   ` Dmitry Torokhov
2017-12-09  1:16     ` Dmitry Torokhov
2017-12-09  1:16     ` Dmitry Torokhov
2017-12-09  1:24     ` Dmitry Torokhov
2017-12-09  1:24       ` Dmitry Torokhov
2017-12-08 21:54 ` [PATCH 5/5] arm: dts: sun8i: a83t: a711: Add touchscreen node Mylène Josserand
2017-12-08 21:54   ` Mylène Josserand
2017-12-11  7:16   ` Maxime Ripard [this message]
2017-12-11  7:16     ` Maxime Ripard
2017-12-11  7:16     ` Maxime Ripard
2017-12-08 22:01 ` [PATCH 0/5] sun8i-a83t: Add touchscreen support on TBS A711 Mylene JOSSERAND
2017-12-08 22:01   ` Mylene JOSSERAND
2017-12-08 22:01   ` Mylene JOSSERAND

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211071635.4ntdksmjino4uh2i@flea.lan \
    --to=maxime.ripard@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mylene.josserand@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=simon.budig@kernelconcepts.de \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.