* [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U
@ 2017-12-11 9:33 Fam Zheng
2017-12-11 9:50 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2017-12-11 9:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, kchamart, Kevin Wolf, Max Reitz, stefanha, eblake
Signed-off-by: Fam Zheng <famz@redhat.com>
---
v3: Document that the option is not allowed for read-write. [Stefan]
v2: - "code{qemu-img}". [Kashyap, Eric]
- "etc.." -> "etc.".
---
qemu-img.texi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index fdcf120f36..d85ace73f0 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
the @var{-n} parameter to skip image creation. This restriction may be relaxed
in a future release.
+@item --force-share (-U)
+
+If specified, @code{qemu-img} will open the image with shared permissions,
+which makes it less likely to conflict with a running guest's permissions due
+to image locking. For example, this can be used to get the image information
+(with 'info' subcommand) when the image is used by a running guest. Note that
+this could produce inconsistent result because of concurrent metadata changes,
+etc. This option is only allowed when opening image in read-only mode.
+
@item fmt
is the disk image format. It is guessed automatically in most cases. See below
for a description of the supported disk formats.
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U
2017-12-11 9:33 [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U Fam Zheng
@ 2017-12-11 9:50 ` Kevin Wolf
2017-12-11 11:44 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2017-12-11 9:50 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, qemu-block, kchamart, Max Reitz, stefanha, eblake
Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
>
> v3: Document that the option is not allowed for read-write. [Stefan]
>
> v2: - "code{qemu-img}". [Kashyap, Eric]
> - "etc.." -> "etc.".
> ---
> qemu-img.texi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index fdcf120f36..d85ace73f0 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
> the @var{-n} parameter to skip image creation. This restriction may be relaxed
> in a future release.
>
> +@item --force-share (-U)
> +
> +If specified, @code{qemu-img} will open the image with shared permissions,
> +which makes it less likely to conflict with a running guest's permissions due
> +to image locking. For example, this can be used to get the image information
> +(with 'info' subcommand) when the image is used by a running guest. Note that
> +this could produce inconsistent result because of concurrent metadata changes,
> +etc. This option is only allowed when opening image in read-only mode.
I think "an image", "the image" or "images" could all work in this
context, but just "image" without an article doesn't.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U
2017-12-11 9:50 ` Kevin Wolf
@ 2017-12-11 11:44 ` Fam Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-12-11 11:44 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-block, kchamart, qemu-devel, Max Reitz, stefanha
On Mon, 12/11 10:50, Kevin Wolf wrote:
> Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> >
> > ---
> >
> > v3: Document that the option is not allowed for read-write. [Stefan]
> >
> > v2: - "code{qemu-img}". [Kashyap, Eric]
> > - "etc.." -> "etc.".
> > ---
> > qemu-img.texi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/qemu-img.texi b/qemu-img.texi
> > index fdcf120f36..d85ace73f0 100644
> > --- a/qemu-img.texi
> > +++ b/qemu-img.texi
> > @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
> > the @var{-n} parameter to skip image creation. This restriction may be relaxed
> > in a future release.
> >
> > +@item --force-share (-U)
> > +
> > +If specified, @code{qemu-img} will open the image with shared permissions,
> > +which makes it less likely to conflict with a running guest's permissions due
> > +to image locking. For example, this can be used to get the image information
> > +(with 'info' subcommand) when the image is used by a running guest. Note that
> > +this could produce inconsistent result because of concurrent metadata changes,
> > +etc. This option is only allowed when opening image in read-only mode.
>
> I think "an image", "the image" or "images" could all work in this
> context, but just "image" without an article doesn't.
"Images" would be my intent if I proofread it, but you're right, all sound okay
to me. Thanks.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-11 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-11 9:33 [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U Fam Zheng
2017-12-11 9:50 ` Kevin Wolf
2017-12-11 11:44 ` Fam Zheng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.