[PATCH]media: dvb-frontends: Add delay to Si2168 restart

[PATCH]media: dvb-frontends: Add delay to Si2168 restart

[Ron Economos]

On faster CPUs a delay is required after the POWER_UP/RESUME command and 
the DD_RESTART command. Without the delay, the DD_RESTART command often 
returns -EREMOTEIO and the Si2168 does not restart.

diff --git a/drivers/media/dvb-frontends/si2168.c 
b/drivers/media/dvb-frontends/si2168.c
index 172fc36..f2a3c8f 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -15,6 +15,7 @@
   */

  #include "si2168_priv.h"
+#include <linux/delay.h>

  static const struct dvb_frontend_ops si2168_ops;

@@ -435,6 +436,7 @@ static int si2168_init(struct dvb_frontend *fe)
                 if (ret)
                         goto err;

+               udelay(100);
                 memcpy(cmd.args, "\x85", 1);
                 cmd.wlen = 1;
                 cmd.rlen = 1;

Re: [PATCH]media: dvb-frontends: Add delay to Si2168 restart

[Mauro Carvalho Chehab]

Em Tue, 10 Oct 2017 18:13:30 -0700
Ron Economos <w6rz@comcast.net> escreveu:

> On faster CPUs a delay is required after the POWER_UP/RESUME command and 
> the DD_RESTART command. Without the delay, the DD_RESTART command often 
> returns -EREMOTEIO and the Si2168 does not restart.

You forgot to add your signed-off-by after the patch description.

That's required for all patches that will be applied. See:
	https://linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work
	

> 
> diff --git a/drivers/media/dvb-frontends/si2168.c 
> b/drivers/media/dvb-frontends/si2168.c
> index 172fc36..f2a3c8f 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -15,6 +15,7 @@
>    */
> 
>   #include "si2168_priv.h"
> +#include <linux/delay.h>
> 
>   static const struct dvb_frontend_ops si2168_ops;
> 
> @@ -435,6 +436,7 @@ static int si2168_init(struct dvb_frontend *fe)
>                  if (ret)
>                          goto err;
> 
> +               udelay(100);

Your emailer is mangling your patches, replacing tabs by spaces and
breaking long lines. Please either use git send-email or use some
other email software, like claws-mail, pine or exim.

>                  memcpy(cmd.args, "\x85", 1);
>                  cmd.wlen = 1;
>                  cmd.rlen = 1;
> 



Thanks,
Mauro

[PATCH RESEND] media: dvb-frontends: Add delay to Si2168 restart.

[Ron Economos]

On faster CPUs a delay is required after the resume command and the restart command. Without the delay, the restart command often returns -EREMOTEIO and the Si2168 does not restart.

Note that this patch fixes the same issue as https://patchwork.linuxtv.org/patch/44304/, but I believe my udelay() fix addresses the actual problem.

Signed-off-by: Ron Economos <w6rz@comcast.net>

---
 drivers/media/dvb-frontends/si2168.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 41d9c51..539399d 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -14,6 +14,8 @@
  *    GNU General Public License for more details.
  */
 
+#include <linux/delay.h>
+
 #include "si2168_priv.h"
 
 static const struct dvb_frontend_ops si2168_ops;
@@ -435,6 +437,7 @@ static int si2168_init(struct dvb_frontend *fe)
 		if (ret)
 			goto err;
 
+		udelay(100);
 		memcpy(cmd.args, "\x85", 1);
 		cmd.wlen = 1;
 		cmd.rlen = 1;
-- 
2.7.4