From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: nuc900: Fix platform_get_irq() error checking some more
Date: Mon, 11 Dec 2017 16:41:34 +0000 [thread overview]
Message-ID: <20171211164134.GE32306@piout.net> (raw)
In-Reply-To: <20171211120129.ssrw65eghtdpmjej@mwanda>
On 11/12/2017 at 15:01:29 +0300, Dan Carpenter wrote:
> On Mon, Dec 11, 2017 at 12:49:50PM +0100, Alexandre Belloni wrote:
> > Maybe the good thing to do is to actaully leave the nuc900 code alone
> > instead of trying to change something that never failed and that doesn't
> > seem to interest anyone anymore (else the platform would have been
> > converted to DT).
> >
>
> I don't know. The bug is less than a month old and this discussion has
> been useful for me as I review any platform_get_irq() changes sent to
> staging.
>
What I meant is that the original code before this "fix" was more that 7
years old and nobody ever had any issues. And that's because getting
that IRQ on that platform will simply never fail.
Also, I really doubt anybody is going to copy paste from the nuc900-ac97
driver so I'm really wondering whether it is worth fixing this non-issue.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: nuc900: Fix platform_get_irq() error checking some more
Date: Mon, 11 Dec 2017 17:41:34 +0100 [thread overview]
Message-ID: <20171211164134.GE32306@piout.net> (raw)
In-Reply-To: <20171211120129.ssrw65eghtdpmjej@mwanda>
On 11/12/2017 at 15:01:29 +0300, Dan Carpenter wrote:
> On Mon, Dec 11, 2017 at 12:49:50PM +0100, Alexandre Belloni wrote:
> > Maybe the good thing to do is to actaully leave the nuc900 code alone
> > instead of trying to change something that never failed and that doesn't
> > seem to interest anyone anymore (else the platform would have been
> > converted to DT).
> >
>
> I don't know. The bug is less than a month old and this discussion has
> been useful for me as I review any platform_get_irq() changes sent to
> staging.
>
What I meant is that the original code before this "fix" was more that 7
years old and nobody ever had any issues. And that's because getting
that IRQ on that platform will simply never fail.
Also, I really doubt anybody is going to copy paste from the nuc900-ac97
driver so I'm really wondering whether it is worth fixing this non-issue.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-11 16:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 11:52 [PATCH 1/2] ASoC: nuc900: Fix platform_get_irq() error checking some more Dan Carpenter
2017-12-09 11:52 ` Dan Carpenter
2017-12-09 11:52 ` [PATCH 2/2 resend] ASoC: nuc900: Fix a loop timeout test Dan Carpenter
2017-12-09 11:52 ` Dan Carpenter
2017-12-09 13:33 ` [PATCH 1/2] ASoC: nuc900: Fix platform_get_irq() error checking some more arvindY
2017-12-09 13:45 ` arvindY
2017-12-09 17:27 ` [alsa-devel] " Alexandre Belloni
2017-12-09 17:27 ` Alexandre Belloni
2017-12-09 18:37 ` arvindY
2017-12-09 18:49 ` arvindY
2017-12-10 1:52 ` Dan Carpenter
2017-12-10 1:52 ` Dan Carpenter
2017-12-10 2:40 ` [alsa-devel] " arvindY
2017-12-10 2:52 ` arvindY
2017-12-11 8:40 ` Dan Carpenter
2017-12-11 8:40 ` Dan Carpenter
2017-12-11 9:07 ` [alsa-devel] " Arvind Yadav
2017-12-11 9:19 ` Arvind Yadav
2017-12-11 10:27 ` Dan Carpenter
2017-12-11 10:27 ` Dan Carpenter
2017-12-11 11:49 ` [alsa-devel] " Alexandre Belloni
2017-12-11 11:49 ` Alexandre Belloni
2017-12-11 12:01 ` Dan Carpenter
2017-12-11 12:01 ` Dan Carpenter
2017-12-11 16:41 ` Alexandre Belloni [this message]
2017-12-11 16:41 ` [alsa-devel] " Alexandre Belloni
2017-12-11 12:02 ` Mark Brown
2017-12-11 12:02 ` Mark Brown
2017-12-11 12:14 ` Applied "ASoC: nuc900: Fix platform_get_irq() error checking some more" to the asoc tree Mark Brown
2017-12-11 12:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211164134.GE32306@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.