* [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U
@ 2017-12-12 0:51 Fam Zheng
2017-12-12 9:08 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fam Zheng @ 2017-12-12 0:51 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, qemu-block, kchamart, eblake, Kevin Wolf, Max Reitz
Signed-off-by: Fam Zheng <famz@redhat.com>
---
v4: "images". [Kevin]
v3: Document that the option is not allowed for read-write. [Stefan]
v2: - "code{qemu-img}". [Kashyap, Eric]
- "etc.." -> "etc.".
---
qemu-img.texi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index fdcf120f36..d93501f94f 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
the @var{-n} parameter to skip image creation. This restriction may be relaxed
in a future release.
+@item --force-share (-U)
+
+If specified, @code{qemu-img} will open the image with shared permissions,
+which makes it less likely to conflict with a running guest's permissions due
+to image locking. For example, this can be used to get the image information
+(with 'info' subcommand) when the image is used by a running guest. Note that
+this could produce inconsistent result because of concurrent metadata changes,
+etc. This option is only allowed when opening images in read-only mode.
+
@item fmt
is the disk image format. It is guessed automatically in most cases. See below
for a description of the supported disk formats.
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U
2017-12-12 0:51 [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U Fam Zheng
@ 2017-12-12 9:08 ` Stefan Hajnoczi
2017-12-12 10:05 ` Kashyap Chamarthy
2017-12-12 13:13 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-12-12 9:08 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, qemu-block, kchamart, eblake, Kevin Wolf, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On Tue, Dec 12, 2017 at 08:51:13AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
>
> v4: "images". [Kevin]
>
> v3: Document that the option is not allowed for read-write. [Stefan]
>
> v2: - "code{qemu-img}". [Kashyap, Eric]
> - "etc.." -> "etc.".
> ---
> qemu-img.texi | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U
2017-12-12 0:51 [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U Fam Zheng
2017-12-12 9:08 ` Stefan Hajnoczi
@ 2017-12-12 10:05 ` Kashyap Chamarthy
2017-12-12 13:13 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kashyap Chamarthy @ 2017-12-12 10:05 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, stefanha, qemu-block, eblake, Kevin Wolf, Max Reitz
On Tue, Dec 12, 2017 at 08:51:13AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
[...]
> qemu-img.texi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index fdcf120f36..d93501f94f 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
> the @var{-n} parameter to skip image creation. This restriction may be relaxed
> in a future release.
>
> +@item --force-share (-U)
> +
> +If specified, @code{qemu-img} will open the image with shared permissions,
> +which makes it less likely to conflict with a running guest's permissions due
> +to image locking. For example, this can be used to get the image information
> +(with 'info' subcommand) when the image is used by a running guest. Note that
> +this could produce inconsistent result because of concurrent metadata changes,
> +etc. This option is only allowed when opening images in read-only mode.
> +
Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>
--
/kashyap
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U
2017-12-12 0:51 [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U Fam Zheng
2017-12-12 9:08 ` Stefan Hajnoczi
2017-12-12 10:05 ` Kashyap Chamarthy
@ 2017-12-12 13:13 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2017-12-12 13:13 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, stefanha, qemu-block, kchamart, eblake, Max Reitz
Am 12.12.2017 um 01:51 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
>
> v4: "images". [Kevin]
>
> v3: Document that the option is not allowed for read-write. [Stefan]
>
> v2: - "code{qemu-img}". [Kashyap, Eric]
> - "etc.." -> "etc.".
> ---
> qemu-img.texi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index fdcf120f36..d93501f94f 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use
> the @var{-n} parameter to skip image creation. This restriction may be relaxed
> in a future release.
>
> +@item --force-share (-U)
> +
> +If specified, @code{qemu-img} will open the image with shared permissions,
> +which makes it less likely to conflict with a running guest's permissions due
> +to image locking. For example, this can be used to get the image information
> +(with 'info' subcommand) when the image is used by a running guest. Note that
> +this could produce inconsistent result because of concurrent metadata changes,
Each time you read a text, you find something new...
s/result/results/
> +etc. This option is only allowed when opening images in read-only mode.
> +
Thanks, fixed the above and applied the patch to block-next.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-12 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 0:51 [Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U Fam Zheng
2017-12-12 9:08 ` Stefan Hajnoczi
2017-12-12 10:05 ` Kashyap Chamarthy
2017-12-12 13:13 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.