[PATCH net] skge: remove redundunt free_irq under spinlock

[PATCH net] skge: remove redundunt free_irq under spinlock

[Stephen Hemminger]

The code to handle multi-port SKGE boards was freeing IRQ
twice. The first one was under lock and might sleep.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Given that multi-port SKGE devices are very old and unlikely
to still be in use. This patch does not need to go to stable.

 drivers/net/ethernet/marvell/skge.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 6e423f098a60..31efc47c847e 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4081,7 +4081,6 @@ static void skge_remove(struct pci_dev *pdev)
 	if (hw->ports > 1) {
 		skge_write32(hw, B0_IMSK, 0);
 		skge_read32(hw, B0_IMSK);
-		free_irq(pdev->irq, hw);
 	}
 	spin_unlock_irq(&hw->hw_lock);
 
-- 
2.11.0

Re: [PATCH net] skge: remove redundunt free_irq under spinlock

[David Miller]

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 12 Dec 2017 10:30:29 -0800

> The code to handle multi-port SKGE boards was freeing IRQ
> twice. The first one was under lock and might sleep.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> Given that multi-port SKGE devices are very old and unlikely
> to still be in use. This patch does not need to go to stable.

Applied, thanks Stephen.