* [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310
@ 2017-12-12 12:53 Russell King
2017-12-12 14:59 ` Andrew Lunn
2017-12-13 20:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2017-12-12 12:53 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli; +Cc: netdev
Remove XGMII as an option for the 88x3310 PHY driver, as the PHY doesn't
support XGMII's 32-bit data lanes. It supports USXGMII, which is not
XGMII, but a single-lane serdes interface - see
https://developer.cisco.com/site/usgmii-usxgmii/
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/marvell10g.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index aebc08beceba..e618534034fe 100644
--- a/drivers/net/phy/marvell10g.c
+++ b/drivers/net/phy/marvell10g.c
@@ -83,7 +83,6 @@ static int mv3310_config_init(struct phy_device *phydev)
/* Check that the PHY interface type is compatible */
if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
- phydev->interface != PHY_INTERFACE_MODE_XGMII &&
phydev->interface != PHY_INTERFACE_MODE_XAUI &&
phydev->interface != PHY_INTERFACE_MODE_RXAUI &&
phydev->interface != PHY_INTERFACE_MODE_10GKR)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310
2017-12-12 12:53 [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310 Russell King
@ 2017-12-12 14:59 ` Andrew Lunn
2017-12-13 20:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-12-12 14:59 UTC (permalink / raw)
To: Russell King; +Cc: Florian Fainelli, netdev
On Tue, Dec 12, 2017 at 12:53:18PM +0000, Russell King wrote:
> Remove XGMII as an option for the 88x3310 PHY driver, as the PHY doesn't
> support XGMII's 32-bit data lanes. It supports USXGMII, which is not
> XGMII, but a single-lane serdes interface - see
> https://developer.cisco.com/site/usgmii-usxgmii/
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310
2017-12-12 12:53 [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310 Russell King
2017-12-12 14:59 ` Andrew Lunn
@ 2017-12-13 20:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-12-13 20:05 UTC (permalink / raw)
To: rmk+kernel; +Cc: andrew, f.fainelli, netdev
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Tue, 12 Dec 2017 12:53:18 +0000
> Remove XGMII as an option for the 88x3310 PHY driver, as the PHY doesn't
> support XGMII's 32-bit data lanes. It supports USXGMII, which is not
> XGMII, but a single-lane serdes interface - see
> https://developer.cisco.com/site/usgmii-usxgmii/
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-13 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 12:53 [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310 Russell King
2017-12-12 14:59 ` Andrew Lunn
2017-12-13 20:05 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.