From: David Miller <davem@davemloft.net>
To: baijiaju1990@gmail.com
Cc: perex@perex.cz, floeff@mathematik.uni-stuttgart.de,
acme@conectiva.com.br, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub
Date: Wed, 13 Dec 2017 22:34:32 -0500 (EST) [thread overview]
Message-ID: <20171213.223432.393103915049464102.davem@davemloft.net> (raw)
In-Reply-To: <18472c42-4eaf-7189-a16f-489a706cba3e@gmail.com>
From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Thu, 14 Dec 2017 11:13:15 +0800
> Thanks for reply :)
> I think I should use "udelay(100000/HZ)" instead, do you think it is
> right?
The delay is too long, please do not ignore that part of my critique
of your change.
You cannot delay so long under a lock, that's why the code is trying
to use a sleeping delay.
I'm not going to explain this problem another time.
next prev parent reply other threads:[~2017-12-14 3:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 9:47 [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub Jia-Ju Bai
2017-12-13 21:20 ` David Miller
2017-12-14 3:13 ` Jia-Ju Bai
2017-12-14 3:31 ` Jia-Ju Bai
2017-12-14 3:34 ` David Miller [this message]
2017-12-14 3:56 ` Jia-Ju Bai
2017-12-15 11:13 ` Siegfried Loeffler
2017-12-14 1:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213.223432.393103915049464102.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@conectiva.com.br \
--cc=baijiaju1990@gmail.com \
--cc=floeff@mathematik.uni-stuttgart.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.