All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, Zi Yan <zi.yan@cs.rutgers.edu>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Reale <ar@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move
Date: Wed, 13 Dec 2017 13:17:03 +0100	[thread overview]
Message-ID: <20171213121703.GD25185@dhcp22.suse.cz> (raw)
In-Reply-To: <20171213120733.umeb7rylswl7chi5@node.shutemov.name>

On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote:
[...]
> The approach looks fine to me.
> 
> But patch is rather large and hard to review. And how git mixed add/remove
> lines doesn't help too. Any chance to split it up further?

I was trying to do that but this is a drop in replacement so it is quite
hard to do in smaller pieces. I've already put the allocation callback
cleanup into a separate one but this is about all that I figured how to
split. If you have any suggestions I am willing to try them out.

> One nitpick: I don't think 'chunk' terminology should go away with the
> patch.

Not sure what you mean here. I have kept chunk_start, chunk_node, so I
am not really changing that terminology

Thanks!
-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, Zi Yan <zi.yan@cs.rutgers.edu>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Reale <ar@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move
Date: Wed, 13 Dec 2017 13:17:03 +0100	[thread overview]
Message-ID: <20171213121703.GD25185@dhcp22.suse.cz> (raw)
In-Reply-To: <20171213120733.umeb7rylswl7chi5@node.shutemov.name>

On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote:
[...]
> The approach looks fine to me.
> 
> But patch is rather large and hard to review. And how git mixed add/remove
> lines doesn't help too. Any chance to split it up further?

I was trying to do that but this is a drop in replacement so it is quite
hard to do in smaller pieces. I've already put the allocation callback
cleanup into a separate one but this is about all that I figured how to
split. If you have any suggestions I am willing to try them out.

> One nitpick: I don't think 'chunk' terminology should go away with the
> patch.

Not sure what you mean here. I have kept chunk_start, chunk_node, so I
am not really changing that terminology

Thanks!
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-12-13 12:17 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 12:48 [RFC PATCH] mm: unclutter THP migration Michal Hocko
2017-12-07 12:48 ` Michal Hocko
2017-12-07 14:10 ` Zi Yan
2017-12-07 14:34   ` Michal Hocko
2017-12-07 14:34     ` Michal Hocko
2017-12-08 16:15     ` [RFC PATCH 0/3] " Michal Hocko
2017-12-08 16:15       ` Michal Hocko
2017-12-08 16:15       ` [RFC PATCH 1/3] mm, numa: rework do_pages_move Michal Hocko
2017-12-08 16:15         ` Michal Hocko
2017-12-13 12:07         ` Kirill A. Shutemov
2017-12-13 12:07           ` Kirill A. Shutemov
2017-12-13 12:17           ` Michal Hocko [this message]
2017-12-13 12:17             ` Michal Hocko
2017-12-13 12:47             ` Kirill A. Shutemov
2017-12-13 12:47               ` Kirill A. Shutemov
2017-12-13 14:10               ` Michal Hocko
2017-12-13 14:10                 ` Michal Hocko
2017-12-13 14:27                 ` Kirill A. Shutemov
2017-12-13 14:27                   ` Kirill A. Shutemov
2017-12-13 14:39         ` Michal Hocko
2017-12-13 14:39           ` Michal Hocko
2017-12-14 15:35           ` Kirill A. Shutemov
2017-12-14 15:35             ` Kirill A. Shutemov
2017-12-15  9:28             ` Michal Hocko
2017-12-15  9:28               ` Michal Hocko
2017-12-15  9:51               ` Kirill A. Shutemov
2017-12-15  9:51                 ` Kirill A. Shutemov
2017-12-15  9:57                 ` Michal Hocko
2017-12-15  9:57                   ` Michal Hocko
2018-01-02 11:25         ` Anshuman Khandual
2018-01-02 11:25           ` Anshuman Khandual
2018-01-02 12:12           ` Michal Hocko
2018-01-02 12:12             ` Michal Hocko
2018-01-03  3:11             ` Anshuman Khandual
2018-01-03  3:11               ` Anshuman Khandual
2018-01-03  8:42         ` Anshuman Khandual
2018-01-03  8:42           ` Anshuman Khandual
2018-01-03  8:58           ` Michal Hocko
2018-01-03  8:58             ` Michal Hocko
2018-01-03  9:36             ` Anshuman Khandual
2018-01-03  9:36               ` Anshuman Khandual
2018-01-03  9:52               ` Michal Hocko
2018-01-03  9:52                 ` Michal Hocko
2017-12-08 16:15       ` [RFC PATCH 2/3] mm, migrate: remove reason argument from new_page_t Michal Hocko
2017-12-08 16:15         ` Michal Hocko
2017-12-27  2:12         ` Zi Yan
2017-12-29 11:32           ` Michal Hocko
2017-12-29 11:32             ` Michal Hocko
2017-12-08 16:15       ` [RFC PATCH 3/3] mm: unclutter THP migration Michal Hocko
2017-12-08 16:15         ` Michal Hocko
2017-12-13 12:20         ` Kirill A. Shutemov
2017-12-13 12:20           ` Kirill A. Shutemov
2017-12-27  2:19         ` Zi Yan
2017-12-29 11:36           ` Michal Hocko
2017-12-29 11:36             ` Michal Hocko
2017-12-29 15:45             ` Zi Yan
2017-12-31  9:07               ` Michal Hocko
2017-12-31  9:07                 ` Michal Hocko
2017-12-31 13:09                 ` Zi Yan
2017-12-19 12:07       ` [RFC PATCH 0/3] " Michal Hocko
2017-12-19 12:07         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213121703.GD25185@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ar@linux.vnet.ibm.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=vbabka@suse.cz \
    --cc=zi.yan@cs.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.