From: Mahesh Bandewar <mahesh@bandewar.net>
To: David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Mahesh Bandewar <mahesh@bandewar.net>,
Mahesh Bandewar <maheshb@google.com>
Subject: [PATCH next 0/2] ipvlan: packet scrub
Date: Wed, 13 Dec 2017 14:40:12 -0800 [thread overview]
Message-ID: <20171213224012.202819-1-mahesh@bandewar.net> (raw)
From: Mahesh Bandewar <maheshb@google.com>
While crossing namespace boundary IPvlan aggressively scrubs packets.
This is creating problems. First thing is that scrubbing changes the
packet type in skb meta-data to PACKET_HOST. This causes erroneous
packet delivery when dev_forward_skb() has already marked the packet
type as OTHER_HOST.
On the egress side scrubbing just before calling dev_queue_xmit()
creates another set of problems. Scrubbing remove skb->sk so the
prio update gets missed and more seriously, socket back-pressure
fails making TSQ not function correctly.
The first patch in the series just reverts the earlier change which
was adding a mac-check, but that is unnecessary if packet_type that
dev_forward_skb() has set is honored. The second path removes two of
the scrubs which are causing problems described above.
Mahesh Bandewar (2):
Revert "ipvlan: add L2 check for packets arriving via virtual devices"
ipvlan: remove excessive packet scrubbing
drivers/net/ipvlan/ipvlan_core.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
--
2.15.1.424.g9478a66081-goog
next reply other threads:[~2017-12-13 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 22:40 Mahesh Bandewar [this message]
2017-12-15 16:37 ` [PATCH next 0/2] ipvlan: packet scrub David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213224012.202819-1-mahesh@bandewar.net \
--to=mahesh@bandewar.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.