All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2] spi: s3c64xx: add SPDX identifier
Date: Thu, 14 Dec 2017 10:31:09 +0900	[thread overview]
Message-ID: <20171214013109.GC11657@gangnam.samsung> (raw)
In-Reply-To: <CAOFm3uHP-4UN+gzXzZc1ptptFm5f9uhafKyE963+DiamzdRTdw@mail.gmail.com>

Hi Philippe,

> > diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h
> > index da79774078a7..8917f38c97c5 100644
> > --- a/include/linux/platform_data/spi-s3c64xx.h
> > +++ b/include/linux/platform_data/spi-s3c64xx.h
> > @@ -2,9 +2,7 @@
> >   * Copyright (C) 2009 Samsung Electronics Ltd.
> >   *     Jaswinder Singh <jassi.brar@samsung.com>
> >   *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > + * SPDX-License-Identifier: GPL-2.0
> >   */
> >
> >  #ifndef __SPI_S3C64XX_H
> > --
> > 2.15.1
> >
> 
> 
> You still need to put this line at the very top of the file, first
> line. That's the convention for the SPDX tags as documented by Thomas
> Gleixner.

I had some doubts on this one, indeed. How should it be done in
this case:

1. Strictly by Thomas documentation:

  /* SPDX-License-Identifier: GPL-2.0 */

  /*
   * Copyright (C) 2009 Samsung Electronics Ltd.
   *     Jaswinder Singh <jassi.brar@samsung.com>
   */

or

2. with a little interpretation

  /*
   * SPDX-License-Identifier: GPL-2.0
   *
   * Copyright (C) 2009 Samsung Electronics Ltd.
   *     Jaswinder Singh <jassi.brar@samsung.com>
   */

(I opted for the one with the least number of changes)

Thanks,
Andi

> > + * SPDX-License-Identifier: GPL-2.0
> 
> 
> -- 
> Cordially
> Philippe Ombredanne
> 

  reply	other threads:[~2017-12-14  1:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171213080544epcas2p29731b6c65f760ab1b9ac71d530fcaf77@epcas2p2.samsung.com>
2017-12-13  8:05 ` [PATCH v2] spi: s3c64xx: add SPDX identifier Andi Shyti
2017-12-13  8:13   ` Krzysztof Kozlowski
2017-12-13  9:20   ` Philippe Ombredanne
2017-12-14  1:31     ` Andi Shyti [this message]
2017-12-14  6:16       ` Philippe Ombredanne
2017-12-14 10:41       ` Mark Brown
2017-12-14 11:00         ` Geert Uytterhoeven
2017-12-14 11:00           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214013109.GC11657@gangnam.samsung \
    --to=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=broonie@kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.