All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ethtool: fix MFLCN register dump for 82599 and newer
@ 2017-12-13  4:43 tjbroadroad
  2017-12-14 18:45 ` John W. Linville
  0 siblings, 1 reply; 4+ messages in thread
From: tjbroadroad @ 2017-12-13  4:43 UTC (permalink / raw)
  To: linville, netdev; +Cc: Broadroad, Gao Wayne, Wei Net

From: Broadroad <tjbroadroad@163.com>

Use MFLCN for 82599 and X540 HW instead of FCTRL.

Signed-off-by: Zhang Kang <tjbroadroad@163.com>
Signed-off-by: Gao Wayne <Wayne.Gao@emc.com>
Signed-off-by: Wei Net <gw_net@163.com>
---
 ixgbe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ixgbe.c b/ixgbe.c
index ff0e769..c632137 100644
--- a/ixgbe.c
+++ b/ixgbe.c
@@ -232,9 +232,9 @@ ixgbe_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 		"       Receive Priority Flow Control Packets:         %s\n",
 		reg,
 		reg & IXGBE_MFLCN_RFCE    ? "enabled"  : "disabled",
-		reg & IXGBE_FCTRL_DPF     ? "enabled"  : "disabled",
-		reg & IXGBE_FCTRL_PMCF    ? "enabled"  : "disabled",
-		reg & IXGBE_FCTRL_RPFCE   ? "enabled"  : "disabled");
+		reg & IXGBE_MFLCN_DPF     ? "enabled"  : "disabled",
+		reg & IXGBE_MFLCN_PMCF    ? "enabled"  : "disabled",
+		reg & IXGBE_MFLCN_RPFCE   ? "enabled"  : "disabled");
 	}
 
 	reg = regs_buff[516];
-- 
2.10.2.windows.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ethtool: fix MFLCN register dump for 82599 and newer
  2017-12-13  4:43 [PATCH] ethtool: fix MFLCN register dump for 82599 and newer tjbroadroad
@ 2017-12-14 18:45 ` John W. Linville
  0 siblings, 0 replies; 4+ messages in thread
From: John W. Linville @ 2017-12-14 18:45 UTC (permalink / raw)
  To: tjbroadroad; +Cc: netdev, Gao Wayne, Wei Net

On Wed, Dec 13, 2017 at 12:43:50PM +0800, tjbroadroad@163.com wrote:
> From: Broadroad <tjbroadroad@163.com>
> 
> Use MFLCN for 82599 and X540 HW instead of FCTRL.
> 
> Signed-off-by: Zhang Kang <tjbroadroad@163.com>

Might I ask you to use a consistent name<->email mapping? Preferrably
your legal name, but definitely something consistent and identifiable.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ethtool: fix MFLCN register dump for 82599 and newer
  2017-12-15  1:56 Zhang Kang
@ 2017-12-18 18:38 ` John W. Linville
  0 siblings, 0 replies; 4+ messages in thread
From: John W. Linville @ 2017-12-18 18:38 UTC (permalink / raw)
  To: Zhang Kang; +Cc: netdev, Gao Wayne, Wei Net

On Fri, Dec 15, 2017 at 09:56:51AM +0800, Zhang Kang wrote:
> Use MFLCN for 82599 and X540 HW instead of FCTRL.
> 
> Signed-off-by: Zhang Kang <tjbroadroad@163.com>
> Signed-off-by: Gao Wayne <Wayne.Gao@emc.com>
> Signed-off-by: Wei Net <gw_net@163.com>

Thanks, applied.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ethtool: fix MFLCN register dump for 82599 and newer
@ 2017-12-15  1:56 Zhang Kang
  2017-12-18 18:38 ` John W. Linville
  0 siblings, 1 reply; 4+ messages in thread
From: Zhang Kang @ 2017-12-15  1:56 UTC (permalink / raw)
  To: linville, netdev; +Cc: Zhang Kang, Gao Wayne, Wei Net

Use MFLCN for 82599 and X540 HW instead of FCTRL.

Signed-off-by: Zhang Kang <tjbroadroad@163.com>
Signed-off-by: Gao Wayne <Wayne.Gao@emc.com>
Signed-off-by: Wei Net <gw_net@163.com>
---
 ixgbe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ixgbe.c b/ixgbe.c
index ff0e769..c632137 100644
--- a/ixgbe.c
+++ b/ixgbe.c
@@ -232,9 +232,9 @@ ixgbe_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 		"       Receive Priority Flow Control Packets:         %s\n",
 		reg,
 		reg & IXGBE_MFLCN_RFCE    ? "enabled"  : "disabled",
-		reg & IXGBE_FCTRL_DPF     ? "enabled"  : "disabled",
-		reg & IXGBE_FCTRL_PMCF    ? "enabled"  : "disabled",
-		reg & IXGBE_FCTRL_RPFCE   ? "enabled"  : "disabled");
+		reg & IXGBE_MFLCN_DPF     ? "enabled"  : "disabled",
+		reg & IXGBE_MFLCN_PMCF    ? "enabled"  : "disabled",
+		reg & IXGBE_MFLCN_RPFCE   ? "enabled"  : "disabled");
 	}
 
 	reg = regs_buff[516];
-- 
2.10.2.windows.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-12-18 18:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-13  4:43 [PATCH] ethtool: fix MFLCN register dump for 82599 and newer tjbroadroad
2017-12-14 18:45 ` John W. Linville
2017-12-15  1:56 Zhang Kang
2017-12-18 18:38 ` John W. Linville

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.