Re: [PATCH] cgroup/cpuset: fix circular locking dependency

From: Tejun Heo <tj@kernel.org>
To: Prateek Sood <prsood@codeaurora.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	avagin@gmail.com, mingo@kernel.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, sramana@codeaurora.org
Subject: Re: [PATCH] cgroup/cpuset: fix circular locking dependency
Date: Fri, 15 Dec 2017 05:22:22 -0800	[thread overview]
Message-ID: <20171215132222.GF3919388@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <c282b638-95ef-b688-9249-f23a733c0a43@codeaurora.org>

Hello, Prateek.

On Fri, Dec 15, 2017 at 02:24:55PM +0530, Prateek Sood wrote:
> Following are two ways to improve cgroup_transfer_tasks(). In
> both cases task in PF_EXITING state would be left in source
> cgroup. It would be removed from cgroup_exit() in exit path.
> 
> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
> index 024085d..e2bdcdb 100644
> --- a/kernel/cgroup/cgroup-v1.c
> +++ b/kernel/cgroup/cgroup-v1.c
> @@ -123,7 +123,10 @@ int cgroup_transfer_tasks(struct cgroup *to, struct cgroup *from)
>          */
>         do {
>                 css_task_iter_start(&from->self, 0, &it);
> -               task = css_task_iter_next(&it);
> +               do {
> +                       task = css_task_iter_next(&it);
> +               } while (task && (task & PF_EXITING))
> +

Yeah, this looks good to me.  We can't just make a single pass as in
the other one because we can race aginst fork.  And PF_EXITING being
left behind is what was happening previously too anyway.  They can't
be moved.

Thanks.

-- 
tejun