All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Caleb Crome <caleb@crome.org>
Cc: Timur Tabi <timur@tabi.org>, Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	alsa-devel@alsa-project.org,
	Fabio Estevam <fabio.estevam@nxp.com>,
	mail@maciej.szmigiero.name, Liam Girdwood <lgirdwood@gmail.com>,
	Arnaud Mouiche <arnaud.mouiche@invoxia.com>,
	lukma@denx.de, Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments
Date: Sat, 16 Dec 2017 09:49:33 -0800	[thread overview]
Message-ID: <20171216174932.GB3840@Asurada> (raw)
In-Reply-To: <CAG5mAdw04U5gpRMqLYOBeujH=t+59WJLFeGe+Qareh-cuWsDvg@mail.gmail.com>

On Sat, Dec 16, 2017 at 09:30:14AM -0800, Caleb Crome wrote:

> Having come to work on this driver with very little knowledge about
> kernel programming, and i.MX, I have to agree with Timur. It's an
> amazingly complex driver (with support of so many variants).  By
> eliminating verbose commentary, it's also wiping away a lot of
> knowledge.  The more sparse commentary makes things harder to
> understand for newcomers, or really anybody who isn't already steeped
> in knowledge about the SSI port and linux, and it's interaction with
> DMA.

I never said that I don't agree with Timur. Every change here is
to simplify things. As long as Timur or any reviewer feels one of
new comments is harder to understand, I am totally fine to rework.
I respect everyone's opinion, but I hope everyone can respect my
effort too by telling me which one needs to rework and why?

Thanks
Nicolin

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Caleb Crome <caleb@crome.org>
Cc: alsa-devel@alsa-project.org, Sascha Hauer <kernel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>, Timur Tabi <timur@tabi.org>,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Arnaud Mouiche <arnaud.mouiche@invoxia.com>,
	lukma@denx.de, Fabio Estevam <fabio.estevam@nxp.com>,
	mail@maciej.szmigiero.name, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments
Date: Sat, 16 Dec 2017 09:49:33 -0800	[thread overview]
Message-ID: <20171216174932.GB3840@Asurada> (raw)
In-Reply-To: <CAG5mAdw04U5gpRMqLYOBeujH=t+59WJLFeGe+Qareh-cuWsDvg@mail.gmail.com>

On Sat, Dec 16, 2017 at 09:30:14AM -0800, Caleb Crome wrote:

> Having come to work on this driver with very little knowledge about
> kernel programming, and i.MX, I have to agree with Timur. It's an
> amazingly complex driver (with support of so many variants).  By
> eliminating verbose commentary, it's also wiping away a lot of
> knowledge.  The more sparse commentary makes things harder to
> understand for newcomers, or really anybody who isn't already steeped
> in knowledge about the SSI port and linux, and it's interaction with
> DMA.

I never said that I don't agree with Timur. Every change here is
to simplify things. As long as Timur or any reviewer feels one of
new comments is harder to understand, I am totally fine to rework.
I respect everyone's opinion, but I hope everyone can respect my
effort too by telling me which one needs to rework and why?

Thanks
Nicolin

  parent reply	other threads:[~2017-12-16 17:49 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 23:18 [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-13 23:18 ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-13 23:18   ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-13 23:18   ` Nicolin Chen
2017-12-16  4:43   ` Timur Tabi
2017-12-16  4:43     ` Timur Tabi
     [not found]     ` <CAGoOwPSqf4oKB=gZdD8=W=q9y=CcpjYyUuWkmfm7dQc+P6QDmw@mail.gmail.com>
2017-12-16  6:10       ` Nicolin Chen
2017-12-16  6:10         ` Nicolin Chen
2017-12-16 16:27         ` Timur Tabi
2017-12-16 17:34           ` Nicolin Chen
2017-12-16 17:15   ` Timur Tabi
2017-12-16 17:30     ` Caleb Crome
2017-12-16 17:30       ` Caleb Crome
2017-12-16 17:47       ` Timur Tabi
2017-12-16 17:49       ` Nicolin Chen [this message]
2017-12-16 17:49         ` Nicolin Chen
2017-12-16 18:31         ` Timur Tabi
2017-12-16 18:31           ` Timur Tabi
2017-12-16 19:19           ` Nicolin Chen
2017-12-16 19:19             ` Nicolin Chen
2017-12-16 19:17     ` Nicolin Chen
2017-12-16 19:17       ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-13 23:18   ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-13 23:18   ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-13 23:18   ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 08/11] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-19 10:59   ` Applied "ASoC: fsl_ssi: Rename scr_val to scr" to the asoc tree Mark Brown
2017-12-19 10:59     ` Mark Brown
2017-12-13 23:18 ` [PATCH v3 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen
2017-12-16  4:53 ` [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level Timur Tabi
2017-12-16  6:56   ` Nicolin Chen
2017-12-16  6:56     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171216174932.GB3840@Asurada \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.mouiche@invoxia.com \
    --cc=broonie@kernel.org \
    --cc=caleb@crome.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukma@denx.de \
    --cc=mail@maciej.szmigiero.name \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.