All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/3] drm/i915: Re-enable GGTT earlier after GPU reset
Date: Sun, 17 Dec 2017 13:28:50 +0000	[thread overview]
Message-ID: <20171217132852.30642-1-chris@chris-wilson.co.uk> (raw)

Inside i915_gem_reset(), we start touching the HW and so require the
low-level HW to be re-enabled, in particular the PCI BARs.

Fixes: 7b6da818d86f ("drm/i915: Restore the kernel context after a GPU reset on an idle engine")
Testcase: igt/drv_hangman # i915g/i915gm
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 6d39fdf2b604..72bea281edb7 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1924,9 +1924,6 @@ void i915_reset(struct drm_i915_private *i915, unsigned int flags)
 		goto taint;
 	}
 
-	i915_gem_reset(i915);
-	intel_overlay_reset(i915);
-
 	/* Ok, now get things going again... */
 
 	/*
@@ -1939,6 +1936,9 @@ void i915_reset(struct drm_i915_private *i915, unsigned int flags)
 		goto error;
 	}
 
+	i915_gem_reset(i915);
+	intel_overlay_reset(i915);
+
 	/*
 	 * Next we need to restore the context, but we don't use those
 	 * yet either...
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2017-12-17 13:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-17 13:28 Chris Wilson [this message]
2017-12-17 13:28 ` [PATCH 2/3] drm/i915: Show IPEIR and IPEHR in the engine dump Chris Wilson
2017-12-18 11:14   ` Tvrtko Ursulin
2017-12-18 11:18     ` Chris Wilson
2017-12-18 11:14   ` Chris Wilson
2017-12-18 11:26   ` [PATCH v2] " Chris Wilson
2017-12-18 12:08     ` Tvrtko Ursulin
2017-12-18 12:17   ` [PATCH v3] " Chris Wilson
2017-12-18 12:32     ` Tvrtko Ursulin
2017-12-18 12:35       ` Chris Wilson
2017-12-18 12:39   ` [PATCH v4] " Chris Wilson
2017-12-18 12:58     ` Tvrtko Ursulin
2017-12-18 13:27       ` Chris Wilson
2017-12-17 13:28 ` [PATCH 3/3] drm/i915/selftests: Fix up igt_reset_engine Chris Wilson
2017-12-18 21:50   ` Michel Thierry
2017-12-18 21:54     ` Chris Wilson
2017-12-17 14:07 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Re-enable GGTT earlier after GPU reset Patchwork
2017-12-17 15:36 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-17 18:19 ` [PATCH 1/3] " Chris Wilson
2017-12-18 11:11 ` Tvrtko Ursulin
2017-12-18 11:19   ` Chris Wilson
2017-12-18 13:13 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Re-enable GGTT earlier after GPU reset (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171217132852.30642-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.