* [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove
@ 2017-12-18 10:16 Alice Michael
2017-12-22 16:17 ` Bowers, AndrewX
0 siblings, 1 reply; 3+ messages in thread
From: Alice Michael @ 2017-12-18 10:16 UTC (permalink / raw)
To: intel-wired-lan
From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
flush_schedule_work blocks until completion of all scheduled
work items in global work-queue. This can cause deadlock in some
cases. i40evf_remove() cleans up necessary work items with
cancel_delayed_work_sync and cancel_work_sync. This fix removes
flush_schedule_work call inside i40evf_remove().
Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
---
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index f92587a..6472116 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -3088,8 +3088,6 @@ static void i40evf_remove(struct pci_dev *pdev)
if (adapter->watchdog_timer.function)
del_timer_sync(&adapter->watchdog_timer);
- flush_scheduled_work();
-
i40evf_free_rss(adapter);
if (hw->aq.asq.count)
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove
2017-12-18 10:16 [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove Alice Michael
@ 2017-12-22 16:17 ` Bowers, AndrewX
0 siblings, 0 replies; 3+ messages in thread
From: Bowers, AndrewX @ 2017-12-22 16:17 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alice Michael
> Sent: Monday, December 18, 2017 2:16 AM
> To: Michael, Alice <alice.michael@intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove
> flush_scheduled_work call in i40evf_remove
>
> From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
>
> flush_schedule_work blocks until completion of all scheduled work items in
> global work-queue. This can cause deadlock in some cases. i40evf_remove()
> cleans up necessary work items with cancel_delayed_work_sync and
> cancel_work_sync. This fix removes flush_schedule_work call inside
> i40evf_remove().
>
> Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
> ---
> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 --
> 1 file changed, 2 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove
2017-12-15 15:25 [Intel-wired-lan] [next PATCH S83-V5 1/9] i40e/i40evf: Enable NVMUpdate to retrieve AdminQ and add preservation flags for NVM update Alice Michael
@ 2017-12-15 15:25 ` Alice Michael
0 siblings, 0 replies; 3+ messages in thread
From: Alice Michael @ 2017-12-15 15:25 UTC (permalink / raw)
To: intel-wired-lan
From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
flush_schedule_work blocks until completion of all scheduled
work items in global work-queue. This can cause deadlock in some
cases. i40evf_remove() cleans up necessary work items with
cancel_delayed_work_sync and cancel_work_sync. This fix removes
flush_schedule_work call inside i40evf_remove().
Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
---
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index f92587a..6472116 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -3088,8 +3088,6 @@ static void i40evf_remove(struct pci_dev *pdev)
if (adapter->watchdog_timer.function)
del_timer_sync(&adapter->watchdog_timer);
- flush_scheduled_work();
-
i40evf_free_rss(adapter);
if (hw->aq.asq.count)
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-22 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-18 10:16 [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove Alice Michael
2017-12-22 16:17 ` Bowers, AndrewX
-- strict thread matches above, loose matches on Subject: below --
2017-12-15 15:25 [Intel-wired-lan] [next PATCH S83-V5 1/9] i40e/i40evf: Enable NVMUpdate to retrieve AdminQ and add preservation flags for NVM update Alice Michael
2017-12-15 15:25 ` [Intel-wired-lan] [next PATCH S83-V5 3/9] i40evf: remove flush_scheduled_work call in i40evf_remove Alice Michael
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.