All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2017-12-18 10:27 ` Jerome Brunet
  0 siblings, 0 replies; 7+ messages in thread
From: Jerome Brunet @ 2017-12-18 10:27 UTC (permalink / raw)
  To: Kevin Hilman, Carlo Caione
  Cc: Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel

Add the interrupt of the internal ethernet PHY

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Hi Kevin,

This changes depends on the net-next changes adding interrupt support [0].
It is really important that this change is not merged before its
dependency.

If it is merged before, instead of polling, the phy would wait for an
interrupt which has not been configured and will never fire.

Tested on the libretech-cc and khadas VIM.

Cheers
Jerome

https://lkml.kernel.org/r/20171218094446.31912-7-jbrunet@baylibre.com

 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 4a316a11a00e..8bc404508a4f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -631,6 +631,7 @@
 
 			internal_phy: ethernet-phy@8 {
 				compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22";
+				interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
 				reg = <8>;
 				max-speed = <100>;
 			};
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2017-12-18 10:27 ` Jerome Brunet
  0 siblings, 0 replies; 7+ messages in thread
From: Jerome Brunet @ 2017-12-18 10:27 UTC (permalink / raw)
  To: Kevin Hilman, Carlo Caione
  Cc: Jerome Brunet, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Add the interrupt of the internal ethernet PHY

Signed-off-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
Hi Kevin,

This changes depends on the net-next changes adding interrupt support [0].
It is really important that this change is not merged before its
dependency.

If it is merged before, instead of polling, the phy would wait for an
interrupt which has not been configured and will never fire.

Tested on the libretech-cc and khadas VIM.

Cheers
Jerome

https://lkml.kernel.org/r/20171218094446.31912-7-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org

 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 4a316a11a00e..8bc404508a4f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -631,6 +631,7 @@
 
 			internal_phy: ethernet-phy@8 {
 				compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22";
+				interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
 				reg = <8>;
 				max-speed = <100>;
 			};
-- 
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2017-12-18 10:27 ` Jerome Brunet
  0 siblings, 0 replies; 7+ messages in thread
From: Jerome Brunet @ 2017-12-18 10:27 UTC (permalink / raw)
  To: linux-arm-kernel

Add the interrupt of the internal ethernet PHY

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Hi Kevin,

This changes depends on the net-next changes adding interrupt support [0].
It is really important that this change is not merged before its
dependency.

If it is merged before, instead of polling, the phy would wait for an
interrupt which has not been configured and will never fire.

Tested on the libretech-cc and khadas VIM.

Cheers
Jerome

https://lkml.kernel.org/r/20171218094446.31912-7-jbrunet at baylibre.com

 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 4a316a11a00e..8bc404508a4f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -631,6 +631,7 @@
 
 			internal_phy: ethernet-phy at 8 {
 				compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22";
+				interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
 				reg = <8>;
 				max-speed = <100>;
 			};
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2017-12-18 10:27 ` Jerome Brunet
  0 siblings, 0 replies; 7+ messages in thread
From: Jerome Brunet @ 2017-12-18 10:27 UTC (permalink / raw)
  To: linus-amlogic

Add the interrupt of the internal ethernet PHY

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Hi Kevin,

This changes depends on the net-next changes adding interrupt support [0].
It is really important that this change is not merged before its
dependency.

If it is merged before, instead of polling, the phy would wait for an
interrupt which has not been configured and will never fire.

Tested on the libretech-cc and khadas VIM.

Cheers
Jerome

https://lkml.kernel.org/r/20171218094446.31912-7-jbrunet at baylibre.com

 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 4a316a11a00e..8bc404508a4f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -631,6 +631,7 @@
 
 			internal_phy: ethernet-phy at 8 {
 				compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22";
+				interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
 				reg = <8>;
 				max-speed = <100>;
 			};
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
  2017-12-18 10:27 ` Jerome Brunet
  (?)
@ 2018-01-06  0:54   ` Kevin Hilman
  -1 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2018-01-06  0:54 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Carlo Caione, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add the interrupt of the internal ethernet PHY
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Hi Kevin,
>
> This changes depends on the net-next changes adding interrupt support [0].
> It is really important that this change is not merged before its
> dependency.
>
> If it is merged before, instead of polling, the phy would wait for an
> interrupt which has not been configured and will never fire.

Thanks for the warning. I'll wait and merge these after -rc1 to be sure
of all dependencies.

Kevin

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2018-01-06  0:54   ` Kevin Hilman
  0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2018-01-06  0:54 UTC (permalink / raw)
  To: linux-arm-kernel

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add the interrupt of the internal ethernet PHY
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Hi Kevin,
>
> This changes depends on the net-next changes adding interrupt support [0].
> It is really important that this change is not merged before its
> dependency.
>
> If it is merged before, instead of polling, the phy would wait for an
> interrupt which has not been configured and will never fire.

Thanks for the warning. I'll wait and merge these after -rc1 to be sure
of all dependencies.

Kevin

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2018-01-06  0:54   ` Kevin Hilman
  0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2018-01-06  0:54 UTC (permalink / raw)
  To: linus-amlogic

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add the interrupt of the internal ethernet PHY
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Hi Kevin,
>
> This changes depends on the net-next changes adding interrupt support [0].
> It is really important that this change is not merged before its
> dependency.
>
> If it is merged before, instead of polling, the phy would wait for an
> interrupt which has not been configured and will never fire.

Thanks for the warning. I'll wait and merge these after -rc1 to be sure
of all dependencies.

Kevin

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-06  0:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-18 10:27 [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq Jerome Brunet
2017-12-18 10:27 ` Jerome Brunet
2017-12-18 10:27 ` Jerome Brunet
2017-12-18 10:27 ` Jerome Brunet
2018-01-06  0:54 ` Kevin Hilman
2018-01-06  0:54   ` Kevin Hilman
2018-01-06  0:54   ` Kevin Hilman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.