* [PATCH] mtd: mtdswap: make array 'name' static const, shrinks object size
@ 2017-11-28 18:59 Colin King
2017-12-18 16:21 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-28 18:59 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-mtd
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the read-only array 'name' on the stack but instead
make it static and constify it. Makes the object code smaller by 35
bytes:
Before:
text data bss dec hex filename
26304 4444 352 31100 797c drivers/mtd/mtdswap.o
After:
text data bss dec hex filename
26205 4508 352 31065 7959 drivers/mtd/mtdswap.o
(gcc version 7.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/mtdswap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
index f07492c6f4b2..7eb0e1f4f980 100644
--- a/drivers/mtd/mtdswap.c
+++ b/drivers/mtd/mtdswap.c
@@ -1223,8 +1223,9 @@ static int mtdswap_show(struct seq_file *s, void *data)
unsigned int max[MTDSWAP_TREE_CNT];
unsigned int i, cw = 0, cwp = 0, cwecount = 0, bb_cnt, mapped, pages;
uint64_t use_size;
- char *name[] = {"clean", "used", "low", "high", "dirty", "bitflip",
- "failing"};
+ static const char * const name[] = {
+ "clean", "used", "low", "high", "dirty", "bitflip", "failing"
+ };
mutex_lock(&d->mbd_dev->lock);
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: mtdswap: make array 'name' static const, shrinks object size
2017-11-28 18:59 [PATCH] mtd: mtdswap: make array 'name' static const, shrinks object size Colin King
@ 2017-12-18 16:21 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-12-18 16:21 UTC (permalink / raw)
To: Colin King
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
Cyrille Pitchen, linux-mtd, kernel-janitors, linux-kernel
On Tue, 28 Nov 2017 18:59:46 +0000
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the read-only array 'name' on the stack but instead
> make it static and constify it. Makes the object code smaller by 35
> bytes:
>
> Before:
> text data bss dec hex filename
> 26304 4444 352 31100 797c drivers/mtd/mtdswap.o
>
> After:
> text data bss dec hex filename
> 26205 4508 352 31065 7959 drivers/mtd/mtdswap.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Boris
> ---
> drivers/mtd/mtdswap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
> index f07492c6f4b2..7eb0e1f4f980 100644
> --- a/drivers/mtd/mtdswap.c
> +++ b/drivers/mtd/mtdswap.c
> @@ -1223,8 +1223,9 @@ static int mtdswap_show(struct seq_file *s, void *data)
> unsigned int max[MTDSWAP_TREE_CNT];
> unsigned int i, cw = 0, cwp = 0, cwecount = 0, bb_cnt, mapped, pages;
> uint64_t use_size;
> - char *name[] = {"clean", "used", "low", "high", "dirty", "bitflip",
> - "failing"};
> + static const char * const name[] = {
> + "clean", "used", "low", "high", "dirty", "bitflip", "failing"
> + };
>
> mutex_lock(&d->mbd_dev->lock);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: mtdswap: make array 'name' static const, shrinks object size
@ 2017-12-18 16:21 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-12-18 16:21 UTC (permalink / raw)
To: Colin King
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
Cyrille Pitchen, linux-mtd, kernel-janitors, linux-kernel
On Tue, 28 Nov 2017 18:59:46 +0000
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the read-only array 'name' on the stack but instead
> make it static and constify it. Makes the object code smaller by 35
> bytes:
>
> Before:
> text data bss dec hex filename
> 26304 4444 352 31100 797c drivers/mtd/mtdswap.o
>
> After:
> text data bss dec hex filename
> 26205 4508 352 31065 7959 drivers/mtd/mtdswap.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Boris
> ---
> drivers/mtd/mtdswap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
> index f07492c6f4b2..7eb0e1f4f980 100644
> --- a/drivers/mtd/mtdswap.c
> +++ b/drivers/mtd/mtdswap.c
> @@ -1223,8 +1223,9 @@ static int mtdswap_show(struct seq_file *s, void *data)
> unsigned int max[MTDSWAP_TREE_CNT];
> unsigned int i, cw = 0, cwp = 0, cwecount = 0, bb_cnt, mapped, pages;
> uint64_t use_size;
> - char *name[] = {"clean", "used", "low", "high", "dirty", "bitflip",
> - "failing"};
> + static const char * const name[] = {
> + "clean", "used", "low", "high", "dirty", "bitflip", "failing"
> + };
>
> mutex_lock(&d->mbd_dev->lock);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-18 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 18:59 [PATCH] mtd: mtdswap: make array 'name' static const, shrinks object size Colin King
2017-12-18 16:21 ` Boris Brezillon
2017-12-18 16:21 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.