* [nf-next:for-net-next3 28/40] net/netfilter/core.c:403:6: sparse: symbol '__nf_unregister_net_hook' was not declared. Should it be static?
@ 2017-12-19 17:25 kbuild test robot
2017-12-19 17:25 ` [RFC PATCH nf-next] netfilter: core: __nf_unregister_net_hook() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-19 17:25 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: kbuild-all, netfilter-devel, coreteam
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git for-net-next3
head: dfbb1c16489ca1b93e3f8aebc74d9229f1d87cc6
commit: ac119d8cd0892526ea8c6c7ed30dce0ea75b1b03 [28/40] netfilter: core: support for NFPROTO_INET hook registration
reproduce:
# apt-get install sparse
git checkout ac119d8cd0892526ea8c6c7ed30dce0ea75b1b03
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH nf-next] netfilter: core: __nf_unregister_net_hook() can be static
2017-12-19 17:25 [nf-next:for-net-next3 28/40] net/netfilter/core.c:403:6: sparse: symbol '__nf_unregister_net_hook' was not declared. Should it be static? kbuild test robot
@ 2017-12-19 17:25 ` kbuild test robot
2017-12-20 23:18 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-19 17:25 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: kbuild-all, netfilter-devel, coreteam
Fixes: ac119d8cd089 ("netfilter: core: support for NFPROTO_INET hook registration")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index 606efc9..9ace162 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -400,8 +400,8 @@ static void nf_remove_net_hook(struct nf_hook_entries *old,
}
}
-void __nf_unregister_net_hook(struct net *net, int pf,
- const struct nf_hook_ops *reg)
+static void __nf_unregister_net_hook(struct net *net, int pf,
+ const struct nf_hook_ops *reg)
{
struct nf_hook_entries __rcu **pp;
struct nf_hook_entries *p;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH nf-next] netfilter: core: __nf_unregister_net_hook() can be static
2017-12-19 17:25 ` [RFC PATCH nf-next] netfilter: core: __nf_unregister_net_hook() can be static kbuild test robot
@ 2017-12-20 23:18 ` Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2017-12-20 23:18 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, netfilter-devel, coreteam
On Wed, Dec 20, 2017 at 01:25:40AM +0800, kbuild test robot wrote:
>
> Fixes: ac119d8cd089 ("netfilter: core: support for NFPROTO_INET hook registration")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
I have folded this patch to my patchset, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-20 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 17:25 [nf-next:for-net-next3 28/40] net/netfilter/core.c:403:6: sparse: symbol '__nf_unregister_net_hook' was not declared. Should it be static? kbuild test robot
2017-12-19 17:25 ` [RFC PATCH nf-next] netfilter: core: __nf_unregister_net_hook() can be static kbuild test robot
2017-12-20 23:18 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.