* [PATCH] mesh: meshctl: Make composition-get argument optional
@ 2017-12-19 21:27 sbrown
2017-12-20 8:54 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: sbrown @ 2017-12-19 21:27 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Steve Brown
From: Steve Brown <sbrown@cortland.com>
It can't be both optional and required.
[config: Target = 0100]# composition-get 0
Unable to parse optional command arguments
---
mesh/config-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mesh/config-client.c b/mesh/config-client.c
index fc6b3dc5d..f280441cc 100644
--- a/mesh/config-client.c
+++ b/mesh/config-client.c
@@ -997,7 +997,7 @@ static const struct bt_shell_menu cfg_menu = {
.entries = {
{"target", "<unicast>", cmd_set_node,
"Set target node to configure"},
- {"composition-get", "[<page_num>]", cmd_get_composition,
+ {"composition-get", "[page_num]", cmd_get_composition,
"Get Composition Data"},
{"netkey-add", "<net_idx>", cmd_add_net_key,
"Add network key"},
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mesh: meshctl: Make composition-get argument optional
2017-12-19 21:27 [PATCH] mesh: meshctl: Make composition-get argument optional sbrown
@ 2017-12-20 8:54 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2017-12-20 8:54 UTC (permalink / raw)
To: sbrown; +Cc: linux-bluetooth
Hi Steve,
On Tue, Dec 19, 2017, sbrown@cortland.com wrote:
> It can't be both optional and required.
>
> [config: Target = 0100]# composition-get 0
> Unable to parse optional command arguments
> ---
> mesh/config-client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-20 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 21:27 [PATCH] mesh: meshctl: Make composition-get argument optional sbrown
2017-12-20 8:54 ` Johan Hedberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.