[PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

[PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

[Chris Wilson]

BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD
rins, skip the aliased ring.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_spin_batch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_spin_batch.c b/tests/gem_spin_batch.c
index 896311304..cccba75a7 100644
--- a/tests/gem_spin_batch.c
+++ b/tests/gem_spin_batch.c
@@ -77,7 +77,7 @@ static void spin_on_all_engines(int fd, unsigned int timeout_sec)
 	unsigned engine;
 
 	for_each_engine(fd, engine) {
-		if (engine == 0)
+		if (engine == 0 || engine == I915_EXEC_BSD)
 			continue;
 
 		igt_fork(child, 1) {
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt/gem_spin_batch: Skip overloading aliased BSD engines

[Patchwork]

== Series Details ==

Series: igt/gem_spin_batch: Skip overloading aliased BSD engines
URL   : https://patchwork.freedesktop.org/series/35634/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
851c417b6b7a4ea28af67cfad116c8b7dc1d263e igt/kms_frontbuffer_tracking: Make assert(false) more informative

with latest DRM-Tip kernel build CI_DRM_3557
bb20a81b430c drm-tip: 2017y-12m-20d-17h-50m-55s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713
                dmesg-warn -> PASS       (fi-bdw-gvtdvm) fdo#103938 +1
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103938 https://bugs.freedesktop.org/show_bug.cgi?id=103938
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:433s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:438s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:385s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:498s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:492s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:497s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:485s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:469s
fi-elk-e7500     total:224  pass:163  dwarn:14  dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:261s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:533s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:409s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:416s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:400s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:470s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:426s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:481s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:524s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:527s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:587s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:439s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:532s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:555s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:506s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:518s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:452s
fi-snb-2520m     total:3    pass:2    dwarn:0   dfail:0   fail:0   skip:0  
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:414s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:591s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:613s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_714/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for igt/gem_spin_batch: Skip overloading aliased BSD engines

[Patchwork]

== Series Details ==

Series: igt/gem_spin_batch: Skip overloading aliased BSD engines
URL   : https://patchwork.freedesktop.org/series/35634/
State : success

== Summary ==

Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                fail       -> PASS       (shard-snb) fdo#101623
        Subgroup fbcpsr-modesetfrombusy:
                incomplete -> SKIP       (shard-hsw)
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-snb) fdo#104218

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218

shard-hsw        total:2712 pass:1537 dwarn:1   dfail:0   fail:10  skip:1164 time:9402s
shard-snb        total:2712 pass:1310 dwarn:1   dfail:0   fail:10  skip:1391 time:8091s
Blacklisted hosts:
shard-apl        total:2712 pass:1689 dwarn:1   dfail:0   fail:21  skip:1001 time:13753s
shard-kbl        total:2682 pass:1789 dwarn:1   dfail:0   fail:24  skip:867 time:10850s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_714/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

[Tvrtko Ursulin]

On 20/12/2017 17:56, Chris Wilson wrote:
> BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD
> rins, skip the aliased ring.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/gem_spin_batch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/gem_spin_batch.c b/tests/gem_spin_batch.c
> index 896311304..cccba75a7 100644
> --- a/tests/gem_spin_batch.c
> +++ b/tests/gem_spin_batch.c
> @@ -77,7 +77,7 @@ static void spin_on_all_engines(int fd, unsigned int timeout_sec)
>   	unsigned engine;
>   
>   	for_each_engine(fd, engine) {
> -		if (engine == 0)
> +		if (engine == 0 || engine == I915_EXEC_BSD)

You forget the other annoyance of the VCS selection uAPI where explicit 
flags can only be used on dual-VCS platforms? :) So I think you need to 
skip on engine & I915_EXEC_BSD_RING1, unless I am missing something.

Regards,

Tvrtko

>   			continue;
>   
>   		igt_fork(child, 1) {
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-12-21 10:02:06)
> 
> On 20/12/2017 17:56, Chris Wilson wrote:
> > BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD
> > rins, skip the aliased ring.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   tests/gem_spin_batch.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/gem_spin_batch.c b/tests/gem_spin_batch.c
> > index 896311304..cccba75a7 100644
> > --- a/tests/gem_spin_batch.c
> > +++ b/tests/gem_spin_batch.c
> > @@ -77,7 +77,7 @@ static void spin_on_all_engines(int fd, unsigned int timeout_sec)
> >       unsigned engine;
> >   
> >       for_each_engine(fd, engine) {
> > -             if (engine == 0)
> > +             if (engine == 0 || engine == I915_EXEC_BSD)
> 
> You forget the other annoyance of the VCS selection uAPI where explicit 
> flags can only be used on dual-VCS platforms? :) So I think you need to 
> skip on engine & I915_EXEC_BSD_RING1, unless I am missing something.

No way, the uapi can't be that stupid. It is.

Can we do the s/for_each_engine/for_each_ring/ yet?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

[Tvrtko Ursulin]

On 21/12/2017 10:53, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-12-21 10:02:06)
>>
>> On 20/12/2017 17:56, Chris Wilson wrote:
>>> BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD
>>> rins, skip the aliased ring.
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>    tests/gem_spin_batch.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/gem_spin_batch.c b/tests/gem_spin_batch.c
>>> index 896311304..cccba75a7 100644
>>> --- a/tests/gem_spin_batch.c
>>> +++ b/tests/gem_spin_batch.c
>>> @@ -77,7 +77,7 @@ static void spin_on_all_engines(int fd, unsigned int timeout_sec)
>>>        unsigned engine;
>>>    
>>>        for_each_engine(fd, engine) {
>>> -             if (engine == 0)
>>> +             if (engine == 0 || engine == I915_EXEC_BSD)
>>
>> You forget the other annoyance of the VCS selection uAPI where explicit
>> flags can only be used on dual-VCS platforms? :) So I think you need to
>> skip on engine & I915_EXEC_BSD_RING1, unless I am missing something.
> 
> No way, the uapi can't be that stupid. It is.

Ugh my suggestion was even incorrect. The skipping criteria needs to be 
branched based on HAS_BSD2.

if (HAS_BSD2())
	skip I915_EXEC_BSD
else
	skip I915_EXEC_BSD_RING1

Can I mention again my suggestion of making for_each_engine iterate 
engines, and not uABI flags?

That would solve multiple issues with one big swat. Maybe it would add 
some new ones, like if we miss some ABI testing coverage, but I still 
think exercising engines and exercising ABI is better separated.

> Can we do the s/for_each_engine/for_each_ring/ yet?

Doesn't ring a bell - what is the name change supposed to signal?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-12-21 11:21:23)
> 
> On 21/12/2017 10:53, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2017-12-21 10:02:06)
> >>
> >> On 20/12/2017 17:56, Chris Wilson wrote:
> >>> BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD
> >>> rins, skip the aliased ring.
> >>>
> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> ---
> >>>    tests/gem_spin_batch.c | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/tests/gem_spin_batch.c b/tests/gem_spin_batch.c
> >>> index 896311304..cccba75a7 100644
> >>> --- a/tests/gem_spin_batch.c
> >>> +++ b/tests/gem_spin_batch.c
> >>> @@ -77,7 +77,7 @@ static void spin_on_all_engines(int fd, unsigned int timeout_sec)
> >>>        unsigned engine;
> >>>    
> >>>        for_each_engine(fd, engine) {
> >>> -             if (engine == 0)
> >>> +             if (engine == 0 || engine == I915_EXEC_BSD)
> >>
> >> You forget the other annoyance of the VCS selection uAPI where explicit
> >> flags can only be used on dual-VCS platforms? :) So I think you need to
> >> skip on engine & I915_EXEC_BSD_RING1, unless I am missing something.
> > 
> > No way, the uapi can't be that stupid. It is.
> 
> Ugh my suggestion was even incorrect. The skipping criteria needs to be 
> branched based on HAS_BSD2.
> 
> if (HAS_BSD2())
>         skip I915_EXEC_BSD
> else
>         skip I915_EXEC_BSD_RING1
> 
> Can I mention again my suggestion of making for_each_engine iterate 
> engines, and not uABI flags?
> 
> That would solve multiple issues with one big swat. Maybe it would add 
> some new ones, like if we miss some ABI testing coverage, but I still 
> think exercising engines and exercising ABI is better separated.
> 
> > Can we do the s/for_each_engine/for_each_ring/ yet?
> 
> Doesn't ring a bell - what is the name change supposed to signal?

I care about uABI coverage. As I recall the^Wmy plan was when we have an
interface that allows for explicit engine selection, we use it. But that
means we first need to convert all existing loops over to
for_each_exec_ring(), and then introduce for_each_engine() converting
and adding extra tests as required depending on whether the tests are
exercising the uABI itself or only care about HW internals.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx