From: Johannes Thumshirn <jthumshirn@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
Keith Busch <keith.busch@intel.com>,
Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH V2 6/6] nvme-pci: remove .init_request callback
Date: Thu, 21 Dec 2017 09:36:49 +0100 [thread overview]
Message-ID: <20171221083648.fuk3rvmisllwviph@linux-x5ow.site> (raw)
In-Reply-To: <0fcf3176-7864-8631-e293-2bfa7aacea38@grimberg.me>
On Thu, Dec 21, 2017 at 10:20:45AM +0200, Sagi Grimberg wrote:
> @@ -2470,8 +2465,9 @@ static int nvme_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
> dev = kzalloc_node(sizeof(*dev), GFP_KERNEL, node);
> if (!dev)
> return -ENOMEM;
> - dev->queues = kzalloc_node((num_possible_cpus() + 1) * sizeof(void
> *),
> - GFP_KERNEL, node);
> +
> + alloc_size = (num_possible_cpus() + 1) * sizeof(struct nvme_queue
> *);
> + dev->queues = kzalloc_node(alloc_size, GFP_KERNEL, node);
Nit:
dev->queues = kcalloc_node(num_possible_cpus() + 1,
sizeof(struct nvme_queue *),
node);
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH V2 6/6] nvme-pci: remove .init_request callback
Date: Thu, 21 Dec 2017 09:36:49 +0100 [thread overview]
Message-ID: <20171221083648.fuk3rvmisllwviph@linux-x5ow.site> (raw)
In-Reply-To: <0fcf3176-7864-8631-e293-2bfa7aacea38@grimberg.me>
On Thu, Dec 21, 2017@10:20:45AM +0200, Sagi Grimberg wrote:
> @@ -2470,8 +2465,9 @@ static int nvme_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
> dev = kzalloc_node(sizeof(*dev), GFP_KERNEL, node);
> if (!dev)
> return -ENOMEM;
> - dev->queues = kzalloc_node((num_possible_cpus() + 1) * sizeof(void
> *),
> - GFP_KERNEL, node);
> +
> + alloc_size = (num_possible_cpus() + 1) * sizeof(struct nvme_queue
> *);
> + dev->queues = kzalloc_node(alloc_size, GFP_KERNEL, node);
Nit:
dev->queues = kcalloc_node(num_possible_cpus() + 1,
sizeof(struct nvme_queue *),
node);
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-12-21 8:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 2:30 [PATCH V2 0/6] blk-mq: fix race related with device deletion/reset/switching sched Ming Lei
2017-12-14 2:30 ` Ming Lei
2017-12-14 2:30 ` [PATCH V2 1/6] blk-mq: quiesce queue before freeing queue Ming Lei
2017-12-14 2:30 ` Ming Lei
2017-12-29 9:54 ` Christoph Hellwig
2017-12-29 9:54 ` Christoph Hellwig
2017-12-14 2:30 ` [PATCH V2 2/6] blk-mq: support concurrent blk_mq_quiesce_queue() Ming Lei
2017-12-14 2:30 ` Ming Lei
2017-12-29 9:58 ` Christoph Hellwig
2017-12-29 9:58 ` Christoph Hellwig
2018-01-02 3:01 ` Ming Lei
2018-01-02 3:01 ` Ming Lei
2017-12-14 2:31 ` [PATCH V2 3/6] blk-mq: quiesce queue during switching io sched and updating nr_requests Ming Lei
2017-12-14 2:31 ` Ming Lei
2017-12-29 9:58 ` Christoph Hellwig
2017-12-29 9:58 ` Christoph Hellwig
2017-12-14 2:31 ` [PATCH V2 4/6] blk-mq: avoid to map CPU into stale hw queue Ming Lei
2017-12-14 2:31 ` Ming Lei
2017-12-29 9:59 ` Christoph Hellwig
2017-12-29 9:59 ` Christoph Hellwig
2017-12-14 2:31 ` [PATCH V2 5/6] blk-mq: fix race between updating nr_hw_queues and switching io sched Ming Lei
2017-12-14 2:31 ` Ming Lei
2017-12-29 9:59 ` Christoph Hellwig
2017-12-29 9:59 ` Christoph Hellwig
2017-12-14 2:31 ` [PATCH V2 6/6] nvme-pci: remove .init_request callback Ming Lei
2017-12-14 2:31 ` Ming Lei
2017-12-21 8:20 ` Sagi Grimberg
2017-12-21 8:20 ` Sagi Grimberg
2017-12-21 8:36 ` Johannes Thumshirn [this message]
2017-12-21 8:36 ` Johannes Thumshirn
2017-12-22 1:34 ` Ming Lei
2017-12-22 1:34 ` Ming Lei
2017-12-24 8:50 ` Sagi Grimberg
2017-12-24 8:50 ` Sagi Grimberg
2017-12-19 15:30 ` [PATCH V2 0/6] blk-mq: fix race related with device deletion/reset/switching sched Yi Zhang
2017-12-19 15:30 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221083648.fuk3rvmisllwviph@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.