[U-Boot] [PATCH 00/11] sunxi: arm64 binary size fixes

[U-Boot] [PATCH 00/11] sunxi: arm64 binary size fixes

[Maxime Ripard]

Hi,

As we discussed already, this is the list of options that we will need
to disable by default.

I also added to the mix a size check, which even though it's not
really optimal, is temporary and will be removed in a future (and
hopefully close) release.

Tom, is this still something we can merge for 2018.01?

Thanks!
Maxime

Andre Heider (1):
  sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

Maxime Ripard (10):
  cmd: crc32: Disable by default on sunXi
  cmd: unzip: Disable by default on sunXi
  cmd: loadb: Disable by default on sunXi
  cmd: loads: Disable by default on sunXi
  cmd: misc: Disable by default on sunXi
  video: bpp8: Disable by default on sunXi
  video: bpp16: Disable by default on sunXi
  net: regex: Disable by default on sunXi
  Makefile: Add size check to the u-boot.itb make target
  sunxi: Add limit with the MMC environment

 Makefile                       |  1 +
 arch/arm/Kconfig               |  1 +
 cmd/Kconfig                    |  5 +++++
 configs/CHIP_defconfig         |  1 -
 configs/CHIP_pro_defconfig     |  1 -
 drivers/video/Kconfig          |  2 ++
 include/configs/sunxi-common.h | 10 ++++++++++
 lib/Kconfig                    |  1 +
 8 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.14.3

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index c0332235261f..7751001819d0 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -397,6 +397,7 @@ menu "Memory commands"
 config CMD_CRC32
 	bool "crc32"
 	select HASH
+	default n if ARCH_SUNXI
 	default y
 	help
 	  Compute CRC32.
-- 
2.14.3

[U-Boot] [PATCH 02/11] cmd: unzip: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 7751001819d0..88188938045f 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -539,6 +539,7 @@ config CMD_LZMADEC
 
 config CMD_UNZIP
 	bool "unzip"
+	default n if ARCH_SUNXI
 	default y if CMD_BOOTI
 	help
 	  Uncompress a zip-compressed memory region.
-- 
2.14.3

[U-Boot] [PATCH 03/11] cmd: loadb: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 88188938045f..36a1b9b784a6 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -748,6 +748,7 @@ config CMD_I2C
 
 config CMD_LOADB
 	bool "loadb"
+	default n if ARCH_SUNXI
 	default y
 	help
 	  Load a binary file over serial line.
-- 
2.14.3

[U-Boot] [PATCH 04/11] cmd: loads: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 36a1b9b784a6..098fbe6fc90a 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -755,6 +755,7 @@ config CMD_LOADB
 
 config CMD_LOADS
 	bool "loads"
+	default n if ARCH_SUNXI
 	default y
 	help
 	  Load an S-Record file over serial line
-- 
2.14.3

[U-Boot] [PATCH 05/11] cmd: misc: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 098fbe6fc90a..ca6d3956bd10 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1130,6 +1130,7 @@ config CMD_GETTIME
 # TODO: rename to CMD_SLEEP
 config CMD_MISC
 	bool "sleep"
+	default n if ARCH_SUNXI
 	default y
 	help
 	  Delay execution for some time
-- 
2.14.3

[U-Boot] [PATCH 06/11] video: bpp8: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/video/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 45a105db06ae..a267c9acfecb 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -38,6 +38,7 @@ config BACKLIGHT_GPIO
 config VIDEO_BPP8
 	bool "Support 8-bit-per-pixel displays"
 	depends on DM_VIDEO
+	default n if ARCH_SUNXI
 	default y if DM_VIDEO
 	help
 	  Support drawing text and bitmaps onto a 8-bit-per-pixel display.
-- 
2.14.3

[U-Boot] [PATCH 07/11] video: bpp16: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/video/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index a267c9acfecb..2fc0defcd0d1 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -49,6 +49,7 @@ config VIDEO_BPP8
 config VIDEO_BPP16
 	bool "Support 16-bit-per-pixel displays"
 	depends on DM_VIDEO
+	default n if ARCH_SUNXI
 	default y if DM_VIDEO
 	help
 	  Support drawing text and bitmaps onto a 16-bit-per-pixel display.
-- 
2.14.3

[U-Boot] [PATCH 08/11] net: regex: Disable by default on sunXi

[Maxime Ripard]

The sunXi arm64 build has overflown, leading to the main U-boot binary
overwriting the environment when flashing the new image, or even worse,
overwriting itself when we're calling saveenv.

Disable this command that is not critical until we can adress the issue
properly.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 lib/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Kconfig b/lib/Kconfig
index f447c53bdeff..8a17a9afe10b 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -47,6 +47,7 @@ config USE_TINY_PRINTF
 
 config REGEX
 	bool "Enable regular expression support"
+	default n if ARCH_SUNXI
 	default y if NET
 	help
 	  If this variable is defined, U-Boot is linked against the
-- 
2.14.3

[U-Boot] [PATCH 09/11] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

[Maxime Ripard]

From: Andre Heider <a.heider@gmail.com>

fdt overlay support is useful for all sunxi boards, enable per default
and remove it from sunxi defconfigs.

Signed-off-by: Andre Heider <a.heider@gmail.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 arch/arm/Kconfig           | 1 +
 configs/CHIP_defconfig     | 1 -
 configs/CHIP_pro_defconfig | 1 -
 3 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index f2c35e32c649..918424a82ac2 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -715,6 +715,7 @@ config ARCH_SUNXI
 	select USE_TINY_PRINTF
 	imply CMD_GPT
 	imply FAT_WRITE
+	imply OF_LIBFDT_OVERLAY
 	imply PRE_CONSOLE_BUFFER
 	imply SPL_GPIO_SUPPORT
 	imply SPL_LIBCOMMON_SUPPORT
diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig
index 062ac76e6d66..2452d42a873c 100644
--- a/configs/CHIP_defconfig
+++ b/configs/CHIP_defconfig
@@ -20,4 +20,3 @@ CONFIG_AXP_ALDO4_VOLT=3300
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-CONFIG_OF_LIBFDT_OVERLAY=y
diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig
index f47aead6f904..02e79b5bb510 100644
--- a/configs/CHIP_pro_defconfig
+++ b/configs/CHIP_pro_defconfig
@@ -25,4 +25,3 @@ CONFIG_AXP_ALDO4_VOLT=3300
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-CONFIG_OF_LIBFDT_OVERLAY=y
-- 
2.14.3

[U-Boot] [PATCH 10/11] Makefile: Add size check to the u-boot.itb make target

[Maxime Ripard]

The make macro to check if the binary exceeds the board size limit is not
called. Make sure that is the case.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index c573ddba95ff..dd26795bb1f3 100644
--- a/Makefile
+++ b/Makefile
@@ -1022,6 +1022,7 @@ u-boot-dtb.img u-boot.img u-boot.kwb u-boot.pbl u-boot-ivt.img: \
 
 u-boot.itb: u-boot-nodtb.bin dts/dt.dtb $(U_BOOT_ITS) FORCE
 	$(call if_changed,mkfitimage)
+	$(BOARD_SIZE_CHECK)
 
 u-boot-spl.kwb: u-boot.img spl/u-boot-spl.bin FORCE
 	$(call if_changed,mkimage)
-- 
2.14.3

[U-Boot] [PATCH 11/11] sunxi: Add limit with the MMC environment

[Maxime Ripard]

The MMC environment offset is getting very close to the end of the U-Boot
binary now. Since we want to make sure this will not overflow, add a size
limit in the board for arm64. arm32 has already that limit enforced in our
custom image generation.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 include/configs/sunxi-common.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 3855c564f914..6236e129a89d 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -147,6 +147,16 @@
 #endif
 
 #if defined(CONFIG_ENV_IS_IN_MMC)
+
+#ifdef CONFIG_ARM64
+/*
+ * This is actually (CONFIG_ENV_OFFSET -
+ * (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512)), but the value will be used
+ * directly in a makefile, without the preprocessor expansion.
+ */
+#define CONFIG_BOARD_SIZE_LIMIT		0x7e000
+#endif
+
 #if CONFIG_MMC_SUNXI_SLOT_EXTRA != -1
 /* If we have two devices (most likely eMMC + MMC), favour the eMMC */
 #define CONFIG_SYS_MMC_ENV_DEV		1
-- 
2.14.3

[U-Boot] [PATCH 00/11] sunxi: arm64 binary size fixes

[Tom Rini]

On Thu, Dec 21, 2017 at 01:40:19PM +0100, Maxime Ripard wrote:

> Hi,
> 
> As we discussed already, this is the list of options that we will need
> to disable by default.
> 
> I also added to the mix a size check, which even though it's not
> really optimal, is temporary and will be removed in a future (and
> hopefully close) release.
> 
> Tom, is this still something we can merge for 2018.01?

Everything looks reasonable, and we need to fix this, so yes, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171221/5dc888e4/attachment.sig>

[U-Boot] [PATCH 06/11] video: bpp8: Disable by default on sunXi

[Andre Przywara]

Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Actually that is useful for sunxi in any case, since we hardcode
VIDEO_BPP32 in sunxi_de2.c.

Cheers,
Andre.

> ---
>  drivers/video/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 45a105db06ae..a267c9acfecb 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -38,6 +38,7 @@ config BACKLIGHT_GPIO
>  config VIDEO_BPP8
>  	bool "Support 8-bit-per-pixel displays"
>  	depends on DM_VIDEO
> +	default n if ARCH_SUNXI
>  	default y if DM_VIDEO
>  	help
>  	  Support drawing text and bitmaps onto a 8-bit-per-pixel display.


> 

[U-Boot] [PATCH 07/11] video: bpp16: Disable by default on sunXi

[Andre Przywara]

Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Same comment as the other patch: we only support VIDEO_BPP32 for sunxi.

Cheers,
Andre.

> ---
>  drivers/video/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index a267c9acfecb..2fc0defcd0d1 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -49,6 +49,7 @@ config VIDEO_BPP8
>  config VIDEO_BPP16
>  	bool "Support 16-bit-per-pixel displays"
>  	depends on DM_VIDEO
> +	default n if ARCH_SUNXI
>  	default y if DM_VIDEO
>  	help
>  	  Support drawing text and bitmaps onto a 16-bit-per-pixel display.
> 

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Andre Przywara]

Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index c0332235261f..7751001819d0 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -397,6 +397,7 @@ menu "Memory commands"
>  config CMD_CRC32
>  	bool "crc32"
>  	select HASH
> +	default n if ARCH_SUNXI

Is that meant to solve issues with 32 bit boards as well? Or shall we
use "ARCH_SUNXI && ARM64" here?

In case including 32-bit is intentional, this is:

for [PATCH 01/11] - [PATCH 04/11]:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>

If no one shoot any of those options down, you might want to squash them
into one patch, since they all go into the same file.
Unless you need to meet some company patch count target before the end
of the year :-D

Cheers,
Andre.

P.S. Shall we mark those patches somehow, so that we can easily revert
them later? Those commands can be useful.

Cheers,
Andre

>  	default y
>  	help
>  	  Compute CRC32.
> 

[U-Boot] [PATCH 05/11] cmd: misc: Disable by default on sunXi

[Andre Przywara]

Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Are there any scripts relying on "sleep"? For some kind of fabricated
timeout, maybe? But I guess users would enable them in that case, so:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre.

> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 098fbe6fc90a..ca6d3956bd10 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1130,6 +1130,7 @@ config CMD_GETTIME
>  # TODO: rename to CMD_SLEEP
>  config CMD_MISC
>  	bool "sleep"
> +	default n if ARCH_SUNXI
>  	default y
>  	help
>  	  Delay execution for some time
> 

[U-Boot] [PATCH 06/11] video: bpp8: Disable by default on sunXi

[Anatolij Gustschin]

On Thu, 21 Dec 2017 13:40:25 +0100
Maxime Ripard maxime.ripard at free-electrons.com wrote:

> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

[U-Boot] [PATCH 08/11] net: regex: Disable by default on sunXi

[Andre Przywara]

Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.

Nit: this not a command.

> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre.

> ---
>  lib/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index f447c53bdeff..8a17a9afe10b 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -47,6 +47,7 @@ config USE_TINY_PRINTF
>  
>  config REGEX
>  	bool "Enable regular expression support"
> +	default n if ARCH_SUNXI
>  	default y if NET
>  	help
>  	  If this variable is defined, U-Boot is linked against the
> 

[U-Boot] [PATCH 07/11] video: bpp16: Disable by default on sunXi

[Anatolij Gustschin]

On Thu, 21 Dec 2017 13:40:26 +0100
Maxime Ripard maxime.ripard at free-electrons.com wrote:

> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

[U-Boot] [PATCH 11/11] sunxi: Add limit with the MMC environment

[André Przywara]

Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The MMC environment offset is getting very close to the end of the U-Boot
> binary now. Since we want to make sure this will not overflow, add a size
> limit in the board for arm64. arm32 has already that limit enforced in our
> custom image generation.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  include/configs/sunxi-common.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> index 3855c564f914..6236e129a89d 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -147,6 +147,16 @@
>  #endif
>  
>  #if defined(CONFIG_ENV_IS_IN_MMC)
> +
> +#ifdef CONFIG_ARM64

Why is that? Isn't the limit applicable to all sunxi boards using MMC
env? Maybe that's actually the better check (thanks for digging this up,
btw)? I guess this would avoid to break compatibility with older
sunxi-fel versions (those provided by distros not carrying your fix),
also avoids blowing up u-boot-sunxi-with-spl.bin to 504K always?

Or does this break anything on 32-bit boards?

Cheers,
Andre.

> +/*
> + * This is actually (CONFIG_ENV_OFFSET -
> + * (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512)), but the value will be used
> + * directly in a makefile, without the preprocessor expansion.
> + */
> +#define CONFIG_BOARD_SIZE_LIMIT		0x7e000
> +#endif
> +
>  #if CONFIG_MMC_SUNXI_SLOT_EXTRA != -1
>  /* If we have two devices (most likely eMMC + MMC), favour the eMMC */
>  #define CONFIG_SYS_MMC_ENV_DEV		1
> 

[U-Boot] [PATCH 11/11] sunxi: Add limit with the MMC environment

[Maxime Ripard]

On Thu, Dec 21, 2017 at 10:52:04PM +0000, André Przywara wrote:
> Hi,
> 
> On 21/12/17 12:40, Maxime Ripard wrote:
> > The MMC environment offset is getting very close to the end of the U-Boot
> > binary now. Since we want to make sure this will not overflow, add a size
> > limit in the board for arm64. arm32 has already that limit enforced in our
> > custom image generation.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  include/configs/sunxi-common.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> > index 3855c564f914..6236e129a89d 100644
> > --- a/include/configs/sunxi-common.h
> > +++ b/include/configs/sunxi-common.h
> > @@ -147,6 +147,16 @@
> >  #endif
> >  
> >  #if defined(CONFIG_ENV_IS_IN_MMC)
> > +
> > +#ifdef CONFIG_ARM64
> 
> Why is that? Isn't the limit applicable to all sunxi boards using MMC
> env? Maybe that's actually the better check (thanks for digging this up,
> btw)? I guess this would avoid to break compatibility with older
> sunxi-fel versions (those provided by distros not carrying your fix),
> also avoids blowing up u-boot-sunxi-with-spl.bin to 504K always?
> 
> Or does this break anything on 32-bit boards?

So there's a couple of arguments there, which are probably all a bit
weak, but the sum of them made me do it that way:
  - I tried to keep the changes as minimal as possible since it's
    going to be fixes, in one of the late -rc's. We know that the
    arm32 part works, so I didn't really want to disrupt that.
  - It's not really optimal, as the expression is used directly in the
    Makefile and therefore any arithmetic operations can't really be
    done. The arm32 part can, and is therefore correct in all
    cases. Here we just bet that the user will never have changed one
    of the values.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171222/541f71b6/attachment.sig>

[U-Boot] [PATCH 11/11] sunxi: Add limit with the MMC environment

[Jagan Teki]

On Fri, Dec 22, 2017 at 2:18 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Dec 21, 2017 at 10:52:04PM +0000, André Przywara wrote:
>> Hi,
>>
>> On 21/12/17 12:40, Maxime Ripard wrote:
>> > The MMC environment offset is getting very close to the end of the U-Boot
>> > binary now. Since we want to make sure this will not overflow, add a size
>> > limit in the board for arm64. arm32 has already that limit enforced in our
>> > custom image generation.
>> >
>> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> > ---
>> >  include/configs/sunxi-common.h | 10 ++++++++++
>> >  1 file changed, 10 insertions(+)
>> >
>> > diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
>> > index 3855c564f914..6236e129a89d 100644
>> > --- a/include/configs/sunxi-common.h
>> > +++ b/include/configs/sunxi-common.h
>> > @@ -147,6 +147,16 @@
>> >  #endif
>> >
>> >  #if defined(CONFIG_ENV_IS_IN_MMC)
>> > +
>> > +#ifdef CONFIG_ARM64
>>
>> Why is that? Isn't the limit applicable to all sunxi boards using MMC
>> env? Maybe that's actually the better check (thanks for digging this up,
>> btw)? I guess this would avoid to break compatibility with older
>> sunxi-fel versions (those provided by distros not carrying your fix),
>> also avoids blowing up u-boot-sunxi-with-spl.bin to 504K always?
>>
>> Or does this break anything on 32-bit boards?
>
> So there's a couple of arguments there, which are probably all a bit
> weak, but the sum of them made me do it that way:
>   - I tried to keep the changes as minimal as possible since it's
>     going to be fixes, in one of the late -rc's. We know that the
>     arm32 part works, so I didn't really want to disrupt that.
>   - It's not really optimal, as the expression is used directly in the
>     Makefile and therefore any arithmetic operations can't really be
>     done. The arm32 part can, and is therefore correct in all
>     cases. Here we just bet that the user will never have changed one
>     of the values.

Based on the previous conversion, 2018.05 or future version will
increase the u-boot partition size. Do we really need this in between
which will anyway removed.

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 8:20 PM, Andre Przywara <andre.przywara@arm.com> wrote:
> Hi,
>
> On 21/12/17 12:40, Maxime Ripard wrote:
>> The sunXi arm64 build has overflown, leading to the main U-boot binary
>> overwriting the environment when flashing the new image, or even worse,
>> overwriting itself when we're calling saveenv.
>>
>> Disable this command that is not critical until we can adress the issue
>> properly.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>>  cmd/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index c0332235261f..7751001819d0 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -397,6 +397,7 @@ menu "Memory commands"
>>  config CMD_CRC32
>>       bool "crc32"
>>       select HASH
>> +     default n if ARCH_SUNXI
>
> Is that meant to solve issues with 32 bit boards as well? Or shall we
> use "ARCH_SUNXI && ARM64" here?

Agreed this, and If we go further better to have A64 and H5 check directly.

[U-Boot] [PATCH 00/11] sunxi: arm64 binary size fixes

[Jagan Teki]

Maxime,

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> As we discussed already, this is the list of options that we will need
> to disable by default.
>
> I also added to the mix a size check, which even though it's not
> really optimal, is temporary and will be removed in a future (and
> hopefully close) release.
>
> Tom, is this still something we can merge for 2018.01?
>
> Thanks!
> Maxime
>
> Andre Heider (1):
>   sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
>
> Maxime Ripard (10):
>   cmd: crc32: Disable by default on sunXi
>   cmd: unzip: Disable by default on sunXi
>   cmd: loadb: Disable by default on sunXi
>   cmd: loads: Disable by default on sunXi
>   cmd: misc: Disable by default on sunXi
>   video: bpp8: Disable by default on sunXi
>   video: bpp16: Disable by default on sunXi
>   net: regex: Disable by default on sunXi
>   Makefile: Add size check to the u-boot.itb make target
>   sunxi: Add limit with the MMC environment

based on the conversation on individual patches, I think all these
need to change only for 64-bit sunxi boards for now and we can push
this for the release if all fine.

[U-Boot] [PATCH 11/11] sunxi: Add limit with the MMC environment

[Maxime Ripard]

On Fri, Dec 22, 2017 at 02:34:35PM +0530, Jagan Teki wrote:
> On Fri, Dec 22, 2017 at 2:18 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Thu, Dec 21, 2017 at 10:52:04PM +0000, André Przywara wrote:
> >> Hi,
> >>
> >> On 21/12/17 12:40, Maxime Ripard wrote:
> >> > The MMC environment offset is getting very close to the end of the U-Boot
> >> > binary now. Since we want to make sure this will not overflow, add a size
> >> > limit in the board for arm64. arm32 has already that limit enforced in our
> >> > custom image generation.
> >> >
> >> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> > ---
> >> >  include/configs/sunxi-common.h | 10 ++++++++++
> >> >  1 file changed, 10 insertions(+)
> >> >
> >> > diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> >> > index 3855c564f914..6236e129a89d 100644
> >> > --- a/include/configs/sunxi-common.h
> >> > +++ b/include/configs/sunxi-common.h
> >> > @@ -147,6 +147,16 @@
> >> >  #endif
> >> >
> >> >  #if defined(CONFIG_ENV_IS_IN_MMC)
> >> > +
> >> > +#ifdef CONFIG_ARM64
> >>
> >> Why is that? Isn't the limit applicable to all sunxi boards using MMC
> >> env? Maybe that's actually the better check (thanks for digging this up,
> >> btw)? I guess this would avoid to break compatibility with older
> >> sunxi-fel versions (those provided by distros not carrying your fix),
> >> also avoids blowing up u-boot-sunxi-with-spl.bin to 504K always?
> >>
> >> Or does this break anything on 32-bit boards?
> >
> > So there's a couple of arguments there, which are probably all a bit
> > weak, but the sum of them made me do it that way:
> >   - I tried to keep the changes as minimal as possible since it's
> >     going to be fixes, in one of the late -rc's. We know that the
> >     arm32 part works, so I didn't really want to disrupt that.
> >   - It's not really optimal, as the expression is used directly in the
> >     Makefile and therefore any arithmetic operations can't really be
> >     done. The arm32 part can, and is therefore correct in all
> >     cases. Here we just bet that the user will never have changed one
> >     of the values.
> 
> Based on the previous conversion, 2018.05 or future version will
> increase the u-boot partition size. Do we really need this in between
> which will anyway removed.

Yes, otherwise we might end up again in a situation where we'll allow
the compilation of a broken binary.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180105/09db40d8/attachment.sig>

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Maxime Ripard]

Hi Andre,

On Thu, Dec 21, 2017 at 02:50:29PM +0000, Andre Przywara wrote:
> Hi,
> 
> On 21/12/17 12:40, Maxime Ripard wrote:
> > The sunXi arm64 build has overflown, leading to the main U-boot binary
> > overwriting the environment when flashing the new image, or even worse,
> > overwriting itself when we're calling saveenv.
> > 
> > Disable this command that is not critical until we can adress the issue
> > properly.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  cmd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index c0332235261f..7751001819d0 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -397,6 +397,7 @@ menu "Memory commands"
> >  config CMD_CRC32
> >  	bool "crc32"
> >  	select HASH
> > +	default n if ARCH_SUNXI
> 
> Is that meant to solve issues with 32 bit boards as well? Or shall we
> use "ARCH_SUNXI && ARM64" here?
> 
> In case including 32-bit is intentional, this is:
> 
> for [PATCH 01/11] - [PATCH 04/11]:
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

This is intentional. I really want to have an experience as close as
possible on the arm and arm64 boards, and having the same commands set
is one of the things that matter to achieve that :)

> If no one shoot any of those options down, you might want to squash them
> into one patch, since they all go into the same file.

That works for me :)

> Unless you need to meet some company patch count target before the end
> of the year :-D

I guess I missed that deadline already... ;)

> P.S. Shall we mark those patches somehow, so that we can easily revert
> them later? Those commands can be useful.

That might be a good idea. Do you have a suggestion?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180105/b492cb42/attachment.sig>

[U-Boot] [PATCH 00/11] sunxi: arm64 binary size fixes

[Maxime Ripard]

On Thu, Jan 04, 2018 at 10:58:16AM +0530, Jagan Teki wrote:
> Maxime,
> 
> On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > As we discussed already, this is the list of options that we will need
> > to disable by default.
> >
> > I also added to the mix a size check, which even though it's not
> > really optimal, is temporary and will be removed in a future (and
> > hopefully close) release.
> >
> > Tom, is this still something we can merge for 2018.01?
> >
> > Thanks!
> > Maxime
> >
> > Andre Heider (1):
> >   sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
> >
> > Maxime Ripard (10):
> >   cmd: crc32: Disable by default on sunXi
> >   cmd: unzip: Disable by default on sunXi
> >   cmd: loadb: Disable by default on sunXi
> >   cmd: loads: Disable by default on sunXi
> >   cmd: misc: Disable by default on sunXi
> >   video: bpp8: Disable by default on sunXi
> >   video: bpp16: Disable by default on sunXi
> >   net: regex: Disable by default on sunXi
> >   Makefile: Add size check to the u-boot.itb make target
> >   sunxi: Add limit with the MMC environment
> 
> based on the conversation on individual patches, I think all these
> need to change only for 64-bit sunxi boards for now and we can push
> this for the release if all fine.

As far as I'm concerned, these patches can be merged as is.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180105/3bc08119/attachment.sig>

[U-Boot] [PATCH 00/11] sunxi: arm64 binary size fixes

[Jagan Teki]

On Fri, Jan 5, 2018 at 3:30 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Jan 04, 2018 at 10:58:16AM +0530, Jagan Teki wrote:
>> Maxime,
>>
>> On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > Hi,
>> >
>> > As we discussed already, this is the list of options that we will need
>> > to disable by default.
>> >
>> > I also added to the mix a size check, which even though it's not
>> > really optimal, is temporary and will be removed in a future (and
>> > hopefully close) release.
>> >
>> > Tom, is this still something we can merge for 2018.01?
>> >
>> > Thanks!
>> > Maxime
>> >
>> > Andre Heider (1):
>> >   sunxi: imply CONFIG_OF_LIBFDT_OVERLAY
>> >
>> > Maxime Ripard (10):
>> >   cmd: crc32: Disable by default on sunXi
>> >   cmd: unzip: Disable by default on sunXi
>> >   cmd: loadb: Disable by default on sunXi
>> >   cmd: loads: Disable by default on sunXi
>> >   cmd: misc: Disable by default on sunXi
>> >   video: bpp8: Disable by default on sunXi
>> >   video: bpp16: Disable by default on sunXi
>> >   net: regex: Disable by default on sunXi
>> >   Makefile: Add size check to the u-boot.itb make target
>> >   sunxi: Add limit with the MMC environment
>>
>> based on the conversation on individual patches, I think all these
>> need to change only for 64-bit sunxi boards for now and we can push
>> this for the release if all fine.
>
> As far as I'm concerned, these patches can be merged as is.

I've no issues with this series if it goes to next version, since we
have time to validate. But I'm thinking to push these asap to merge
them in coming release in two days, it would be good to untouch 32-bit
stuff at last minute.

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 02/11] cmd: unzip: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 03/11] cmd: loadb: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 04/11] cmd: loads: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 05/11] cmd: misc: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 06/11] video: bpp8: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 9:31 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Thu, 21 Dec 2017 13:40:25 +0100
> Maxime Ripard maxime.ripard at free-electrons.com wrote:
>
>> The sunXi arm64 build has overflown, leading to the main U-boot binary
>> overwriting the environment when flashing the new image, or even worse,
>> overwriting itself when we're calling saveenv.
>>
>> Disable this command that is not critical until we can adress the issue
>> properly.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Reviewed-by: Anatolij Gustschin <agust@denx.de>

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 07/11] video: bpp16: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 9:42 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Thu, 21 Dec 2017 13:40:26 +0100
> Maxime Ripard maxime.ripard at free-electrons.com wrote:
>
>> The sunXi arm64 build has overflown, leading to the main U-boot binary
>> overwriting the environment when flashing the new image, or even worse,
>> overwriting itself when we're calling saveenv.
>>
>> Disable this command that is not critical until we can adress the issue
>> properly.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Reviewed-by: Anatolij Gustschin <agust@denx.de>

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 08/11] net: regex: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 9:35 PM, Andre Przywara <andre.przywara@arm.com> wrote:
> Hi,
>
> On 21/12/17 12:40, Maxime Ripard wrote:
>> The sunXi arm64 build has overflown, leading to the main U-boot binary
>> overwriting the environment when flashing the new image, or even worse,
>> overwriting itself when we're calling saveenv.
>>
>> Disable this command that is not critical until we can adress the issue
>> properly.
>
> Nit: this not a command.
>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Fixed nit

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 09/11] sunxi: imply CONFIG_OF_LIBFDT_OVERLAY

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> From: Andre Heider <a.heider@gmail.com>
>
> fdt overlay support is useful for all sunxi boards, enable per default
> and remove it from sunxi defconfigs.
>
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Applied to u-boot-sunxi/master

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Jagan Teki]

On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
>
> Disable this command that is not critical until we can adress the issue
> properly.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index c0332235261f..7751001819d0 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -397,6 +397,7 @@ menu "Memory commands"
>  config CMD_CRC32
>         bool "crc32"
>         select HASH
> +       default n if ARCH_SUNXI
>         default y
>         help
>           Compute CRC32.

this make unselect HASH so, few of the boards have build issues, we
can select sunxi directly on HASH kconfig.

[1] https://travis-ci.org/openedev/u-boot-sunxi/jobs/327576344

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Tom Rini]

On Thu, Jan 11, 2018 at 11:24:28PM +0530, Jagan Teki wrote:
> On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > The sunXi arm64 build has overflown, leading to the main U-boot binary
> > overwriting the environment when flashing the new image, or even worse,
> > overwriting itself when we're calling saveenv.
> >
> > Disable this command that is not critical until we can adress the issue
> > properly.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  cmd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index c0332235261f..7751001819d0 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -397,6 +397,7 @@ menu "Memory commands"
> >  config CMD_CRC32
> >         bool "crc32"
> >         select HASH
> > +       default n if ARCH_SUNXI
> >         default y
> >         help
> >           Compute CRC32.
> 
> this make unselect HASH so, few of the boards have build issues, we
> can select sunxi directly on HASH kconfig.

OK, hold on.  This series was supposed to be pulled in to v2018.01, to
fix size issues, before we could take the env series that I said can
come in for v2018.03, yes?  So we should just not do this series and
take Maxime's update to the env series which I expect to be posted soon
so I can merge it, and sunxi can move to env in FAT and not have the
problem it has on aarch64 atm.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180111/30b6de9c/attachment.sig>

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Maxime Ripard]

Hi,

On Thu, Jan 11, 2018 at 11:24:28PM +0530, Jagan Teki wrote:
> On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > The sunXi arm64 build has overflown, leading to the main U-boot binary
> > overwriting the environment when flashing the new image, or even worse,
> > overwriting itself when we're calling saveenv.
> >
> > Disable this command that is not critical until we can adress the issue
> > properly.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  cmd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index c0332235261f..7751001819d0 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -397,6 +397,7 @@ menu "Memory commands"
> >  config CMD_CRC32
> >         bool "crc32"
> >         select HASH
> > +       default n if ARCH_SUNXI
> >         default y
> >         help
> >           Compute CRC32.
> 
> this make unselect HASH so, few of the boards have build issues, we
> can select sunxi directly on HASH kconfig.
> 
> [1] https://travis-ci.org/openedev/u-boot-sunxi/jobs/327576344

All the errors on the build 3 (which is the one that failed in your
history) are related to git issues it seems, and not build failures.

Which boards are failing?
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180112/5553d4e2/attachment.sig>

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Maxime Ripard]

On Thu, Jan 11, 2018 at 01:41:41PM -0500, Tom Rini wrote:
> On Thu, Jan 11, 2018 at 11:24:28PM +0530, Jagan Teki wrote:
> > On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
> > <maxime.ripard@free-electrons.com> wrote:
> > > The sunXi arm64 build has overflown, leading to the main U-boot binary
> > > overwriting the environment when flashing the new image, or even worse,
> > > overwriting itself when we're calling saveenv.
> > >
> > > Disable this command that is not critical until we can adress the issue
> > > properly.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > ---
> > >  cmd/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > > index c0332235261f..7751001819d0 100644
> > > --- a/cmd/Kconfig
> > > +++ b/cmd/Kconfig
> > > @@ -397,6 +397,7 @@ menu "Memory commands"
> > >  config CMD_CRC32
> > >         bool "crc32"
> > >         select HASH
> > > +       default n if ARCH_SUNXI
> > >         default y
> > >         help
> > >           Compute CRC32.
> > 
> > this make unselect HASH so, few of the boards have build issues, we
> > can select sunxi directly on HASH kconfig.
> 
> OK, hold on.  This series was supposed to be pulled in to v2018.01, to
> fix size issues, before we could take the env series that I said can
> come in for v2018.03, yes?  So we should just not do this series and
> take Maxime's update to the env series which I expect to be posted soon
> so I can merge it, and sunxi can move to env in FAT and not have the
> problem it has on aarch64 atm.

They are a bit orthogonal actually.

This serie addresses the build failures we have today in order to
still be able to build binaries that work.

The FAT transition is more of a longer-term goal in order to not have
the size restriction we have eventually (hopefully 2018.05).

So the first one mitigates the problem, while the second one allows us
to get rid of the problem entirely in the future.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180112/59716b2b/attachment.sig>

[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Jagan Teki]

On Fri, Jan 12, 2018 at 2:26 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Thu, Jan 11, 2018 at 11:24:28PM +0530, Jagan Teki wrote:
>> On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > The sunXi arm64 build has overflown, leading to the main U-boot binary
>> > overwriting the environment when flashing the new image, or even worse,
>> > overwriting itself when we're calling saveenv.
>> >
>> > Disable this command that is not critical until we can adress the issue
>> > properly.
>> >
>> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> > ---
>> >  cmd/Kconfig | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/cmd/Kconfig b/cmd/Kconfig
>> > index c0332235261f..7751001819d0 100644
>> > --- a/cmd/Kconfig
>> > +++ b/cmd/Kconfig
>> > @@ -397,6 +397,7 @@ menu "Memory commands"
>> >  config CMD_CRC32
>> >         bool "crc32"
>> >         select HASH
>> > +       default n if ARCH_SUNXI
>> >         default y
>> >         help
>> >           Compute CRC32.
>>
>> this make unselect HASH so, few of the boards have build issues, we
>> can select sunxi directly on HASH kconfig.
>>
>> [1] https://travis-ci.org/openedev/u-boot-sunxi/jobs/327576344
>
> All the errors on the build 3 (which is the one that failed in your
> history) are related to git issues it seems, and not build failures.

Not exactly, boards which uses dfu from 5i/7i/8i are failed [2]

[2] https://travis-ci.org/openedev/u-boot-sunxi