* [virtio-dev] [PATCH] virtio-net: Add missing flag define to struct
@ 2017-12-21 14:45 Sameeh Jubran
2017-12-21 16:31 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Sameeh Jubran @ 2017-12-21 14:45 UTC (permalink / raw)
To: virtio-dev
From: sameehj <sameeh.j@gmail.com>
The flag VIRTIO_NET_HDR_F_DATA_VALID is aleady mentioned in the virtio-net
spec however it is not defined in the struct. This flag is already defined
and used in virtio-net device in Qemu as well as some of it's drivers.
---
content.tex | 1 +
1 file changed, 1 insertion(+)
diff --git a/content.tex b/content.tex
index c840588..788d8b5 100644
--- a/content.tex
+++ b/content.tex
@@ -3305,6 +3305,7 @@ itself is preceded by a header:
\begin{lstlisting}
struct virtio_net_hdr {
#define VIRTIO_NET_HDR_F_NEEDS_CSUM 1
+#define VIRTIO_NET_HDR_F_DATA_VALID 2
u8 flags;
#define VIRTIO_NET_HDR_GSO_NONE 0
#define VIRTIO_NET_HDR_GSO_TCPV4 1
--
2.13.6
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [virtio-dev] [PATCH] virtio-net: Add missing flag define to struct
2017-12-21 14:45 [virtio-dev] [PATCH] virtio-net: Add missing flag define to struct Sameeh Jubran
@ 2017-12-21 16:31 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2017-12-21 16:31 UTC (permalink / raw)
To: Sameeh Jubran; +Cc: virtio-dev
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Thu, Dec 21, 2017 at 04:45:04PM +0200, Sameeh Jubran wrote:
> From: sameehj <sameeh.j@gmail.com>
>
> The flag VIRTIO_NET_HDR_F_DATA_VALID is aleady mentioned in the virtio-net
> spec however it is not defined in the struct. This flag is already defined
> and used in virtio-net device in Qemu as well as some of it's drivers.
> ---
> content.tex | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-21 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-21 14:45 [virtio-dev] [PATCH] virtio-net: Add missing flag define to struct Sameeh Jubran
2017-12-21 16:31 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.