From: Petr Mladek <pmladek@suse.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: LKML <linux-kernel@vger.kernel.org>, akpm@linux-foundation.org, linux-mm@kvack.org, Cong Wang <xiyou.wangcong@gmail.com>, Dave Hansen <dave.hansen@intel.com>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Vlastimil Babka <vbabka@suse.cz>, Peter Zijlstra <peterz@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Jan Kara <jack@suse.cz>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, rostedt@rostedt.homelinux.com Subject: Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes Date: Fri, 22 Dec 2017 11:31:31 +0100 [thread overview] Message-ID: <20171222102927.eiunret5ykx55bvq@pathway.suse.cz> (raw) In-Reply-To: <20171108102723.602216b1@gandalf.local.home> On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > [ claws-mail is really pissing me off. It did it again, after I > manually fixed all the addresses. This time, I'm going to do things > slightly different. Sorry for all the spam :-( ] > > From: Steven Rostedt (VMware) <rostedt@goodmis.org> > > This patch implements what I discussed in Kernel Summit. I added > lockdep annotation (hopefully correctly), and it hasn't had any splats > (since I fixed some bugs in the first iterations). It did catch > problems when I had the owner covering too much. But now that the owner > is only set when actively calling the consoles, lockdep has stayed > quiet. > Index: linux-trace.git/kernel/printk/printk.c > =================================================================== > --- linux-trace.git.orig/kernel/printk/printk.c > +++ linux-trace.git/kernel/printk/printk.c > @@ -2141,6 +2196,7 @@ void console_unlock(void) > static u64 seen_seq; > unsigned long flags; > bool wake_klogd = false; > + bool waiter = false; > bool do_cond_resched, retry; > > if (console_suspended) { > @@ -2229,14 +2285,64 @@ skip: > console_seq++; > raw_spin_unlock(&logbuf_lock); > > + /* > + * While actively printing out messages, if another printk() > + * were to occur on another CPU, it may wait for this one to > + * finish. This task can not be preempted if there is a > + * waiter waiting to take over. > + */ > + raw_spin_lock(&console_owner_lock); > + console_owner = current; > + raw_spin_unlock(&console_owner_lock); One idea. We could do the above only when "do_cond_resched" is false. I mean that we could allow stealing the console duty only from atomic context. If I get it correctly, this variable is always true in schedulable context. > + > + /* The waiter may spin on us after setting console_owner */ > + spin_acquire(&console_owner_dep_map, 0, 0, _THIS_IP_); > + > stop_critical_timings(); /* don't trace print latency */ > call_console_drivers(ext_text, ext_len, text, len); > start_critical_timings(); > + > + raw_spin_lock(&console_owner_lock); > + waiter = READ_ONCE(console_waiter); > + console_owner = NULL; > + raw_spin_unlock(&console_owner_lock); > + > + /* > + * If there is a waiter waiting for us, then pass the > + * rest of the work load over to that waiter. > + */ > + if (waiter) > + break; > + > + /* There was no waiter, and nothing will spin on us here */ > + spin_release(&console_owner_dep_map, 1, _THIS_IP_); > + > printk_safe_exit_irqrestore(flags); > > if (do_cond_resched) > cond_resched(); On the contrary, we could allow steeling the console semaphore when sleeping here. It would allow to get the messages out faster. It might help to move the duty to someone who is actually producing many messages or even the panic() caller. Best Regards, Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: LKML <linux-kernel@vger.kernel.org>, akpm@linux-foundation.org, linux-mm@kvack.org, Cong Wang <xiyou.wangcong@gmail.com>, Dave Hansen <dave.hansen@intel.com>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Vlastimil Babka <vbabka@suse.cz>, Peter Zijlstra <peterz@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Jan Kara <jack@suse.cz>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, rostedt@home.goodmis.org Subject: Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes Date: Fri, 22 Dec 2017 11:31:31 +0100 [thread overview] Message-ID: <20171222102927.eiunret5ykx55bvq@pathway.suse.cz> (raw) In-Reply-To: <20171108102723.602216b1@gandalf.local.home> On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > [ claws-mail is really pissing me off. It did it again, after I > manually fixed all the addresses. This time, I'm going to do things > slightly different. Sorry for all the spam :-( ] > > From: Steven Rostedt (VMware) <rostedt@goodmis.org> > > This patch implements what I discussed in Kernel Summit. I added > lockdep annotation (hopefully correctly), and it hasn't had any splats > (since I fixed some bugs in the first iterations). It did catch > problems when I had the owner covering too much. But now that the owner > is only set when actively calling the consoles, lockdep has stayed > quiet. > Index: linux-trace.git/kernel/printk/printk.c > =================================================================== > --- linux-trace.git.orig/kernel/printk/printk.c > +++ linux-trace.git/kernel/printk/printk.c > @@ -2141,6 +2196,7 @@ void console_unlock(void) > static u64 seen_seq; > unsigned long flags; > bool wake_klogd = false; > + bool waiter = false; > bool do_cond_resched, retry; > > if (console_suspended) { > @@ -2229,14 +2285,64 @@ skip: > console_seq++; > raw_spin_unlock(&logbuf_lock); > > + /* > + * While actively printing out messages, if another printk() > + * were to occur on another CPU, it may wait for this one to > + * finish. This task can not be preempted if there is a > + * waiter waiting to take over. > + */ > + raw_spin_lock(&console_owner_lock); > + console_owner = current; > + raw_spin_unlock(&console_owner_lock); One idea. We could do the above only when "do_cond_resched" is false. I mean that we could allow stealing the console duty only from atomic context. If I get it correctly, this variable is always true in schedulable context. > + > + /* The waiter may spin on us after setting console_owner */ > + spin_acquire(&console_owner_dep_map, 0, 0, _THIS_IP_); > + > stop_critical_timings(); /* don't trace print latency */ > call_console_drivers(ext_text, ext_len, text, len); > start_critical_timings(); > + > + raw_spin_lock(&console_owner_lock); > + waiter = READ_ONCE(console_waiter); > + console_owner = NULL; > + raw_spin_unlock(&console_owner_lock); > + > + /* > + * If there is a waiter waiting for us, then pass the > + * rest of the work load over to that waiter. > + */ > + if (waiter) > + break; > + > + /* There was no waiter, and nothing will spin on us here */ > + spin_release(&console_owner_dep_map, 1, _THIS_IP_); > + > printk_safe_exit_irqrestore(flags); > > if (do_cond_resched) > cond_resched(); On the contrary, we could allow steeling the console semaphore when sleeping here. It would allow to get the messages out faster. It might help to move the duty to someone who is actually producing many messages or even the panic() caller. Best Regards, Petr -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-22 10:31 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-08 15:27 [PATCH v4] printk: Add console owner and waiter logic to load balance console writes Steven Rostedt 2017-11-08 15:27 ` Steven Rostedt 2017-11-09 10:12 ` Michal Hocko 2017-11-09 10:12 ` Michal Hocko 2017-11-09 10:22 ` [PATCH v4] printk: Add console owner and waiter logic to loadbalance " Tetsuo Handa 2017-11-09 10:22 ` Tetsuo Handa 2017-11-09 10:26 ` Michal Hocko 2017-11-09 10:26 ` Michal Hocko 2017-11-09 11:03 ` Tetsuo Handa 2017-11-09 11:03 ` Tetsuo Handa 2017-11-09 11:31 ` Michal Hocko 2017-11-09 11:31 ` Michal Hocko 2017-11-09 12:07 ` Tetsuo Handa 2017-11-09 12:07 ` Tetsuo Handa 2017-11-24 15:54 ` [PATCH v4] printk: Add console owner and waiter logic to load balance " Petr Mladek 2017-11-24 15:54 ` Petr Mladek 2017-11-24 15:58 ` Petr Mladek 2017-11-24 15:58 ` Petr Mladek 2017-11-27 8:53 ` Byungchul Park 2017-11-27 8:53 ` Byungchul Park 2017-11-28 1:42 ` Byungchul Park 2017-11-28 1:42 ` Byungchul Park 2017-12-08 14:00 ` Petr Mladek 2017-12-08 14:00 ` Petr Mladek 2017-12-12 5:39 ` Sergey Senozhatsky 2017-12-12 5:39 ` Sergey Senozhatsky 2017-12-12 19:27 ` Steven Rostedt 2017-12-12 19:27 ` Steven Rostedt 2017-12-13 1:50 ` Sergey Senozhatsky 2017-12-13 1:50 ` Sergey Senozhatsky 2017-12-14 14:34 ` Petr Mladek 2017-12-14 14:34 ` Petr Mladek 2017-12-14 13:51 ` Petr Mladek 2017-12-14 13:51 ` Petr Mladek 2017-11-27 8:48 ` Byungchul Park 2017-11-27 8:48 ` Byungchul Park 2017-11-28 6:23 ` Sergey Senozhatsky 2017-11-28 6:23 ` Sergey Senozhatsky 2017-12-22 10:31 ` Petr Mladek [this message] 2017-12-22 10:31 ` Petr Mladek 2017-12-22 12:44 ` Steven Rostedt 2017-12-22 12:44 ` Steven Rostedt 2018-01-10 12:50 ` Petr Mladek 2018-01-10 12:50 ` Petr Mladek -- strict thread matches above, loose matches on Subject: below -- 2017-11-08 15:13 Steven Rostedt 2017-11-08 15:03 Steven Rostedt 2017-11-08 15:10 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171222102927.eiunret5ykx55bvq@pathway.suse.cz \ --to=pmladek@suse.com \ --cc=akpm@linux-foundation.org \ --cc=dave.hansen@intel.com \ --cc=hannes@cmpxchg.org \ --cc=jack@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=rostedt@rostedt.homelinux.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=vbabka@suse.cz \ --cc=xiyou.wangcong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.