From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: ulf.hansson@linaro.org, Kevin Hilman <khilman@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
rnayak@codeaurora.org, sudeep.holla@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values
Date: Wed, 27 Dec 2017 14:26:45 +0530 [thread overview]
Message-ID: <20171227085645.GF8312@vireshk-i7> (raw)
In-Reply-To: <20171226202955.32j7gzonrixtwdpt@rob-hp-laptop>
On 26-12-17, 14:29, Rob Herring wrote:
> On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote:
> > +On some platforms the exact frequency or voltage may be hidden from the OS by
> > +the firmware and the "opp-hz" or the "opp-microvolt" properties may contain
> > +magic values that represent the frequency or voltage in a firmware dependent
> > +way, for example an index of an array in the firmware.
>
> I'm still not convinced this is a good idea.
You were kind-of a few days back :)
lkml.kernel.org/r/CAL_JsqK-qtAaM_Ou5NtxcWR3F_q=8rMPJUm-VqGtKhbtWe5SAQ@mail.gmail.com
So here is the deal:
- I proposed "domain-performance-state" property for this stuff
initially.
- But Kevin didn't like that and proposed reusing "opp-hz" and
"opp-microvolt", which we all agreed to multiple times..
- And we are back to the same discussion now and its painful and time
killing for all of us.
TBH, I don't have too strong preferences about any of the suggestions
you guys have and I need you guys to tell me what binding changes to
do here and I will do that.
> If you have firmware
> partially managing things, then I think we should have platform specific
> bindings or drivers.
What about the initial idea then, like "performance-state" for the
power domains ? All platforms will anyway replicate that binding only.
> This is complex enough I'm not taking silence from Stephen as an okay.
Sure, but I am not sure how to make him speak :)
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Viresh Kumar <vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Rafael Wysocki <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
rnayak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
sudeep.holla-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values
Date: Wed, 27 Dec 2017 14:26:45 +0530 [thread overview]
Message-ID: <20171227085645.GF8312@vireshk-i7> (raw)
In-Reply-To: <20171226202955.32j7gzonrixtwdpt@rob-hp-laptop>
On 26-12-17, 14:29, Rob Herring wrote:
> On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote:
> > +On some platforms the exact frequency or voltage may be hidden from the OS by
> > +the firmware and the "opp-hz" or the "opp-microvolt" properties may contain
> > +magic values that represent the frequency or voltage in a firmware dependent
> > +way, for example an index of an array in the firmware.
>
> I'm still not convinced this is a good idea.
You were kind-of a few days back :)
lkml.kernel.org/r/CAL_JsqK-qtAaM_Ou5NtxcWR3F_q=8rMPJUm-VqGtKhbtWe5SAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
So here is the deal:
- I proposed "domain-performance-state" property for this stuff
initially.
- But Kevin didn't like that and proposed reusing "opp-hz" and
"opp-microvolt", which we all agreed to multiple times..
- And we are back to the same discussion now and its painful and time
killing for all of us.
TBH, I don't have too strong preferences about any of the suggestions
you guys have and I need you guys to tell me what binding changes to
do here and I will do that.
> If you have firmware
> partially managing things, then I think we should have platform specific
> bindings or drivers.
What about the initial idea then, like "performance-state" for the
power domains ? All platforms will anyway replicate that binding only.
> This is complex enough I'm not taking silence from Stephen as an okay.
Sure, but I am not sure how to make him speak :)
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-27 8:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 10:21 [PATCH V8 0/3] OPP: Allow OPP table to be used for power-domains Viresh Kumar
2017-12-18 10:21 ` Viresh Kumar
2017-12-18 10:21 ` [PATCH V8 1/3] " Viresh Kumar
2017-12-21 22:06 ` Rob Herring
2017-12-21 22:06 ` Rob Herring
2017-12-18 10:21 ` [PATCH V8 2/3] OPP: Introduce "required-opp" property Viresh Kumar
2017-12-18 10:21 ` Viresh Kumar
2017-12-20 8:23 ` Ulf Hansson
2017-12-20 8:26 ` Viresh Kumar
2017-12-21 22:26 ` Rob Herring
2017-12-21 22:26 ` Rob Herring
2017-12-22 5:28 ` Viresh Kumar
2017-12-18 10:21 ` [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values Viresh Kumar
2017-12-26 20:29 ` Rob Herring
2017-12-26 20:29 ` Rob Herring
2017-12-27 8:56 ` Viresh Kumar [this message]
2017-12-27 8:56 ` Viresh Kumar
2017-12-27 21:54 ` Rob Herring
2017-12-27 21:54 ` Rob Herring
2017-12-28 4:37 ` Viresh Kumar
2017-12-28 4:37 ` Viresh Kumar
2017-12-29 0:32 ` Stephen Boyd
2017-12-29 0:32 ` Stephen Boyd
2017-12-29 4:58 ` Viresh Kumar
2017-12-29 4:58 ` Viresh Kumar
2018-01-05 22:19 ` Stephen Boyd
2018-01-05 22:19 ` Stephen Boyd
2018-01-08 4:16 ` Viresh Kumar
2018-01-08 4:16 ` Viresh Kumar
2018-01-10 2:54 ` Stephen Boyd
2018-01-10 2:54 ` Stephen Boyd
2018-01-10 5:37 ` Viresh Kumar
2018-01-10 5:37 ` Viresh Kumar
2018-01-13 0:46 ` Stephen Boyd
2018-01-13 0:46 ` Stephen Boyd
2018-01-02 6:05 ` Rajendra Nayak
2018-01-02 6:05 ` Rajendra Nayak
2018-01-02 6:33 ` Viresh Kumar
2018-01-02 6:33 ` Viresh Kumar
2018-01-03 7:20 ` [PATCH V8 0/3] OPP: Allow OPP table to be used for power-domains Viresh Kumar
2018-01-03 7:20 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227085645.GF8312@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.