* [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT
@ 2017-12-29 19:53 Eric Biggers
2018-01-02 18:06 ` Kees Cook
2018-01-08 20:35 ` [tip:locking/urgent] locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry tip-bot for Eric Biggers
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2017-12-29 19:53 UTC (permalink / raw)
To: x86; +Cc: Ingo Molnar, Kees Cook, linux-kernel, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove
the stale comment regarding it being broken.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
arch/x86/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index d4fc98c50378..ff4e9cd99854 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -55,7 +55,6 @@ config X86
select ARCH_HAS_GCOV_PROFILE_ALL
select ARCH_HAS_KCOV if X86_64
select ARCH_HAS_PMEM_API if X86_64
- # Causing hangs/crashes, see the commit that added this change for details.
select ARCH_HAS_REFCOUNT
select ARCH_HAS_UACCESS_FLUSHCACHE if X86_64
select ARCH_HAS_SET_MEMORY
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT
2017-12-29 19:53 [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT Eric Biggers
@ 2018-01-02 18:06 ` Kees Cook
2018-01-08 20:35 ` [tip:locking/urgent] locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry tip-bot for Eric Biggers
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2018-01-02 18:06 UTC (permalink / raw)
To: Ingo Molnar, Eric Biggers; +Cc: X86 ML, LKML, Eric Biggers
On Fri, Dec 29, 2017 at 11:53 AM, Eric Biggers <ebiggers3@gmail.com> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove
> the stale comment regarding it being broken.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> arch/x86/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index d4fc98c50378..ff4e9cd99854 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -55,7 +55,6 @@ config X86
> select ARCH_HAS_GCOV_PROFILE_ALL
> select ARCH_HAS_KCOV if X86_64
> select ARCH_HAS_PMEM_API if X86_64
> - # Causing hangs/crashes, see the commit that added this change for details.
> select ARCH_HAS_REFCOUNT
> select ARCH_HAS_UACCESS_FLUSHCACHE if X86_64
> select ARCH_HAS_SET_MEMORY
> --
> 2.15.1
>
Thanks for the catch!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:locking/urgent] locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry
2017-12-29 19:53 [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT Eric Biggers
2018-01-02 18:06 ` Kees Cook
@ 2018-01-08 20:35 ` tip-bot for Eric Biggers
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Eric Biggers @ 2018-01-08 20:35 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, peterz, tglx, mingo, torvalds, ebiggers, keescook
Commit-ID: f328299e54a94998b31baf788d2b33d8122a4acb
Gitweb: https://git.kernel.org/tip/f328299e54a94998b31baf788d2b33d8122a4acb
Author: Eric Biggers <ebiggers@google.com>
AuthorDate: Fri, 29 Dec 2017 13:53:03 -0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 8 Jan 2018 20:05:04 +0100
locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry
ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove
the stale comment regarding it being broken.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20171229195303.17781-1-ebiggers3@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index d4fc98c..ff4e9cd 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -55,7 +55,6 @@ config X86
select ARCH_HAS_GCOV_PROFILE_ALL
select ARCH_HAS_KCOV if X86_64
select ARCH_HAS_PMEM_API if X86_64
- # Causing hangs/crashes, see the commit that added this change for details.
select ARCH_HAS_REFCOUNT
select ARCH_HAS_UACCESS_FLUSHCACHE if X86_64
select ARCH_HAS_SET_MEMORY
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-08 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-29 19:53 [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT Eric Biggers
2018-01-02 18:06 ` Kees Cook
2018-01-08 20:35 ` [tip:locking/urgent] locking/refcounts: Remove stale comment from the ARCH_HAS_REFCOUNT Kconfig entry tip-bot for Eric Biggers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.