* [PATCH] IB/ipoib: Fix for notify send CQ failure messages
@ 2018-01-02 21:04 Alex Estrin
[not found] ` <20180102210419.26104.32513.stgit-u2TXY/5TJkdZ7WVY1cDZ9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Alex Estrin @ 2018-01-02 21:04 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
it may return positive value indicating non-empty CQ.
If return code not verified the log might be flooded with false
warning messages "request notify on send CQ failed".
Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/ulp/ipoib/ipoib_cm.c | 10 ++++++----
drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 +-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
index 2c13123..8152724 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
@@ -766,12 +766,14 @@ void ipoib_cm_send(struct net_device *dev, struct sk_buff *skb, struct ipoib_cm_
skb_orphan(skb);
skb_dst_drop(skb);
- if (netif_queue_stopped(dev))
- if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
- IB_CQ_REPORT_MISSED_EVENTS)) {
+ if (netif_queue_stopped(dev)) {
+ rc = ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
+ IB_CQ_REPORT_MISSED_EVENTS);
+ if (unlikely(rc < 0))
ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
+ else if (rc)
napi_schedule(&priv->send_napi);
- }
+ }
rc = post_send(priv, tx, tx->tx_head & (ipoib_sendq_size - 1), tx_req);
if (unlikely(rc)) {
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index e6151a2..2865808 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -644,7 +644,7 @@ int ipoib_send(struct net_device *dev, struct sk_buff *skb,
if (netif_queue_stopped(dev))
if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
- IB_CQ_REPORT_MISSED_EVENTS))
+ IB_CQ_REPORT_MISSED_EVENTS) < 0)
ipoib_warn(priv, "request notify on send CQ failed\n");
rc = post_send(priv, priv->tx_head & (ipoib_sendq_size - 1),
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
[not found] ` <20180102210419.26104.32513.stgit-u2TXY/5TJkdZ7WVY1cDZ9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
@ 2018-01-02 21:24 ` Jason Gunthorpe
[not found] ` <20180102212407.GA19027-uk2M96/98Pc@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2018-01-02 21:24 UTC (permalink / raw)
To: Alex Estrin, Erez Shitrit; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
> If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
> it may return positive value indicating non-empty CQ.
> If return code not verified the log might be flooded with false
> warning messages "request notify on send CQ failed".
>
> Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
Hurm... It was right before that commit as well..
Erez, why did you change it?
+ if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
+ IB_CQ_REPORT_MISSED_EVENTS)) {
+ ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
...
- rc = ib_req_notify_cq(priv->send_cq,
- IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS);
- if (rc < 0)
- ipoib_warn(priv, "request notify on send CQ failed\n");
Alex, that is not the right format for the Fixes: line..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
[not found] ` <20180102212407.GA19027-uk2M96/98Pc@public.gmane.org>
@ 2018-01-03 9:33 ` Erez Shitrit
[not found] ` <CAAk-MO_ArzS5irkN-_nt_YYL3+YgL+FpM6WLvPZfM-mKexsShg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 12:03 ` Estrin, Alex
1 sibling, 1 reply; 5+ messages in thread
From: Erez Shitrit @ 2018-01-03 9:33 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: Alex Estrin, Erez Shitrit, RDMA mailing list
On Tue, Jan 2, 2018 at 11:24 PM, Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
> On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
>> If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
>> it may return positive value indicating non-empty CQ.
>> If return code not verified the log might be flooded with false
>> warning messages "request notify on send CQ failed".
>>
>> Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
>
> Hurm... It was right before that commit as well..
>
> Erez, why did you change it?
I don't think i changed it.
anyway, Alex's patch makes sense, even it is a rare case anyway, and
no flooded will happened.
>
> + if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
> + IB_CQ_REPORT_MISSED_EVENTS)) {
> + ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
> ...
> - rc = ib_req_notify_cq(priv->send_cq,
> - IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS);
> - if (rc < 0)
> - ipoib_warn(priv, "request notify on send CQ failed\n");
>
> Alex, that is not the right format for the Fixes: line..
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
[not found] ` <20180102212407.GA19027-uk2M96/98Pc@public.gmane.org>
2018-01-03 9:33 ` Erez Shitrit
@ 2018-01-03 12:03 ` Estrin, Alex
1 sibling, 0 replies; 5+ messages in thread
From: Estrin, Alex @ 2018-01-03 12:03 UTC (permalink / raw)
To: Jason Gunthorpe, Erez Shitrit; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Jason Gunthorpe
> Sent: Tuesday, January 2, 2018 4:24 PM
> To: Estrin, Alex <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>; Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
>
> On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
> > If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
> > it may return positive value indicating non-empty CQ.
> > If return code not verified the log might be flooded with false
> > warning messages "request notify on send CQ failed".
> >
> > Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
>
> Hurm... It was right before that commit as well..
>
> Erez, why did you change it?
>
> + if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
> + IB_CQ_REPORT_MISSED_EVENTS)) {
> + ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
> ...
> - rc = ib_req_notify_cq(priv->send_cq,
> - IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS);
> - if (rc < 0)
> - ipoib_warn(priv, "request notify on send CQ failed\n");
>
> Alex, that is not the right format for the Fixes: line..
Jason, thanks for noticing. I'll resend v2
Alex.
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
[not found] ` <CAAk-MO_ArzS5irkN-_nt_YYL3+YgL+FpM6WLvPZfM-mKexsShg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-01-03 16:06 ` Jason Gunthorpe
0 siblings, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2018-01-03 16:06 UTC (permalink / raw)
To: Erez Shitrit; +Cc: Alex Estrin, Erez Shitrit, RDMA mailing list
On Wed, Jan 03, 2018 at 11:33:05AM +0200, Erez Shitrit wrote:
> On Tue, Jan 2, 2018 at 11:24 PM, Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
> > On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
> >> If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
> >> it may return positive value indicating non-empty CQ.
> >> If return code not verified the log might be flooded with false
> >> warning messages "request notify on send CQ failed".
> >>
> >> Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
> >
> > Hurm... It was right before that commit as well..
> >
> > Erez, why did you change it?
>
> I don't think i changed it.
Okay, then it is a typo when you reworked things for NAPI that the >0
case started making warnings. I will apply this patch.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-03 16:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-02 21:04 [PATCH] IB/ipoib: Fix for notify send CQ failure messages Alex Estrin
[not found] ` <20180102210419.26104.32513.stgit-u2TXY/5TJkdZ7WVY1cDZ9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2018-01-02 21:24 ` Jason Gunthorpe
[not found] ` <20180102212407.GA19027-uk2M96/98Pc@public.gmane.org>
2018-01-03 9:33 ` Erez Shitrit
[not found] ` <CAAk-MO_ArzS5irkN-_nt_YYL3+YgL+FpM6WLvPZfM-mKexsShg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 16:06 ` Jason Gunthorpe
2018-01-03 12:03 ` Estrin, Alex
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.