[PATCH] RDMA/qedr: Use zeroing memory allocator than allocator/memset

[PATCH] RDMA/qedr: Use zeroing memory allocator than allocator/memset

[Himanshu Jha]

Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
 drivers/infiniband/hw/qedr/verbs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index b26aa88..3b9c898 100644
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -604,12 +604,11 @@ static struct qedr_pbl *qedr_alloc_pbl_tbl(struct qedr_dev *dev,
 		return ERR_PTR(-ENOMEM);
 
 	for (i = 0; i < pbl_info->num_pbls; i++) {
-		va = dma_alloc_coherent(&pdev->dev, pbl_info->pbl_size,
-					&pa, flags);
+		va = dma_zalloc_coherent(&pdev->dev, pbl_info->pbl_size,
+					 &pa, flags);
 		if (!va)
 			goto err;
 
-		memset(va, 0, pbl_info->pbl_size);
 		pbl_table[i].va = va;
 		pbl_table[i].pa = pa;
 	}
-- 
2.7.4

RE: [PATCH] RDMA/qedr: Use zeroing memory allocator than allocator/memset

[Amrani, Ram]

> Use dma_zalloc_coherent for allocating zeroed
> memory and remove unnecessary memset function.
> 
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 0-day tested with no failures.
> 
> Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
>  drivers/infiniband/hw/qedr/verbs.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
> index b26aa88..3b9c898 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -604,12 +604,11 @@ static struct qedr_pbl *qedr_alloc_pbl_tbl(struct qedr_dev *dev,
>  		return ERR_PTR(-ENOMEM);
> 
>  	for (i = 0; i < pbl_info->num_pbls; i++) {
> -		va = dma_alloc_coherent(&pdev->dev, pbl_info->pbl_size,
> -					&pa, flags);
> +		va = dma_zalloc_coherent(&pdev->dev, pbl_info->pbl_size,
> +					 &pa, flags);
>  		if (!va)
>  			goto err;
> 
> -		memset(va, 0, pbl_info->pbl_size);
>  		pbl_table[i].va = va;
>  		pbl_table[i].pa = pa;
>  	}
> --
> 2.7.4

Acked-by: Ram Amrani <Ram.Amrani@cavium.com>

Thanks,
Ram

Re: [PATCH] RDMA/qedr: Use zeroing memory allocator than allocator/memset

[Jason Gunthorpe]

On Sun, Dec 31, 2017 at 06:01:03PM +0530, Himanshu Jha wrote:
> Use dma_zalloc_coherent for allocating zeroed
> memory and remove unnecessary memset function.
> 
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 0-day tested with no failures.
> 
> Suggested-by: Luis R. Rodriguez <mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Himanshu Jha <himanshujha199640-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Acked-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>  drivers/infiniband/hw/qedr/verbs.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied to for-next thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] RDMA/qedr: Use zeroing memory allocator than allocator/memset

[Jason Gunthorpe]

On Sun, Dec 31, 2017 at 06:01:03PM +0530, Himanshu Jha wrote:
> Use dma_zalloc_coherent for allocating zeroed
> memory and remove unnecessary memset function.
> 
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 0-day tested with no failures.
> 
> Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> Acked-by: Ram Amrani <Ram.Amrani@cavium.com>
>  drivers/infiniband/hw/qedr/verbs.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied to for-next thanks

Jason