From: Bjorn Andersson <bjorn.andersson@linaro.org> To: srinivas.kandagatla@linaro.org Cc: Andy Gross <andy.gross@linaro.org>, Mark Brown <broonie@kernel.org>, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Banajit Goswami <bgoswami@codeaurora.org>, linux-kernel@vger.kernel.org, Patrick Lai <plai@codeaurora.org>, Takashi Iwai <tiwai@suse.com>, sboyd@codeaurora.org, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, David Brown <david.brown@linaro.org>, Rob Herring <robh+dt@kernel.org>, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v2 01/15] dt-bindings: soc: qcom: Add bindings for APR bus Date: Tue, 2 Jan 2018 16:35:04 -0800 [thread overview] Message-ID: <20180103003504.GX478@tuxbook> (raw) In-Reply-To: <20171214173402.19074-2-srinivas.kandagatla@linaro.org> On Thu 14 Dec 09:33 PST 2017, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > This patch add dt bindings for Qualcomm APR bus driver > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../devicetree/bindings/soc/qcom/qcom,apr.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > new file mode 100644 > index 000000000000..4e93213ae98d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > @@ -0,0 +1,28 @@ > +Qualcomm APR (Asynchronous Packet Router) binding > + > +This binding describes the Qualcomm APR. APR is a IPC protocol for > +communication between Application processor and QDSP. APR is mainly > +used for audio/voice services on the QDSP. > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: must be "qcom,apr-<SOC-NAME>" example: "qcom,apr-msm8996" This is not the only apr on msm8996 and some platform seems to have 3-4 aprs. I'm therefor hesitant to use the compatible to pick the static list of services available on the particular firmware. If this scheme is followed we at least would need to rename this qcom,msm8996-apr-audio-svc But I think it would be preferable to go with qcom,apr-v2 and then list the static services as child nodes. > + > + > +- qcom,smd-channel: > + Usage: required > + Value type: <string> > + Definition: standard SMD property specifying the SMD channel used for > + communication with the APR on QDSP. > + Should be "apr_audio_svc". This is not the only APR channel, but for apr itself this doesn't matter and might as well be qcom,glink-channels; so perhaps we can omit this from this document? > + Described in soc/qcom/qcom,smd.txt > + > += EXAMPLE > +The following example represents a QDSP based sound card on a MSM8996 device > +which uses apr as communication between Apps and QDSP. > + > + apr { > + compatible = "qcom,apr-msm8996"; > + qcom,smd-channels = "apr_audio_svc"; > + }; Regards, Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson) To: linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH v2 01/15] dt-bindings: soc: qcom: Add bindings for APR bus Date: Tue, 2 Jan 2018 16:35:04 -0800 [thread overview] Message-ID: <20180103003504.GX478@tuxbook> (raw) In-Reply-To: <20171214173402.19074-2-srinivas.kandagatla@linaro.org> On Thu 14 Dec 09:33 PST 2017, srinivas.kandagatla at linaro.org wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > This patch add dt bindings for Qualcomm APR bus driver > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../devicetree/bindings/soc/qcom/qcom,apr.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > new file mode 100644 > index 000000000000..4e93213ae98d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > @@ -0,0 +1,28 @@ > +Qualcomm APR (Asynchronous Packet Router) binding > + > +This binding describes the Qualcomm APR. APR is a IPC protocol for > +communication between Application processor and QDSP. APR is mainly > +used for audio/voice services on the QDSP. > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: must be "qcom,apr-<SOC-NAME>" example: "qcom,apr-msm8996" This is not the only apr on msm8996 and some platform seems to have 3-4 aprs. I'm therefor hesitant to use the compatible to pick the static list of services available on the particular firmware. If this scheme is followed we at least would need to rename this qcom,msm8996-apr-audio-svc But I think it would be preferable to go with qcom,apr-v2 and then list the static services as child nodes. > + > + > +- qcom,smd-channel: > + Usage: required > + Value type: <string> > + Definition: standard SMD property specifying the SMD channel used for > + communication with the APR on QDSP. > + Should be "apr_audio_svc". This is not the only APR channel, but for apr itself this doesn't matter and might as well be qcom,glink-channels; so perhaps we can omit this from this document? > + Described in soc/qcom/qcom,smd.txt > + > += EXAMPLE > +The following example represents a QDSP based sound card on a MSM8996 device > +which uses apr as communication between Apps and QDSP. > + > + apr { > + compatible = "qcom,apr-msm8996"; > + qcom,smd-channels = "apr_audio_svc"; > + }; Regards, Bjorn
next prev parent reply other threads:[~2018-01-03 0:35 UTC|newest] Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-14 17:33 [RESEND PATCH v2 00/15] ASoC: qcom: Add support to QDSP6 based audio srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` [RESEND PATCH v2 01/15] dt-bindings: soc: qcom: Add bindings for APR bus srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla [not found] ` <20171214173402.19074-2-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-12-16 17:27 ` Rob Herring 2017-12-16 17:27 ` Rob Herring 2017-12-16 17:27 ` Rob Herring 2017-12-18 9:50 ` Srinivas Kandagatla 2017-12-18 9:50 ` Srinivas Kandagatla 2018-01-03 0:35 ` Bjorn Andersson [this message] 2018-01-03 0:35 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 02/15] soc: qcom: add support to APR bus driver srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org [not found] ` <20171214173402.19074-3-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-01 23:29 ` Bjorn Andersson 2018-01-01 23:29 ` Bjorn Andersson 2018-01-01 23:29 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 03/15] ASoC: qcom: qdsp6: Add common qdsp6 helper functions srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla 2018-01-02 0:19 ` Bjorn Andersson 2018-01-02 0:19 ` Bjorn Andersson 2018-01-02 0:19 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 04/15] ASoC: qcom: qdsp6: Add support to Q6AFE srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla 2018-01-02 0:45 ` Bjorn Andersson 2018-01-02 0:45 ` Bjorn Andersson 2018-01-02 0:45 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 05/15] ASoC: qcom: qdsp6: Add support to Q6ADM srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org [not found] ` <20171214173402.19074-6-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-02 1:50 ` Bjorn Andersson 2018-01-02 1:50 ` Bjorn Andersson 2018-01-02 1:50 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 06/15] ASoC: qcom: qdsp6: Add support to Q6ASM srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla [not found] ` <20171214173402.19074-7-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-02 4:43 ` Bjorn Andersson 2018-01-02 4:43 ` Bjorn Andersson 2018-01-02 4:43 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 08/15] ASoC: qcom: q6asm: add support to audio stream apis srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla 2018-01-02 20:08 ` Bjorn Andersson 2018-01-02 20:08 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-13 8:42 ` Rohit Kumar 2018-01-13 8:42 ` [alsa-devel] " Rohit Kumar 2018-01-13 8:42 ` Rohit Kumar 2017-12-14 17:33 ` [RESEND PATCH v2 09/15] ASoC: qcom: qdsp6: Add support to Q6CORE srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla 2018-01-02 22:15 ` Bjorn Andersson 2018-01-02 22:15 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-02-07 12:15 ` [alsa-devel] " Rohit Kumar 2018-02-07 12:15 ` Rohit Kumar 2017-12-14 17:33 ` [RESEND PATCH v2 10/15] ASoC: qcom: qdsp6: Add support to q6routing driver srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2018-01-02 23:00 ` Bjorn Andersson 2018-01-02 23:00 ` Bjorn Andersson 2018-01-02 23:00 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 11/15] ASoC: qcom: qdsp6: Add support to q6afe dai driver srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org [not found] ` <20171214173402.19074-12-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-02 23:28 ` Bjorn Andersson 2018-01-02 23:28 ` Bjorn Andersson 2018-01-02 23:28 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-02-07 11:34 ` Rohit Kumar 2018-02-07 11:34 ` [alsa-devel] " Rohit Kumar 2018-02-07 11:34 ` Rohit Kumar 2018-02-07 11:40 ` Srinivas Kandagatla 2018-02-07 11:40 ` Srinivas Kandagatla 2017-12-14 17:33 ` [RESEND PATCH v2 12/15] ASoC: qcom: qdsp6: Add support to q6asm " srinivas.kandagatla 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2018-01-03 0:03 ` Bjorn Andersson 2018-01-03 0:03 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-13 8:45 ` [alsa-devel] " Rohit Kumar 2018-01-13 8:45 ` Rohit Kumar [not found] ` <20171214173402.19074-1-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-12-14 17:33 ` [RESEND PATCH v2 07/15] ASoC: qcom: q6asm: Add support to memory map and unmap srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A 2017-12-14 17:33 ` srinivas.kandagatla at linaro.org 2017-12-14 17:33 ` srinivas.kandagatla 2018-01-02 5:48 ` Bjorn Andersson 2018-01-02 5:48 ` Bjorn Andersson 2018-01-03 16:26 ` Srinivas Kandagatla 2018-01-03 16:26 ` Srinivas Kandagatla [not found] ` <4d1d17df-71a4-2896-29c1-9d033a2f3711-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-03 19:39 ` Bjorn Andersson 2018-01-03 19:39 ` Bjorn Andersson 2018-01-03 19:39 ` Bjorn Andersson 2017-12-14 17:34 ` [RESEND PATCH v2 13/15] dt-bindings: sound: qcom: Add devicetree bindings for apq8096 srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A 2017-12-14 17:34 ` srinivas.kandagatla at linaro.org 2017-12-14 17:34 ` srinivas.kandagatla 2017-12-16 17:44 ` Rob Herring 2017-12-16 17:44 ` Rob Herring 2017-12-18 9:49 ` Srinivas Kandagatla 2017-12-18 9:49 ` Srinivas Kandagatla 2017-12-18 9:49 ` Srinivas Kandagatla 2018-01-03 0:28 ` Bjorn Andersson 2018-01-03 0:28 ` Bjorn Andersson 2018-01-03 0:28 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla [not found] ` <787ecdc5-66d8-23ee-7136-2a8759c86536-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-03 19:49 ` Bjorn Andersson 2018-01-03 19:49 ` Bjorn Andersson 2018-01-03 19:49 ` Bjorn Andersson 2017-12-14 17:34 ` [RESEND PATCH v2 14/15] ASoC: qcom: apq8096: Add db820c machine driver srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A 2017-12-14 17:34 ` srinivas.kandagatla at linaro.org 2017-12-14 17:34 ` srinivas.kandagatla 2018-01-03 0:16 ` Bjorn Andersson 2018-01-03 0:16 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 20:04 ` Bjorn Andersson 2018-01-03 20:04 ` Bjorn Andersson 2018-01-03 20:04 ` Bjorn Andersson 2018-01-03 17:20 ` Stephen Boyd 2018-01-03 17:20 ` Stephen Boyd 2018-01-03 18:36 ` Srinivas Kandagatla 2018-01-03 18:36 ` Srinivas Kandagatla 2018-01-03 19:41 ` Stephen Boyd 2018-01-03 19:41 ` Stephen Boyd 2018-01-03 19:41 ` Stephen Boyd 2018-01-04 9:25 ` Srinivas Kandagatla 2018-01-04 9:25 ` Srinivas Kandagatla 2018-01-04 12:02 ` Mark Brown 2018-01-04 12:02 ` Mark Brown 2018-01-04 12:02 ` Mark Brown 2018-01-04 13:44 ` Srinivas Kandagatla 2018-01-04 13:44 ` Srinivas Kandagatla 2018-01-04 14:03 ` Mark Brown 2018-01-04 14:03 ` Mark Brown 2018-01-04 14:03 ` Mark Brown 2017-12-14 17:34 ` [RESEND PATCH v2 15/15] arm64: dts: msm8996: db820c: Add sound card support srinivas.kandagatla 2017-12-14 17:34 ` srinivas.kandagatla at linaro.org [not found] ` <20171214173402.19074-16-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2018-01-03 0:22 ` Bjorn Andersson 2018-01-03 0:22 ` Bjorn Andersson 2018-01-03 0:22 ` Bjorn Andersson 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 16:27 ` Srinivas Kandagatla 2018-01-03 20:01 ` Bjorn Andersson 2018-01-03 20:01 ` Bjorn Andersson 2018-01-03 20:01 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180103003504.GX478@tuxbook \ --to=bjorn.andersson@linaro.org \ --cc=alsa-devel@alsa-project.org \ --cc=andy.gross@linaro.org \ --cc=bgoswami@codeaurora.org \ --cc=broonie@kernel.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=perex@perex.cz \ --cc=plai@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.