* [PATCH] dm bufio: fix missed destroy of mutex c->lock
@ 2018-01-04 14:31 Xiongwei Song
0 siblings, 0 replies; 3+ messages in thread
From: Xiongwei Song @ 2018-01-04 14:31 UTC (permalink / raw)
To: agk, snitzer, dm-devel; +Cc: linux-kernel
The mutex c->lock is initialized in dm_bufio_client_create, however,
it is not destroyed before free the structure of dm_bufio_client in
dm_bufio_client_destroy.
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
drivers/md/dm-bufio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index c546b567f3b5..53c0d5d2039a 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1811,6 +1811,7 @@ void dm_bufio_client_destroy(struct dm_bufio_client *c)
BUG_ON(c->n_buffers[i]);
dm_io_client_destroy(c->dm_io);
+ mutex_destroy(&c->lock);
kfree(c);
}
EXPORT_SYMBOL_GPL(dm_bufio_client_destroy);
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dm bufio: fix missed destroy of mutex c->lock
2018-01-04 14:08 Xiongwei Song
@ 2018-01-04 14:11 ` Xiongwei Song
0 siblings, 0 replies; 3+ messages in thread
From: Xiongwei Song @ 2018-01-04 14:11 UTC (permalink / raw)
To: agk, snitzer, dm-devel; +Cc: inux-kernel
2018-01-04 22:08 GMT+08:00 Xiongwei Song <sxwjean@gmail.com>:
> The mutex c->lock is initialized in dm_bufio_client_create, however,
> it is not destroyed before free the structure of dm_bufio_client in
> dm_bufio_client_destroy.
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> ---
> drivers/md/dm-bufio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
> index c546b567f3b5..53c0d5d2039a 100644
> --- a/drivers/md/dm-bufio.c
> +++ b/drivers/md/dm-bufio.c
> @@ -1811,6 +1811,7 @@ void dm_bufio_client_destroy(struct dm_bufio_client *c)
> BUG_ON(c->n_buffers[i]);
>
> dm_io_client_destroy(c->dm_io);
> + mutex_destroy(&c->lock);
> kfree(c);
> }
> EXPORT_SYMBOL_GPL(dm_bufio_client_destroy);
> --
> 2.15.1
>
Sorry for the noise. I added incorrect email address.
Please ignore the message. Sorry for this again.
Yours sincerely,
Xiongwei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] dm bufio: fix missed destroy of mutex c->lock
@ 2018-01-04 14:08 Xiongwei Song
2018-01-04 14:11 ` Xiongwei Song
0 siblings, 1 reply; 3+ messages in thread
From: Xiongwei Song @ 2018-01-04 14:08 UTC (permalink / raw)
To: agk, snitzer, dm-devel; +Cc: inux-kernel
The mutex c->lock is initialized in dm_bufio_client_create, however,
it is not destroyed before free the structure of dm_bufio_client in
dm_bufio_client_destroy.
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
drivers/md/dm-bufio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index c546b567f3b5..53c0d5d2039a 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1811,6 +1811,7 @@ void dm_bufio_client_destroy(struct dm_bufio_client *c)
BUG_ON(c->n_buffers[i]);
dm_io_client_destroy(c->dm_io);
+ mutex_destroy(&c->lock);
kfree(c);
}
EXPORT_SYMBOL_GPL(dm_bufio_client_destroy);
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-04 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-04 14:31 [PATCH] dm bufio: fix missed destroy of mutex c->lock Xiongwei Song
-- strict thread matches above, loose matches on Subject: below --
2018-01-04 14:08 Xiongwei Song
2018-01-04 14:11 ` Xiongwei Song
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.