* [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready
@ 2017-12-24 10:39 Jia-Ju Bai
[not found] ` <1514111980-30502-1-git-send-email-baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Jia-Ju Bai @ 2017-12-24 10:39 UTC (permalink / raw)
To: faisal.latif, shiraz.saleem, dledford, jgg
Cc: linux-rdma, linux-kernel, Jia-Ju Bai
i40iw_wait_pe_ready is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with msleep,
to reduce busy wait.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index e824296..8098bc1 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -1285,7 +1285,7 @@ static void i40iw_wait_pe_ready(struct i40iw_hw *hw)
__LINE__, statuscpu2);
if ((statuscpu0 == 0x80) && (statuscpu1 == 0x80) && (statuscpu2 == 0x80))
break; /* SUCCESS */
- mdelay(1000);
+ msleep(1000);
retrycount++;
} while (retrycount < 14);
i40iw_wr32(hw, 0xb4040, 0x4C104C5);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1514111980-30502-1-git-send-email-baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready 2017-12-24 10:39 [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready Jia-Ju Bai @ 2017-12-24 11:57 ` Leon Romanovsky 0 siblings, 0 replies; 6+ messages in thread From: Leon Romanovsky @ 2017-12-24 11:57 UTC (permalink / raw) To: Jia-Ju Bai Cc: faisal.latif-ral2JQCrhuEAvxtiuMwx3w, shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w, dledford-H+wXaHxf7aLQT0dZR+AlfA, jgg-uk2M96/98Pc, linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 509 bytes --] On Sun, Dec 24, 2017 at 06:39:40PM +0800, Jia-Ju Bai wrote: > i40iw_wait_pe_ready is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, > to reduce busy wait. > > Signed-off-by: Jia-Ju Bai <baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready @ 2017-12-24 11:57 ` Leon Romanovsky 0 siblings, 0 replies; 6+ messages in thread From: Leon Romanovsky @ 2017-12-24 11:57 UTC (permalink / raw) To: Jia-Ju Bai Cc: faisal.latif, shiraz.saleem, dledford, jgg, linux-rdma, linux-kernel [-- Attachment #1: Type: text/plain, Size: 452 bytes --] On Sun, Dec 24, 2017 at 06:39:40PM +0800, Jia-Ju Bai wrote: > i40iw_wait_pe_ready is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, > to reduce busy wait. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready 2017-12-24 10:39 [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready Jia-Ju Bai @ 2018-01-05 17:44 ` Shiraz Saleem 0 siblings, 0 replies; 6+ messages in thread From: Shiraz Saleem @ 2018-01-05 17:44 UTC (permalink / raw) To: Jia-Ju Bai Cc: Latif, Faisal, dledford-H+wXaHxf7aLQT0dZR+AlfA, jgg-uk2M96/98Pc, linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Sun, Dec 24, 2017 at 03:39:40AM -0700, Jia-Ju Bai wrote: > i40iw_wait_pe_ready is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, > to reduce busy wait. > > Signed-off-by: Jia-Ju Bai <baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks! Acked-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready @ 2018-01-05 17:44 ` Shiraz Saleem 0 siblings, 0 replies; 6+ messages in thread From: Shiraz Saleem @ 2018-01-05 17:44 UTC (permalink / raw) To: Jia-Ju Bai; +Cc: Latif, Faisal, dledford, jgg, linux-rdma, linux-kernel On Sun, Dec 24, 2017 at 03:39:40AM -0700, Jia-Ju Bai wrote: > i40iw_wait_pe_ready is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, > to reduce busy wait. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks! Acked-by: Shiraz Saleem <shiraz.saleem@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready 2018-01-05 17:44 ` Shiraz Saleem (?) @ 2018-01-05 18:47 ` Doug Ledford -1 siblings, 0 replies; 6+ messages in thread From: Doug Ledford @ 2018-01-05 18:47 UTC (permalink / raw) To: Shiraz Saleem, Jia-Ju Bai; +Cc: Latif, Faisal, jgg, linux-rdma, linux-kernel [-- Attachment #1: Type: text/plain, Size: 731 bytes --] On Fri, 2018-01-05 at 11:44 -0600, Shiraz Saleem wrote: > On Sun, Dec 24, 2017 at 03:39:40AM -0700, Jia-Ju Bai wrote: > > i40iw_wait_pe_ready is not called in an interrupt handler > > nor holding a spinlock. > > The function mdelay in it can be replaced with msleep, > > to reduce busy wait. > > > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > > --- > > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks! > Acked-by: Shiraz Saleem <shiraz.saleem@intel.com> > > Thanks, applied. -- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-05 18:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-24 10:39 [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready Jia-Ju Bai
[not found] ` <1514111980-30502-1-git-send-email-baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-24 11:57 ` Leon Romanovsky
2017-12-24 11:57 ` Leon Romanovsky
2018-01-05 17:44 ` Shiraz Saleem
2018-01-05 17:44 ` Shiraz Saleem
2018-01-05 18:47 ` Doug Ledford
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.