From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Sakari Ailus <sakari.ailus@iki.fi>, Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, tomoharu.fukawa.eb@renesas.com, Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: Re: [PATCH v9 07/28] rcar-vin: change name of video device Date: Mon, 8 Jan 2018 17:42:05 +0100 [thread overview] Message-ID: <20180108164205.GC23075@bigcity.dyn.berto.se> (raw) In-Reply-To: <5666028.A5BLSl6sJg@avalon> Hi Laurent, On 2018-01-08 18:35:23 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > > On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > > >> On Fri, Dec 08, 2017 at 10:17:36AM +0200, Laurent Pinchart wrote: > > >>> On Friday, 8 December 2017 03:08:21 EET Niklas Söderlund wrote: > > >>>> The rcar-vin driver needs to be part of a media controller to > > >>>> support Gen3. Give each VIN instance a unique name so it can be > > >>>> referenced from userspace. > > >>>> > > >>>> Signed-off-by: Niklas Söderlund > > >>>> <niklas.soderlund+renesas@ragnatech.se> > > >>>> Reviewed-by: Kieran Bingham > > >>>> <kieran.bingham+renesas@ideasonboard.com> > > >>>> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com> > > >>>> --- > > >>>> > > >>>> drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 ++- > > >>>> 1 file changed, 2 insertions(+), 1 deletion(-) > > >>>> > > >>>> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c > > >>>> b/drivers/media/platform/rcar-vin/rcar-v4l2.c index > > >>>> 59ec6d3d119590aa..19de99133f048960 100644 > > >>>> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > > >>>> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > > >>>> @@ -876,7 +876,8 @@ int rvin_v4l2_register(struct rvin_dev *vin) > > >>>> vdev->fops = &rvin_fops; > > >>>> vdev->v4l2_dev = &vin->v4l2_dev; > > >>>> vdev->queue = &vin->queue; > > >>>> - strlcpy(vdev->name, KBUILD_MODNAME, sizeof(vdev->name)); > > >>>> + snprintf(vdev->name, sizeof(vdev->name), "%s %s", KBUILD_MODNAME, > > >>>> + dev_name(vin->dev)); > > >>> > > >>> Do we need the module name here ? How about calling them "%s output", > > >>> dev_name(vin->dev) to emphasize the fact that this is a video node and > > >>> not a VIN subdev ? This is what the omap3isp and vsp1 drivers do. > > >>> > > >>> We're suffering a bit from the fact that V4L2 has never standardized a > > >>> naming scheme for the devices. It wouldn't be fair to ask you to fix > > >>> that as a prerequisite to get the VIN driver merged, but we clearly have > > >>> to work on that at some point. > > >> > > >> Agreed, this needs to be stable and I think aligning to what omap3isp or > > >> vsp1 do would be a good fix here. > > > > > > Even omap3isp and vsp1 are not fully aligned, so I think we need to design > > > a naming policy and document it. > > > > I agree that align this is a good idea. And for this reason I chosen to > > update this patch as such: > > > > "%s output", dev_name(vin->dev) > > Wouldn't it be easier for userspace to use > > "VIN%u output", index > > where index is the VIN index as specified in DT ? I would be OK whit this, but do this agree with the idea above that we should try to align this name across drivers? > > > I hope this is a step in the correct direction. If not please let me > > know as soon as possible so I can minimize the trouble for the other > > developers doing stuff on-top of this series and there test scripts :-) > > -- > Regards, > > Laurent Pinchart > -- Regards, Niklas Söderlund
WARNING: multiple messages have this Message-ID (diff)
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Sakari Ailus <sakari.ailus@iki.fi>, Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, tomoharu.fukawa.eb@renesas.com, Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: Re: [PATCH v9 07/28] rcar-vin: change name of video device Date: Mon, 8 Jan 2018 17:42:05 +0100 [thread overview] Message-ID: <20180108164205.GC23075@bigcity.dyn.berto.se> (raw) In-Reply-To: <5666028.A5BLSl6sJg@avalon> Hi Laurent, On 2018-01-08 18:35:23 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Wednesday, 20 December 2017 17:20:55 EET Niklas S�derlund wrote: > > On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > > >> On Fri, Dec 08, 2017 at 10:17:36AM +0200, Laurent Pinchart wrote: > > >>> On Friday, 8 December 2017 03:08:21 EET Niklas S�derlund wrote: > > >>>> The rcar-vin driver needs to be part of a media controller to > > >>>> support Gen3. Give each VIN instance a unique name so it can be > > >>>> referenced from userspace. > > >>>> > > >>>> Signed-off-by: Niklas S�derlund > > >>>> <niklas.soderlund+renesas@ragnatech.se> > > >>>> Reviewed-by: Kieran Bingham > > >>>> <kieran.bingham+renesas@ideasonboard.com> > > >>>> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com> > > >>>> --- > > >>>> > > >>>> drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 ++- > > >>>> 1 file changed, 2 insertions(+), 1 deletion(-) > > >>>> > > >>>> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c > > >>>> b/drivers/media/platform/rcar-vin/rcar-v4l2.c index > > >>>> 59ec6d3d119590aa..19de99133f048960 100644 > > >>>> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > > >>>> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > > >>>> @@ -876,7 +876,8 @@ int rvin_v4l2_register(struct rvin_dev *vin) > > >>>> vdev->fops = &rvin_fops; > > >>>> vdev->v4l2_dev = &vin->v4l2_dev; > > >>>> vdev->queue = &vin->queue; > > >>>> - strlcpy(vdev->name, KBUILD_MODNAME, sizeof(vdev->name)); > > >>>> + snprintf(vdev->name, sizeof(vdev->name), "%s %s", KBUILD_MODNAME, > > >>>> + dev_name(vin->dev)); > > >>> > > >>> Do we need the module name here ? How about calling them "%s output", > > >>> dev_name(vin->dev) to emphasize the fact that this is a video node and > > >>> not a VIN subdev ? This is what the omap3isp and vsp1 drivers do. > > >>> > > >>> We're suffering a bit from the fact that V4L2 has never standardized a > > >>> naming scheme for the devices. It wouldn't be fair to ask you to fix > > >>> that as a prerequisite to get the VIN driver merged, but we clearly have > > >>> to work on that at some point. > > >> > > >> Agreed, this needs to be stable and I think aligning to what omap3isp or > > >> vsp1 do would be a good fix here. > > > > > > Even omap3isp and vsp1 are not fully aligned, so I think we need to design > > > a naming policy and document it. > > > > I agree that align this is a good idea. And for this reason I chosen to > > update this patch as such: > > > > "%s output", dev_name(vin->dev) > > Wouldn't it be easier for userspace to use > > "VIN%u output", index > > where index is the VIN index as specified in DT ? I would be OK whit this, but do this agree with the idea above that we should try to align this name across drivers? > > > I hope this is a step in the correct direction. If not please let me > > know as soon as possible so I can minimize the trouble for the other > > developers doing stuff on-top of this series and there test scripts :-) > > -- > Regards, > > Laurent Pinchart > -- Regards, Niklas S�derlund
next prev parent reply other threads:[~2018-01-08 16:42 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-08 1:08 [PATCH v9 00/28] rcar-vin: Add Gen3 with media controller Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 01/28] rcar-vin: add Gen3 devicetree bindings documentation Niklas Söderlund 2017-12-08 7:46 ` Laurent Pinchart 2017-12-08 12:55 ` Niklas Söderlund 2017-12-08 12:55 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 02/28] rcar-vin: rename poorly named initialize and cleanup functions Niklas Söderlund 2017-12-08 7:49 ` Laurent Pinchart 2017-12-08 12:58 ` Niklas Söderlund 2017-12-08 12:58 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 03/28] rcar-vin: unregister video device on driver removal Niklas Söderlund 2017-12-08 7:54 ` Laurent Pinchart 2017-12-08 8:46 ` Hans Verkuil 2017-12-08 8:49 ` Laurent Pinchart 2017-12-08 13:09 ` Niklas Söderlund 2017-12-08 13:09 ` Niklas Söderlund 2017-12-08 19:07 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 04/28] rcar-vin: move subdevice handling to async callbacks Niklas Söderlund 2017-12-08 8:03 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 05/28] rcar-vin: move chip information to own struct Niklas Söderlund 2017-12-08 8:08 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 06/28] rcar-vin: move max width and height information to chip information Niklas Söderlund 2017-12-08 8:10 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 07/28] rcar-vin: change name of video device Niklas Söderlund 2017-12-08 8:17 ` Laurent Pinchart 2017-12-14 14:25 ` Sakari Ailus 2017-12-14 14:25 ` Sakari Ailus 2017-12-14 15:50 ` Laurent Pinchart 2017-12-20 15:20 ` Niklas Söderlund 2017-12-20 15:20 ` Niklas Söderlund 2018-01-08 16:35 ` Laurent Pinchart 2018-01-08 16:42 ` Niklas Söderlund [this message] 2018-01-08 16:42 ` Niklas Söderlund 2018-01-08 17:48 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 08/28] rcar-vin: move functions regarding scaling Niklas Söderlund 2017-12-08 8:28 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 09/28] rcar-vin: all Gen2 boards can scale simplify logic Niklas Söderlund 2017-12-08 8:33 ` Laurent Pinchart 2017-12-20 16:17 ` Niklas Söderlund 2017-12-20 16:17 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 10/28] rcar-vin: do not reset crop and compose when setting format Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 11/28] rcar-vin: do not allow changing scaling and composing while streaming Niklas Söderlund 2017-12-08 9:04 ` Laurent Pinchart 2017-12-08 14:14 ` Niklas Söderlund 2017-12-08 14:14 ` Niklas Söderlund 2017-12-08 19:20 ` Laurent Pinchart 2017-12-20 16:26 ` Niklas Söderlund 2017-12-20 16:26 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 12/28] rcar-vin: read subdevice format for crop only when needed Niklas Söderlund 2017-12-08 9:11 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 13/28] rcar-vin: fix handling of single field frames (top, bottom and alternate fields) Niklas Söderlund 2017-12-08 9:35 ` Laurent Pinchart 2017-12-08 14:06 ` Niklas Söderlund 2017-12-08 14:06 ` Niklas Söderlund 2017-12-08 19:30 ` Laurent Pinchart 2017-12-20 17:17 ` Niklas Söderlund 2017-12-20 17:17 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 14/28] rcar-vin: move media bus configuration to struct rvin_info Niklas Söderlund 2017-12-08 9:40 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 15/28] rcar-vin: enable Gen3 hardware configuration Niklas Söderlund 2017-12-08 9:47 ` Laurent Pinchart 2017-12-20 21:09 ` Niklas Söderlund 2017-12-20 21:09 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 16/28] rcar-vin: add function to manipulate Gen3 chsel value Niklas Söderlund 2017-12-08 9:52 ` Laurent Pinchart 2017-12-20 21:20 ` Niklas Söderlund 2017-12-20 21:20 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 17/28] rcar-vin: add flag to switch to media controller mode Niklas Söderlund 2017-12-08 9:52 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 18/28] rcar-vin: break out format alignment and checking Niklas Söderlund 2017-12-08 10:01 ` Laurent Pinchart 2017-12-21 0:25 ` Niklas Söderlund 2017-12-21 0:25 ` Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode Niklas Söderlund 2017-12-08 10:14 ` Laurent Pinchart 2017-12-08 10:24 ` Hans Verkuil 2017-12-08 19:31 ` Laurent Pinchart 2018-01-19 0:46 ` Niklas Söderlund 2018-01-19 0:46 ` Niklas Söderlund 2018-03-02 11:33 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 20/28] rcar-vin: prepare for media controller mode initialization Niklas Söderlund 2017-12-08 10:20 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 21/28] rcar-vin: add group allocator functions Niklas Söderlund 2017-12-08 20:12 ` Laurent Pinchart 2018-01-08 17:24 ` Niklas Söderlund 2018-01-08 17:24 ` Niklas Söderlund 2018-01-08 17:57 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 22/28] rcar-vin: add chsel information to rvin_info Niklas Söderlund 2017-12-08 20:37 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 23/28] rcar-vin: parse Gen3 OF and setup media graph Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 24/28] rcar-vin: add link notify for Gen3 Niklas Söderlund 2017-12-08 1:08 ` [PATCH v9 25/28] rcar-vin: extend {start,stop}_streaming to work with media controller Niklas Söderlund 2017-12-08 20:45 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 26/28] rcar-vin: enable support for r8a7795 Niklas Söderlund 2017-12-08 10:21 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 27/28] rcar-vin: enable support for r8a7796 Niklas Söderlund 2017-12-08 10:25 ` Laurent Pinchart 2017-12-08 1:08 ` [PATCH v9 28/28] rcar-vin: enable support for r8a77970 Niklas Söderlund
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180108164205.GC23075@bigcity.dyn.berto.se \ --to=niklas.soderlund@ragnatech.se \ --cc=hverkuil@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=sakari.ailus@iki.fi \ --cc=tomoharu.fukawa.eb@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.