Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Don Brace <don.brace@microsemi.com>,
	alsa-devel@alsa-project.org, Rich Felker <dalias@libc.org>,
	linux-sh@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Sebastian Ott <sebott@linux.vnet.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-nvme@lists.infradead.org,
	James Smart <james.smart@broadcom.com>,
	Keith Busch <keith.busch@intel.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Christoph Hellwig <hch@lst.de>,
	devel@driverdev.osuosl.org, linux-s390@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	esc.storagedev@microsemi.com,
	Russell King <linux@armlinux.org.uk>,
	linux-acpi@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
	Len Brown <lenb@kernel.org>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	Corey Minyard <minyard@acm.or>
Subject: Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO
Date: Tue, 9 Jan 2018 16:34:16 +0100	[thread overview]
Message-ID: <20180109153416.GA7780@kroah.com> (raw)
In-Reply-To: <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk>

On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote:
> Hi Joe,
> 
> On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote:
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > index a1c81c12718c..4338b8a1309f 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > @@ -158,10 +158,10 @@ static ssize_t dynamic_pool_show(struct device *dev,
> >  	return ret;
> >  };
> >  
> > -static DEVICE_ATTR(active_bo, 0444, active_bo_show, NULL);
> > -static DEVICE_ATTR(free_bo, 0444, free_bo_show, NULL);
> > -static DEVICE_ATTR(reserved_pool, 0444, reserved_pool_show, NULL);
> > -static DEVICE_ATTR(dynamic_pool, 0444, dynamic_pool_show, NULL);
> > +static DEVICE_ATTR_RO(active_bo);
> > +static DEVICE_ATTR_RO(free_bo);
> > +static DEVICE_ATTR_RO(reserved_pool);
> > +static DEVICE_ATTR_RO(dynamic_pool);
> >  
> >  static struct attribute *sysfs_attrs_ctrl[] = {
> >  	&dev_attr_active_bo.attr,
> 
> I have the exact same changes queued up in my tree. As there seem to be no
> dependencies to other patches in your set, how about dropping this chunk?

I've now dropped it, thanks.

greg k-h
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx