All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: "Konrad Rzeszutek Wilk" <konrad@darnok.org>,
	"Michal Simek" <monstr@monstr.eu>,
	"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
	linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org,
	x86@kernel.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Christian König" <christian.koenig@amd.com>,
	stable@vger.kernel.org
Subject: [PATCH 01/22] swiotlb: suppress warning when __GFP_NOWARN is set
Date: Wed, 10 Jan 2018 09:09:11 +0100	[thread overview]
Message-ID: <20180110080932.14157-2-hch@lst.de> (raw)
In-Reply-To: <20180110080932.14157-1-hch@lst.de>

From: Christian König <ckoenig.leichtzumerken@gmail.com>

TTM tries to allocate coherent memory in chunks of 2MB first to improve
TLB efficiency and falls back to allocating 4K pages if that fails.

Suppress the warning when the 2MB allocations fails since there is a
valid fall back path.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reported-by: Mike Galbraith <efault@gmx.de>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=104082
CC: stable@vger.kernel.org
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/swiotlb.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 6583f3512386..125c1062119f 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -586,7 +586,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
 
 not_found:
 	spin_unlock_irqrestore(&io_tlb_lock, flags);
-	if (printk_ratelimit())
+	if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit())
 		dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", size);
 	return SWIOTLB_MAP_ERROR;
 found:
@@ -713,6 +713,7 @@ void *
 swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 		       dma_addr_t *dma_handle, gfp_t flags)
 {
+	bool warn = !(flags & __GFP_NOWARN);
 	dma_addr_t dev_addr;
 	void *ret;
 	int order = get_order(size);
@@ -738,8 +739,8 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 		 * GFP_DMA memory; fall back on map_single(), which
 		 * will grab memory from the lowest available address range.
 		 */
-		phys_addr_t paddr = map_single(hwdev, 0, size,
-					       DMA_FROM_DEVICE, 0);
+		phys_addr_t paddr = map_single(hwdev, 0, size, DMA_FROM_DEVICE,
+					       warn ? 0 : DMA_ATTR_NO_WARN);
 		if (paddr == SWIOTLB_MAP_ERROR)
 			goto err_warn;
 
@@ -769,9 +770,11 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	return ret;
 
 err_warn:
-	pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
-		dev_name(hwdev), size);
-	dump_stack();
+	if (warn && printk_ratelimit()) {
+		pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
+			dev_name(hwdev), size);
+		dump_stack();
+	}
 
 	return NULL;
 }
-- 
2.14.2

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/22] swiotlb: suppress warning when __GFP_NOWARN is set
Date: Wed, 10 Jan 2018 09:09:11 +0100	[thread overview]
Message-ID: <20180110080932.14157-2-hch@lst.de> (raw)
In-Reply-To: <20180110080932.14157-1-hch@lst.de>

From: Christian K?nig <ckoenig.leichtzumerken@gmail.com>

TTM tries to allocate coherent memory in chunks of 2MB first to improve
TLB efficiency and falls back to allocating 4K pages if that fails.

Suppress the warning when the 2MB allocations fails since there is a
valid fall back path.

Signed-off-by: Christian K?nig <christian.koenig@amd.com>
Reported-by: Mike Galbraith <efault@gmx.de>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=104082
CC: stable at vger.kernel.org
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/swiotlb.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 6583f3512386..125c1062119f 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -586,7 +586,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
 
 not_found:
 	spin_unlock_irqrestore(&io_tlb_lock, flags);
-	if (printk_ratelimit())
+	if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit())
 		dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", size);
 	return SWIOTLB_MAP_ERROR;
 found:
@@ -713,6 +713,7 @@ void *
 swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 		       dma_addr_t *dma_handle, gfp_t flags)
 {
+	bool warn = !(flags & __GFP_NOWARN);
 	dma_addr_t dev_addr;
 	void *ret;
 	int order = get_order(size);
@@ -738,8 +739,8 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 		 * GFP_DMA memory; fall back on map_single(), which
 		 * will grab memory from the lowest available address range.
 		 */
-		phys_addr_t paddr = map_single(hwdev, 0, size,
-					       DMA_FROM_DEVICE, 0);
+		phys_addr_t paddr = map_single(hwdev, 0, size, DMA_FROM_DEVICE,
+					       warn ? 0 : DMA_ATTR_NO_WARN);
 		if (paddr == SWIOTLB_MAP_ERROR)
 			goto err_warn;
 
@@ -769,9 +770,11 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	return ret;
 
 err_warn:
-	pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
-		dev_name(hwdev), size);
-	dump_stack();
+	if (warn && printk_ratelimit()) {
+		pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
+			dev_name(hwdev), size);
+		dump_stack();
+	}
 
 	return NULL;
 }
-- 
2.14.2

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: "Konrad Rzeszutek Wilk" <konrad@darnok.org>,
	"Michal Simek" <monstr@monstr.eu>,
	"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
	linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org,
	x86@kernel.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Christian König" <christian.koenig@amd.com>,
	stable@vger.kernel.org
Subject: [PATCH 01/22] swiotlb: suppress warning when __GFP_NOWARN is set
Date: Wed, 10 Jan 2018 08:09:11 +0000	[thread overview]
Message-ID: <20180110080932.14157-2-hch@lst.de> (raw)
In-Reply-To: <20180110080932.14157-1-hch@lst.de>

From: Christian König <ckoenig.leichtzumerken@gmail.com>

TTM tries to allocate coherent memory in chunks of 2MB first to improve
TLB efficiency and falls back to allocating 4K pages if that fails.

Suppress the warning when the 2MB allocations fails since there is a
valid fall back path.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reported-by: Mike Galbraith <efault@gmx.de>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id\x104082
CC: stable@vger.kernel.org
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/swiotlb.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 6583f3512386..125c1062119f 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -586,7 +586,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
 
 not_found:
 	spin_unlock_irqrestore(&io_tlb_lock, flags);
-	if (printk_ratelimit())
+	if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit())
 		dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", size);
 	return SWIOTLB_MAP_ERROR;
 found:
@@ -713,6 +713,7 @@ void *
 swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 		       dma_addr_t *dma_handle, gfp_t flags)
 {
+	bool warn = !(flags & __GFP_NOWARN);
 	dma_addr_t dev_addr;
 	void *ret;
 	int order = get_order(size);
@@ -738,8 +739,8 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 		 * GFP_DMA memory; fall back on map_single(), which
 		 * will grab memory from the lowest available address range.
 		 */
-		phys_addr_t paddr = map_single(hwdev, 0, size,
-					       DMA_FROM_DEVICE, 0);
+		phys_addr_t paddr = map_single(hwdev, 0, size, DMA_FROM_DEVICE,
+					       warn ? 0 : DMA_ATTR_NO_WARN);
 		if (paddr = SWIOTLB_MAP_ERROR)
 			goto err_warn;
 
@@ -769,9 +770,11 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 	return ret;
 
 err_warn:
-	pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
-		dev_name(hwdev), size);
-	dump_stack();
+	if (warn && printk_ratelimit()) {
+		pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
+			dev_name(hwdev), size);
+		dump_stack();
+	}
 
 	return NULL;
 }
-- 
2.14.2


  reply	other threads:[~2018-01-10  8:09 UTC|newest]

Thread overview: 143+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10  8:09 consolidate swiotlb dma_map implementations Christoph Hellwig
2018-01-10  8:09 ` Christoph Hellwig
2018-01-10  8:09 ` Christoph Hellwig
2018-01-10  8:09 ` Christoph Hellwig
2018-01-10  8:09 ` Christoph Hellwig [this message]
2018-01-10  8:09   ` [PATCH 01/22] swiotlb: suppress warning when __GFP_NOWARN is set Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 02/22] arm64: rename swiotlb_dma_ops Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10 12:13   ` Robin Murphy
2018-01-10 12:13     ` Robin Murphy
2018-01-10 12:13     ` Robin Murphy
2018-01-10  8:09 ` [PATCH 03/22] ia64: " Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-12 13:24   ` Konrad Rzeszutek Wilk
2018-01-12 13:24     ` Konrad Rzeszutek Wilk
2018-01-12 13:24     ` Konrad Rzeszutek Wilk
2018-01-10  8:09 ` [PATCH 04/22] powerpc: " Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-12 13:25   ` Konrad Rzeszutek Wilk
2018-01-12 13:25     ` Konrad Rzeszutek Wilk
2018-01-12 13:25     ` Konrad Rzeszutek Wilk
2018-01-10  8:09 ` [PATCH 05/22] x86: " Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-12 13:25   ` Konrad Rzeszutek Wilk
2018-01-12 13:25     ` Konrad Rzeszutek Wilk
2018-01-12 13:25     ` Konrad Rzeszutek Wilk
2018-01-12 13:25     ` Konrad Rzeszutek Wilk
2018-01-10  8:09 ` [PATCH 06/22] swiotlb: rename swiotlb_free to swiotlb_exit Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-12 13:39   ` Konrad Rzeszutek Wilk
2018-01-12 13:39     ` Konrad Rzeszutek Wilk
2018-01-12 13:39     ` Konrad Rzeszutek Wilk
2018-01-10  8:09 ` [PATCH 07/22] swiotlb: add common swiotlb_map_ops Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 08/22] swiotlb: wire up ->dma_supported in swiotlb_dma_ops Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10 12:16   ` Robin Murphy
2018-01-10 12:16     ` Robin Murphy
2018-01-10 15:35     ` Christoph Hellwig
2018-01-10 15:35       ` Christoph Hellwig
2018-01-10 15:35       ` Christoph Hellwig
2018-01-10 17:23       ` Robin Murphy
2018-01-10 17:23         ` Robin Murphy
2018-01-10 17:23         ` Robin Murphy
2018-01-10  8:09 ` [PATCH 09/22] swiotlb: refactor coherent buffer freeing Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 10/22] swiotlb: refactor coherent buffer allocation Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10 12:22   ` Robin Murphy
2018-01-10 12:22     ` Robin Murphy
2018-01-10 12:22     ` Robin Murphy
2018-01-10 15:46     ` Christoph Hellwig
2018-01-10 15:46       ` Christoph Hellwig
2018-01-10 15:46       ` Christoph Hellwig
2018-01-10 17:02       ` Robin Murphy
2018-01-10 17:02         ` Robin Murphy
2018-01-10 17:02         ` Robin Murphy
2018-01-15  9:10         ` Christoph Hellwig
2018-01-15  9:10           ` Christoph Hellwig
2018-01-15  9:10           ` Christoph Hellwig
2018-01-15  9:10           ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 11/22] swiotlb: remove various exports Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 12/22] ia64: replace ZONE_DMA with ZONE_DMA32 Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 13/22] ia64: use generic swiotlb_ops Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 14/22] ia64: clean up swiotlb support Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 15/22] ia64: remove an ifdef around the content of pci-dma.c Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 16/22] unicore32: use generic swiotlb_ops Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 17/22] tile: replace ZONE_DMA with ZONE_DMA32 Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 18/22] tile: use generic swiotlb_ops Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 19/22] mips/netlogic: remove swiotlb support Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 20/22] mips: use swiotlb_{alloc,free} Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09 ` [PATCH 21/22] arm64: replace ZONE_DMA with ZONE_DMA32 Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10 12:58   ` Robin Murphy
2018-01-10 12:58     ` Robin Murphy
2018-01-10 12:58     ` Robin Murphy
2018-01-10 15:55     ` Christoph Hellwig
2018-01-10 15:55       ` Christoph Hellwig
2018-01-10 15:55       ` Christoph Hellwig
2018-01-10 15:55       ` Christoph Hellwig
2018-01-10 15:55         ` Christoph Hellwig
2018-01-10 15:55         ` Christoph Hellwig
2018-01-10 15:55         ` Christoph Hellwig
2018-01-10 17:10         ` Robin Murphy
2018-01-10 17:10           ` Robin Murphy
2018-01-10 17:10           ` Robin Murphy
2018-01-10  8:09 ` [PATCH 22/22] arm64: use swiotlb_alloc and swiotlb_free Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10  8:09   ` Christoph Hellwig
2018-01-10 13:16   ` Robin Murphy
2018-01-10 13:16     ` Robin Murphy
2018-01-10  8:23 ` consolidate swiotlb dma_map implementations Christian König
2018-01-10  8:23   ` Christian König
2018-01-10  8:23   ` Christian König
2018-01-16  7:53 ` Christoph Hellwig
2018-01-16  7:53   ` Christoph Hellwig
2018-01-16  7:53   ` Christoph Hellwig
2018-01-16  7:53   ` Christoph Hellwig
2018-01-16  8:22   ` Christian König
2018-01-16  8:22     ` Christian König
2018-01-16  8:22     ` Christian König
2018-01-16  8:28     ` Christoph Hellwig
2018-01-16  8:28       ` Christoph Hellwig
2018-01-16  8:52       ` Christian König
2018-01-16  8:52         ` Christian König
2018-01-16  8:52         ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110080932.14157-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=christian.koenig@amd.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=iommu@lists.linux-foundation.org \
    --cc=konrad@darnok.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=monstr@monstr.eu \
    --cc=stable@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.