All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"
@ 2018-01-10  9:20 ` Colin King
  0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-01-10  9:20 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, netdev; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to spelling mistake in error message text.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 kernel/bpf/verifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 97bbef3eecdf..e388f30c4168 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -5336,7 +5336,7 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env)
 			 */
 			map_ptr = env->insn_aux_data[i + delta].map_ptr;
 			if (map_ptr == BPF_MAP_PTR_POISON) {
-				verbose(env, "tail_call obusing map_ptr\n");
+				verbose(env, "tail_call abusing map_ptr\n");
 				return -EINVAL;
 			}
 			if (!map_ptr->unpriv_array)
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"
@ 2018-01-10  9:20 ` Colin King
  0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-01-10  9:20 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, netdev; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to spelling mistake in error message text.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 kernel/bpf/verifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 97bbef3eecdf..e388f30c4168 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -5336,7 +5336,7 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env)
 			 */
 			map_ptr = env->insn_aux_data[i + delta].map_ptr;
 			if (map_ptr = BPF_MAP_PTR_POISON) {
-				verbose(env, "tail_call obusing map_ptr\n");
+				verbose(env, "tail_call abusing map_ptr\n");
 				return -EINVAL;
 			}
 			if (!map_ptr->unpriv_array)
-- 
2.15.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"
  2018-01-10  9:20 ` Colin King
@ 2018-01-10 10:39   ` Daniel Borkmann
  -1 siblings, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2018-01-10 10:39 UTC (permalink / raw)
  To: Colin King, Alexei Starovoitov, netdev; +Cc: kernel-janitors, linux-kernel

On 01/10/2018 10:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in error message text.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  kernel/bpf/verifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 97bbef3eecdf..e388f30c4168 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -5336,7 +5336,7 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env)
>  			 */
>  			map_ptr = env->insn_aux_data[i + delta].map_ptr;
>  			if (map_ptr == BPF_MAP_PTR_POISON) {
> -				verbose(env, "tail_call obusing map_ptr\n");
> +				verbose(env, "tail_call abusing map_ptr\n");
>  				return -EINVAL;
>  			}
>  			if (!map_ptr->unpriv_array)
> 

This is not in bpf-next tree yet, but only in bpf tree. I will let this sit
for a bit in patchwork until bpf-next has all the stuff from bpf merged back,
and then apply it into bpf-next.

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"
@ 2018-01-10 10:39   ` Daniel Borkmann
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2018-01-10 10:39 UTC (permalink / raw)
  To: Colin King, Alexei Starovoitov, netdev; +Cc: kernel-janitors, linux-kernel

On 01/10/2018 10:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in error message text.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  kernel/bpf/verifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 97bbef3eecdf..e388f30c4168 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -5336,7 +5336,7 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env)
>  			 */
>  			map_ptr = env->insn_aux_data[i + delta].map_ptr;
>  			if (map_ptr = BPF_MAP_PTR_POISON) {
> -				verbose(env, "tail_call obusing map_ptr\n");
> +				verbose(env, "tail_call abusing map_ptr\n");
>  				return -EINVAL;
>  			}
>  			if (!map_ptr->unpriv_array)
> 

This is not in bpf-next tree yet, but only in bpf tree. I will let this sit
for a bit in patchwork until bpf-next has all the stuff from bpf merged back,
and then apply it into bpf-next.

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"
  2018-01-10 10:39   ` Daniel Borkmann
@ 2018-01-10 22:56     ` Alexei Starovoitov
  -1 siblings, 0 replies; 6+ messages in thread
From: Alexei Starovoitov @ 2018-01-10 22:56 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Colin King, Alexei Starovoitov, netdev, kernel-janitors, linux-kernel

On Wed, Jan 10, 2018 at 11:39:14AM +0100, Daniel Borkmann wrote:
> On 01/10/2018 10:20 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Trivial fix to spelling mistake in error message text.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  kernel/bpf/verifier.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 97bbef3eecdf..e388f30c4168 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -5336,7 +5336,7 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env)
> >  			 */
> >  			map_ptr = env->insn_aux_data[i + delta].map_ptr;
> >  			if (map_ptr == BPF_MAP_PTR_POISON) {
> > -				verbose(env, "tail_call obusing map_ptr\n");
> > +				verbose(env, "tail_call abusing map_ptr\n");
> >  				return -EINVAL;
> >  			}
> >  			if (!map_ptr->unpriv_array)
> > 
> 
> This is not in bpf-next tree yet, but only in bpf tree. I will let this sit
> for a bit in patchwork until bpf-next has all the stuff from bpf merged back,
> and then apply it into bpf-next.

since the typo was just introduced in bpf tree it's better to fix it right away.
Applied, Thanks Colin.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing"
@ 2018-01-10 22:56     ` Alexei Starovoitov
  0 siblings, 0 replies; 6+ messages in thread
From: Alexei Starovoitov @ 2018-01-10 22:56 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Colin King, Alexei Starovoitov, netdev, kernel-janitors, linux-kernel

On Wed, Jan 10, 2018 at 11:39:14AM +0100, Daniel Borkmann wrote:
> On 01/10/2018 10:20 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Trivial fix to spelling mistake in error message text.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  kernel/bpf/verifier.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 97bbef3eecdf..e388f30c4168 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -5336,7 +5336,7 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env)
> >  			 */
> >  			map_ptr = env->insn_aux_data[i + delta].map_ptr;
> >  			if (map_ptr = BPF_MAP_PTR_POISON) {
> > -				verbose(env, "tail_call obusing map_ptr\n");
> > +				verbose(env, "tail_call abusing map_ptr\n");
> >  				return -EINVAL;
> >  			}
> >  			if (!map_ptr->unpriv_array)
> > 
> 
> This is not in bpf-next tree yet, but only in bpf tree. I will let this sit
> for a bit in patchwork until bpf-next has all the stuff from bpf merged back,
> and then apply it into bpf-next.

since the typo was just introduced in bpf tree it's better to fix it right away.
Applied, Thanks Colin.


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-10 22:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10  9:20 [PATCH][bpf-next] bpf: fix spelling mistake: "obusing" -> "abusing" Colin King
2018-01-10  9:20 ` Colin King
2018-01-10 10:39 ` Daniel Borkmann
2018-01-10 10:39   ` Daniel Borkmann
2018-01-10 22:56   ` Alexei Starovoitov
2018-01-10 22:56     ` Alexei Starovoitov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.