All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: joel@jms.id.au, andrew@aj.id.au, arnd@arndb.de,
	jdelvare@suse.com, linux@roeck-us.net,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers
Date: Wed, 10 Jan 2018 11:18:40 +0100	[thread overview]
Message-ID: <20180110101840.GB5822@kroah.com> (raw)
In-Reply-To: <20180109223126.13093-4-jae.hyun.yoo@linux.intel.com>

On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote:
> This commit adds driver implementation for Aspeed PECI. Also adds
> generic peci.h and peci_ioctl.h files to provide compatibility
> to peci drivers that can be implemented later e.g. Nuvoton's BMC
> SoC family.

We don't add code that could be used "sometime in the future".  Only
include stuff that we use now.

Please fix up this series based on that and resubmit.  There should not
be any need for any uapi file then, right?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	jdelvare@suse.com, arnd@arndb.de, linux-doc@vger.kernel.org,
	andrew@aj.id.au, openbmc@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, joel@jms.id.au, linux@roeck-us.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers
Date: Wed, 10 Jan 2018 11:18:40 +0100	[thread overview]
Message-ID: <20180110101840.GB5822@kroah.com> (raw)
In-Reply-To: <20180109223126.13093-4-jae.hyun.yoo@linux.intel.com>

On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote:
> This commit adds driver implementation for Aspeed PECI. Also adds
> generic peci.h and peci_ioctl.h files to provide compatibility
> to peci drivers that can be implemented later e.g. Nuvoton's BMC
> SoC family.

We don't add code that could be used "sometime in the future".  Only
include stuff that we use now.

Please fix up this series based on that and resubmit.  There should not
be any need for any uapi file then, right?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers
Date: Wed, 10 Jan 2018 11:18:40 +0100	[thread overview]
Message-ID: <20180110101840.GB5822@kroah.com> (raw)
In-Reply-To: <20180109223126.13093-4-jae.hyun.yoo@linux.intel.com>

On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote:
> This commit adds driver implementation for Aspeed PECI. Also adds
> generic peci.h and peci_ioctl.h files to provide compatibility
> to peci drivers that can be implemented later e.g. Nuvoton's BMC
> SoC family.

We don't add code that could be used "sometime in the future".  Only
include stuff that we use now.

Please fix up this series based on that and resubmit.  There should not
be any need for any uapi file then, right?

thanks,

greg k-h

  reply	other threads:[~2018-01-10 10:18 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 22:31 [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 1/6] Documentation: dt-bindings: Add Aspeed PECI Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 2/6] ARM: dts: aspeed: peci: " Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-10 10:18   ` Greg KH [this message]
2018-01-10 10:18     ` Greg KH
2018-01-10 10:18     ` Greg KH
2018-01-10 19:32     ` Jae Hyun Yoo
2018-01-10 19:32       ` Jae Hyun Yoo
2018-01-11  9:02     ` Benjamin Herrenschmidt
2018-01-11  9:02       ` Benjamin Herrenschmidt
2018-01-11  9:02       ` Benjamin Herrenschmidt
2018-01-11 20:33       ` Jae Hyun Yoo
2018-01-11 20:33         ` Jae Hyun Yoo
2018-01-10 10:20   ` Greg KH
2018-01-10 10:20     ` Greg KH
2018-01-10 10:20     ` Greg KH
2018-01-10 19:34     ` Jae Hyun Yoo
2018-01-10 19:34       ` Jae Hyun Yoo
2018-01-10 11:55   ` Arnd Bergmann
2018-01-10 11:55     ` Arnd Bergmann
2018-01-10 11:55     ` Arnd Bergmann
2018-01-10 23:11     ` Jae Hyun Yoo
2018-01-10 23:11       ` Jae Hyun Yoo
2018-01-11  9:06   ` Benjamin Herrenschmidt
2018-01-11  9:06     ` Benjamin Herrenschmidt
2018-01-11  9:06     ` Benjamin Herrenschmidt
2018-01-11 20:42     ` Jae Hyun Yoo
2018-01-11 20:42       ` Jae Hyun Yoo
2018-01-11 20:42       ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-10 12:20   ` Arnd Bergmann
2018-01-10 12:20     ` Arnd Bergmann
2018-01-10 12:20     ` Arnd Bergmann
2018-01-10 23:20     ` Jae Hyun Yoo
2018-01-10 23:20       ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 5/6] Documentation: hwmon: " Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for " Jae Hyun Yoo
2018-01-09 22:31   ` Jae Hyun Yoo
2018-01-10 12:29   ` Arnd Bergmann
2018-01-10 12:29     ` Arnd Bergmann
2018-01-10 12:29     ` Arnd Bergmann
2018-01-10 23:45     ` Jae Hyun Yoo
2018-01-10 23:45       ` Jae Hyun Yoo
2018-01-11 13:22       ` Arnd Bergmann
2018-01-11 13:22         ` Arnd Bergmann
2018-01-11 13:22         ` Arnd Bergmann
2018-01-11 20:49         ` Jae Hyun Yoo
2018-01-11 20:49           ` Jae Hyun Yoo
2018-01-10 21:47   ` [linux, dev-4.10, " Guenter Roeck
2018-01-10 21:47     ` Guenter Roeck
2018-01-11 19:47     ` Jae Hyun Yoo
2018-01-11 19:47       ` Jae Hyun Yoo
2018-01-11 19:47       ` Jae Hyun Yoo
2018-01-11 21:40       ` Guenter Roeck
2018-01-11 21:40         ` Guenter Roeck
2018-01-11 22:18         ` Andrew Lunn
2018-01-11 22:18           ` Andrew Lunn
2018-01-11 22:18           ` Andrew Lunn
2018-01-11 23:14           ` Jae Hyun Yoo
2018-01-11 23:14             ` Jae Hyun Yoo
2018-01-11 23:53             ` Andrew Lunn
2018-01-11 23:53               ` Andrew Lunn
2018-01-12  0:26               ` Jae Hyun Yoo
2018-01-12  0:26                 ` Jae Hyun Yoo
2018-01-11 23:03         ` Jae Hyun Yoo
2018-01-11 23:03           ` Jae Hyun Yoo
2018-01-11 23:03           ` Jae Hyun Yoo
2018-01-10 10:17 ` [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers Greg KH
2018-01-10 10:17   ` Greg KH
2018-01-10 10:17   ` Greg KH
2018-01-10 19:14   ` Jae Hyun Yoo
2018-01-10 19:14     ` Jae Hyun Yoo
2018-01-10 19:17     ` Greg KH
2018-01-10 19:17       ` Greg KH
2018-01-10 19:17       ` Greg KH
2018-01-10 19:30       ` Jae Hyun Yoo
2018-01-10 19:30         ` Jae Hyun Yoo
2018-01-10 20:27         ` Greg KH
2018-01-10 20:27           ` Greg KH
2018-01-10 20:27           ` Greg KH
2018-01-10 21:46           ` Jae Hyun Yoo
2018-01-10 21:46             ` Jae Hyun Yoo
2018-01-10 21:46             ` Jae Hyun Yoo
2018-01-11  7:30             ` Greg KH
2018-01-11  7:30               ` Greg KH
2018-01-11  8:28               ` Joel Stanley
2018-01-11  8:28                 ` Joel Stanley
2018-01-11  8:28                 ` Joel Stanley
2018-01-11  8:41                 ` Greg KH
2018-01-11  8:41                   ` Greg KH
2018-01-11  8:41                   ` Greg KH
2018-01-11  9:17                   ` Arnd Bergmann
2018-01-11  9:17                     ` Arnd Bergmann
2018-01-11  9:17                     ` Arnd Bergmann
2018-01-11  9:17                     ` Arnd Bergmann
2018-01-11  9:21                   ` Benjamin Herrenschmidt
2018-01-11  9:21                     ` Benjamin Herrenschmidt
2018-01-11  9:21                     ` Benjamin Herrenschmidt
2018-01-11  8:56               ` Benjamin Herrenschmidt
2018-01-11  8:56                 ` Benjamin Herrenschmidt
2018-01-11  9:59                 ` Greg KH
2018-01-11  9:59                   ` Greg KH
2018-01-11  9:59                   ` Greg KH
2018-01-11 20:49                   ` Benjamin Herrenschmidt
2018-01-11 20:49                     ` Benjamin Herrenschmidt
2018-01-11 20:49                     ` Benjamin Herrenschmidt
2018-01-11 19:54                 ` Jae Hyun Yoo
2018-01-11 19:54                   ` Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110101840.GB5822@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andrew@aj.id.au \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jae.hyun.yoo@linux.intel.com \
    --cc=jdelvare@suse.com \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.