All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	kernel-janitors@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] soundwire: Testing the wrong variable
Date: Wed, 10 Jan 2018 12:25:44 +0000	[thread overview]
Message-ID: <20180110122544.jihugwmbjr4qphf4@mwanda> (raw)
In-Reply-To: <20180110105544.GZ18649@localhost>

On Wed, Jan 10, 2018 at 04:25:44PM +0530, Vinod Koul wrote:
> On Tue, Jan 09, 2018 at 12:37:44PM +0300, Dan Carpenter wrote:
> > We should be using "status2" here instead of "status".
> 
> This is already fixed by commit:
> 
> Author: Wei Yongjun <weiyongjun1@huawei.com>
> Date:   Mon Jan 8 22:22:44 2018 +0530
> 
>     soundwire: Fix typo in return value check of sdw_read()
> 
>     Fix the typo, 'status' should be instead of 'status2'.
> 


Hi Wei,

It looks like you're fixing static checker warnings?  Could you CC
kernel-janitors@vger.kernel.org for those fixes?  Otherwise we end up
sending duplicates a lot.

Colin King, Julia Lawall, Christophe JAILLET, and I all CC our static
checker fixes to kernel-janitors.  I still end up sending duplicates
sometimes...  Which is fine.

regards,
dan carpenter



WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	kernel-janitors@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] soundwire: Testing the wrong variable
Date: Wed, 10 Jan 2018 15:25:44 +0300	[thread overview]
Message-ID: <20180110122544.jihugwmbjr4qphf4@mwanda> (raw)
In-Reply-To: <20180110105544.GZ18649@localhost>

On Wed, Jan 10, 2018 at 04:25:44PM +0530, Vinod Koul wrote:
> On Tue, Jan 09, 2018 at 12:37:44PM +0300, Dan Carpenter wrote:
> > We should be using "status2" here instead of "status".
> 
> This is already fixed by commit:
> 
> Author: Wei Yongjun <weiyongjun1@huawei.com>
> Date:   Mon Jan 8 22:22:44 2018 +0530
> 
>     soundwire: Fix typo in return value check of sdw_read()
> 
>     Fix the typo, 'status' should be instead of 'status2'.
> 


Hi Wei,

It looks like you're fixing static checker warnings?  Could you CC
kernel-janitors@vger.kernel.org for those fixes?  Otherwise we end up
sending duplicates a lot.

Colin King, Julia Lawall, Christophe JAILLET, and I all CC our static
checker fixes to kernel-janitors.  I still end up sending duplicates
sometimes...  Which is fine.

regards,
dan carpenter

  reply	other threads:[~2018-01-10 12:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09  9:37 [PATCH 1/2] soundwire: Fix a signedness bug Dan Carpenter
2018-01-09  9:37 ` Dan Carpenter
2018-01-09  9:37 ` [PATCH 2/2] soundwire: Testing the wrong variable Dan Carpenter
2018-01-09  9:37   ` Dan Carpenter
2018-01-10 10:51   ` Vinod Koul
2018-01-10 10:55     ` Vinod Koul
2018-01-10 12:25     ` Dan Carpenter [this message]
2018-01-10 12:25       ` Dan Carpenter
2018-01-10 12:45       ` weiyongjun (A)
2018-01-10 10:50 ` [alsa-devel] [PATCH 1/2] soundwire: Fix a signedness bug Vinod Koul
2018-01-10 10:54   ` Vinod Koul
2018-01-10 12:29   ` [PATCH v2] " Dan Carpenter
2018-01-10 12:29     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110122544.jihugwmbjr4qphf4@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=vinod.koul@intel.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.