* [PATCH] bdi: show error log when fail to create bdi debugfs entry
@ 2018-01-10 15:18 weiping zhang
2018-01-10 16:10 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: weiping zhang @ 2018-01-10 15:18 UTC (permalink / raw)
To: axboe, jack; +Cc: linux-block
bdi debugfs dir/file may create fail, add error log here.
Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
---
mm/backing-dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index b5f940c..9117c21 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -885,7 +885,8 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
cgwb_bdi_register(bdi);
bdi->dev = dev;
- bdi_debug_register(bdi, dev_name(dev));
+ if (bdi_debug_register(bdi, dev_name(dev)))
+ pr_warn("blkdev %s create bdi debugfs failed\n", dev_name(dev));
set_bit(WB_registered, &bdi->wb.state);
spin_lock_bh(&bdi_lock);
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bdi: show error log when fail to create bdi debugfs entry
2018-01-10 15:18 [PATCH] bdi: show error log when fail to create bdi debugfs entry weiping zhang
@ 2018-01-10 16:10 ` Bart Van Assche
2018-01-10 16:29 ` weiping zhang
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2018-01-10 16:10 UTC (permalink / raw)
To: zhangweiping, jack, axboe; +Cc: linux-block
T24gV2VkLCAyMDE4LTAxLTEwIGF0IDIzOjE4ICswODAwLCB3ZWlwaW5nIHpoYW5nIHdyb3RlOg0K
PiBiZGkgZGVidWdmcyBkaXIvZmlsZSBtYXkgY3JlYXRlIGZhaWwsIGFkZCBlcnJvciBsb2cgaGVy
ZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IHdlaXBpbmcgemhhbmcgPHpoYW5nd2VpcGluZ0BkaWRp
Y2h1eGluZy5jb20+DQo+IC0tLQ0KPiAgbW0vYmFja2luZy1kZXYuYyB8IDMgKystDQo+ICAxIGZp
bGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0t
Z2l0IGEvbW0vYmFja2luZy1kZXYuYyBiL21tL2JhY2tpbmctZGV2LmMNCj4gaW5kZXggYjVmOTQw
Yy4uOTExN2MyMSAxMDA2NDQNCj4gLS0tIGEvbW0vYmFja2luZy1kZXYuYw0KPiArKysgYi9tbS9i
YWNraW5nLWRldi5jDQo+IEBAIC04ODUsNyArODg1LDggQEAgaW50IGJkaV9yZWdpc3Rlcl92YShz
dHJ1Y3QgYmFja2luZ19kZXZfaW5mbyAqYmRpLCBjb25zdCBjaGFyICpmbXQsIHZhX2xpc3QgYXJn
cykNCj4gIAljZ3diX2JkaV9yZWdpc3RlcihiZGkpOw0KPiAgCWJkaS0+ZGV2ID0gZGV2Ow0KPiAg
DQo+IC0JYmRpX2RlYnVnX3JlZ2lzdGVyKGJkaSwgZGV2X25hbWUoZGV2KSk7DQo+ICsJIGlmIChi
ZGlfZGVidWdfcmVnaXN0ZXIoYmRpLCBkZXZfbmFtZShkZXYpKSkNCj4gKwkJIHByX3dhcm4oImJs
a2RldiAlcyBjcmVhdGUgYmRpIGRlYnVnZnMgZmFpbGVkXG4iLCBkZXZfbmFtZShkZXYpKTsNCj4g
IAlzZXRfYml0KFdCX3JlZ2lzdGVyZWQsICZiZGktPndiLnN0YXRlKTsNCj4gIA0KPiAgCXNwaW5f
bG9ja19iaCgmYmRpX2xvY2spOw0KDQpUaGUgaW5kZW50YXRpb24gb2YgdGhlIGlmLXN0YXRlbWVu
dCBpcyBpbmNvbnNpc3RlbnQuIEhhdmUgeW91IHZlcmlmaWVkIHRoaXMNCnBhdGNoIHdpdGggY2hl
Y2twYXRjaCBiZWZvcmUgc3VibWl0dGluZyBpdD8NCg0KQWRkaXRpb25hbGx5LCB0aGUgZXJyb3Ig
bWVzc2FnZSBpcyBoYXJkIHRvIHVuZGVyc3RhbmQuIFBsZWFzZSBtYWtlIGl0IG1vcmUgY2xlYXIs
DQplLmcuIGFzIGZvbGxvd3M6ICIlczogY3JlYXRpb24gb2YgYmRpIGRlYnVnZnMgZW50cmllcyBm
YWlsZWQuXG4iLg0KDQpUaGFua3MsDQoNCkJhcnQu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bdi: show error log when fail to create bdi debugfs entry
2018-01-10 16:10 ` Bart Van Assche
@ 2018-01-10 16:29 ` weiping zhang
0 siblings, 0 replies; 3+ messages in thread
From: weiping zhang @ 2018-01-10 16:29 UTC (permalink / raw)
To: Bart Van Assche; +Cc: zhangweiping, jack, axboe, linux-block
2018-01-11 0:10 GMT+08:00 Bart Van Assche <Bart.VanAssche@wdc.com>:
> On Wed, 2018-01-10 at 23:18 +0800, weiping zhang wrote:
>> bdi debugfs dir/file may create fail, add error log here.
>>
>> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
>> ---
>> mm/backing-dev.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
>> index b5f940c..9117c21 100644
>> --- a/mm/backing-dev.c
>> +++ b/mm/backing-dev.c
>> @@ -885,7 +885,8 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
>> cgwb_bdi_register(bdi);
>> bdi->dev = dev;
>>
>> - bdi_debug_register(bdi, dev_name(dev));
>> + if (bdi_debug_register(bdi, dev_name(dev)))
>> + pr_warn("blkdev %s create bdi debugfs failed\n", dev_name(dev));
>> set_bit(WB_registered, &bdi->wb.state);
>>
>> spin_lock_bh(&bdi_lock);
>
> The indentation of the if-statement is inconsistent. Have you verified this
> patch with checkpatch before submitting it?
>
> Additionally, the error message is hard to understand. Please make it more clear,
> e.g. as follows: "%s: creation of bdi debugfs entries failed.\n".
>
OK, fix them at V2, thanks a lot
> Thanks,
>
> Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-10 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 15:18 [PATCH] bdi: show error log when fail to create bdi debugfs entry weiping zhang
2018-01-10 16:10 ` Bart Van Assche
2018-01-10 16:29 ` weiping zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.