All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
@ 2018-01-10 16:10 ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-10 16:10 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski
  Cc: Arnd Bergmann, Rob Herring, Mark Rutland, Guenter Roeck,
	Bartlomiej Zolnierkiewicz, linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel

The ohci-hcd node has an interrupt number but no interrupt-parent,
leading to a warning with current dtc versions:

arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

As seen from the related exynos dts files, the ohci and ehci controllers
always share one interrupt number, and the number is the same here as
well, so setting the same interrupt-parent is the reasonable solution
here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/boot/dts/s5pv210.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 247c0029659c..67358562a6ea 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -460,6 +460,7 @@
 			compatible = "samsung,exynos4210-ohci";
 			reg = <0xec300000 0x100>;
 			interrupts = <23>;
+			interrupt-parent = <&vic1>;
 			clocks = <&clocks CLK_USB_HOST>;
 			clock-names = "usbhost";
 			#address-cells = <1>;
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
@ 2018-01-10 16:10 ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-10 16:10 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Arnd Bergmann,
	Bartlomiej Zolnierkiewicz, linux-kernel, Rob Herring,
	Guenter Roeck, linux-arm-kernel

The ohci-hcd node has an interrupt number but no interrupt-parent,
leading to a warning with current dtc versions:

arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000

As seen from the related exynos dts files, the ohci and ehci controllers
always share one interrupt number, and the number is the same here as
well, so setting the same interrupt-parent is the reasonable solution
here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/boot/dts/s5pv210.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 247c0029659c..67358562a6ea 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -460,6 +460,7 @@
 			compatible = "samsung,exynos4210-ohci";
 			reg = <0xec300000 0x100>;
 			interrupts = <23>;
+			interrupt-parent = <&vic1>;
 			clocks = <&clocks CLK_USB_HOST>;
 			clock-names = "usbhost";
 			#address-cells = <1>;
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
@ 2018-01-10 16:10 ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-10 16:10 UTC (permalink / raw)
  To: linux-arm-kernel

The ohci-hcd node has an interrupt number but no interrupt-parent,
leading to a warning with current dtc versions:

arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000

As seen from the related exynos dts files, the ohci and ehci controllers
always share one interrupt number, and the number is the same here as
well, so setting the same interrupt-parent is the reasonable solution
here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/boot/dts/s5pv210.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 247c0029659c..67358562a6ea 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -460,6 +460,7 @@
 			compatible = "samsung,exynos4210-ohci";
 			reg = <0xec300000 0x100>;
 			interrupts = <23>;
+			interrupt-parent = <&vic1>;
 			clocks = <&clocks CLK_USB_HOST>;
 			clock-names = "usbhost";
 			#address-cells = <1>;
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
  2018-01-10 16:10 ` Arnd Bergmann
@ 2018-01-11  8:09   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2018-01-11  8:09 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Kukjin Kim, Rob Herring, Mark Rutland, Guenter Roeck,
	Bartlomiej Zolnierkiewicz, linux-arm-kernel, linux-samsung-soc,
	devicetree, linux-kernel

On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The ohci-hcd node has an interrupt number but no interrupt-parent,
> leading to a warning with current dtc versions:
>
> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>
> As seen from the related exynos dts files, the ohci and ehci controllers
> always share one interrupt number, and the number is the same here as
> well, so setting the same interrupt-parent is the reasonable solution
> here.

Your patch is correct. However my last pull request still waits and it
is quite late in this release cycle so I will apply it for v4.17 after
this merge window. On the other hand you can take it directly (in that
case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>).

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
@ 2018-01-11  8:09   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2018-01-11  8:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The ohci-hcd node has an interrupt number but no interrupt-parent,
> leading to a warning with current dtc versions:
>
> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
>
> As seen from the related exynos dts files, the ohci and ehci controllers
> always share one interrupt number, and the number is the same here as
> well, so setting the same interrupt-parent is the reasonable solution
> here.

Your patch is correct. However my last pull request still waits and it
is quite late in this release cycle so I will apply it for v4.17 after
this merge window. On the other hand you can take it directly (in that
case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>).

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
  2018-01-11  8:09   ` Krzysztof Kozlowski
  (?)
@ 2018-01-15 13:00     ` Arnd Bergmann
  -1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-15 13:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, Rob Herring, Mark Rutland, Guenter Roeck,
	Bartlomiej Zolnierkiewicz, Linux ARM,
	moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, DTML,
	Linux Kernel Mailing List

On Thu, Jan 11, 2018 at 9:09 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The ohci-hcd node has an interrupt number but no interrupt-parent,
>> leading to a warning with current dtc versions:
>>
>> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>>
>> As seen from the related exynos dts files, the ohci and ehci controllers
>> always share one interrupt number, and the number is the same here as
>> well, so setting the same interrupt-parent is the reasonable solution
>> here.
>
> Your patch is correct. However my last pull request still waits and it
> is quite late in this release cycle so I will apply it for v4.17 after
> this merge window. On the other hand you can take it directly (in that
> case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>).

Applied to next/dt, thanks!

      Arnd

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
@ 2018-01-15 13:00     ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-15 13:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Kukjin Kim, Rob Herring, Mark Rutland, Guenter Roeck,
	Bartlomiej Zolnierkiewicz, Linux ARM,
	moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, DTML,
	Linux Kernel Mailing List

On Thu, Jan 11, 2018 at 9:09 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The ohci-hcd node has an interrupt number but no interrupt-parent,
>> leading to a warning with current dtc versions:
>>
>> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>>
>> As seen from the related exynos dts files, the ohci and ehci controllers
>> always share one interrupt number, and the number is the same here as
>> well, so setting the same interrupt-parent is the reasonable solution
>> here.
>
> Your patch is correct. However my last pull request still waits and it
> is quite late in this release cycle so I will apply it for v4.17 after
> this merge window. On the other hand you can take it directly (in that
> case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>).

Applied to next/dt, thanks!

      Arnd

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
@ 2018-01-15 13:00     ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-01-15 13:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 11, 2018 at 9:09 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The ohci-hcd node has an interrupt number but no interrupt-parent,
>> leading to a warning with current dtc versions:
>>
>> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
>> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
>> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
>> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
>> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci at ec300000
>>
>> As seen from the related exynos dts files, the ohci and ehci controllers
>> always share one interrupt number, and the number is the same here as
>> well, so setting the same interrupt-parent is the reasonable solution
>> here.
>
> Your patch is correct. However my last pull request still waits and it
> is quite late in this release cycle so I will apply it for v4.17 after
> this merge window. On the other hand you can take it directly (in that
> case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>).

Applied to next/dt, thanks!

      Arnd

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-01-15 13:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 16:10 [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci Arnd Bergmann
2018-01-10 16:10 ` Arnd Bergmann
2018-01-10 16:10 ` Arnd Bergmann
2018-01-11  8:09 ` Krzysztof Kozlowski
2018-01-11  8:09   ` Krzysztof Kozlowski
2018-01-15 13:00   ` Arnd Bergmann
2018-01-15 13:00     ` Arnd Bergmann
2018-01-15 13:00     ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.