All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] python-xlib: new package
@ 2018-01-05  0:04 Joseph Kogut
  2018-01-05  7:55 ` Yegor Yefremov
  2018-01-05 21:13 ` [Buildroot] [PATCH v2 " Joseph Kogut
  0 siblings, 2 replies; 13+ messages in thread
From: Joseph Kogut @ 2018-01-05  0:04 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
 DEVELOPERS                                      |  1 +
 package/Config.in                               |  1 +
 package/python-xlib/Config.in                   |  7 +++++++
 package/python-xlib/python-xlib.hash            |  6 ++++++
 package/python-xlib/python-xlib.mk              | 15 +++++++++++++++
 package/python-xlib/remove_setup_requires.patch | 13 +++++++++++++
 6 files changed, 43 insertions(+)
 create mode 100644 package/python-xlib/Config.in
 create mode 100644 package/python-xlib/python-xlib.hash
 create mode 100644 package/python-xlib/python-xlib.mk
 create mode 100644 package/python-xlib/remove_setup_requires.patch

diff --git a/DEVELOPERS b/DEVELOPERS
index a9a9ac5a39..999e7d3300 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -848,6 +848,7 @@ F:	package/gconf/
 F:	package/python-raven/
 F:	package/python-schedule/
 F:	package/python-websockets/
+F:	package/python-xlib/
 
 N:	Johan Derycke <johanderycke@gmail.com>
 F:	package/python-libconfig/
diff --git a/package/Config.in b/package/Config.in
index 37b1e9fe4f..729d660d52 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -941,6 +941,7 @@ menu "External python modules"
 	source "package/python-whoosh/Config.in"
 	source "package/python-ws4py/Config.in"
 	source "package/python-wsaccel/Config.in"
+	source "package/python-xlib/Config.in"
 	source "package/python-xlrd/Config.in"
 	source "package/python-xlsxwriter/Config.in"
 	source "package/python-xlutils/Config.in"
diff --git a/package/python-xlib/Config.in b/package/python-xlib/Config.in
new file mode 100644
index 0000000000..3cd83f030c
--- /dev/null
+++ b/package/python-xlib/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_XLIB
+	bool "python-xlib"
+	select BR2_PACKAGE_PYTHON_SIX
+	help
+	  XLib in pure Python (Py2/Py3 compatible)
+
+	  https://github.com/python-xlib/python-xlib
diff --git a/package/python-xlib/python-xlib.hash b/package/python-xlib/python-xlib.hash
new file mode 100644
index 0000000000..05b407209c
--- /dev/null
+++ b/package/python-xlib/python-xlib.hash
@@ -0,0 +1,6 @@
+# md5 from https://pypi.python.org/pypi/python-xlib/json, sha256 locally computed
+md5 cdf342aa145c2be0ccae46cfb7b62551 python-xlib-0.21.tar.bz2
+sha256 25aad0056172920552c01a163e979b02336abaf47b0792dae9c93ecb29500431 python-xlib-0.21.tar.bz2
+# License file, locally calculated
+sha256 5ce9459bc19ced99cc9eb135d4f559ed01e336354bdf16dd998be85aa688c233 LICENSE
+
diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
new file mode 100644
index 0000000000..ca200e6a97
--- /dev/null
+++ b/package/python-xlib/python-xlib.mk
@@ -0,0 +1,15 @@
+###############################################################################
+#
+# python-xlib
+#
+###############################################################################
+
+PYTHON_XLIB_VERSION = 0.21
+PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
+PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
+PYTHON_XLIB_SETUP_TYPE = setuptools
+PYTHON_XLIB_LICENSE = LGPL-2.0+
+PYTHON_XLIB_LICENSE_FILES = LICENSE
+PYTHON_XLIB_DEPENDENCIES = python-six
+
+$(eval $(python-package))
diff --git a/package/python-xlib/remove_setup_requires.patch b/package/python-xlib/remove_setup_requires.patch
new file mode 100644
index 0000000000..a2bb4656ac
--- /dev/null
+++ b/package/python-xlib/remove_setup_requires.patch
@@ -0,0 +1,13 @@
+diff --git a/setup.py b/setup.py
+index 9b4a47e..cac95ba 100644
+--- a/setup.py
++++ b/setup.py
+@@ -5,7 +5,6 @@ from setuptools import setup
+
+ setup(
+     install_requires=['six>=1.10.0'],
+-    setup_requires=['setuptools-scm'],
+     packages=[
+         'Xlib',
+         'Xlib.ext',
+
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] python-xlib: new package
  2018-01-05  0:04 [Buildroot] [PATCH 1/1] python-xlib: new package Joseph Kogut
@ 2018-01-05  7:55 ` Yegor Yefremov
  2018-01-05 21:13 ` [Buildroot] [PATCH v2 " Joseph Kogut
  1 sibling, 0 replies; 13+ messages in thread
From: Yegor Yefremov @ 2018-01-05  7:55 UTC (permalink / raw)
  To: buildroot

Hello Joseph,


On Fri, Jan 5, 2018 at 1:04 AM, Joseph Kogut <joseph.kogut@gmail.com> wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  DEVELOPERS                                      |  1 +
>  package/Config.in                               |  1 +
>  package/python-xlib/Config.in                   |  7 +++++++
>  package/python-xlib/python-xlib.hash            |  6 ++++++
>  package/python-xlib/python-xlib.mk              | 15 +++++++++++++++
>  package/python-xlib/remove_setup_requires.patch | 13 +++++++++++++
>  6 files changed, 43 insertions(+)
>  create mode 100644 package/python-xlib/Config.in
>  create mode 100644 package/python-xlib/python-xlib.hash
>  create mode 100644 package/python-xlib/python-xlib.mk
>  create mode 100644 package/python-xlib/remove_setup_requires.patch
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index a9a9ac5a39..999e7d3300 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -848,6 +848,7 @@ F:  package/gconf/
>  F:     package/python-raven/
>  F:     package/python-schedule/
>  F:     package/python-websockets/
> +F:     package/python-xlib/
>
>  N:     Johan Derycke <johanderycke@gmail.com>
>  F:     package/python-libconfig/
> diff --git a/package/Config.in b/package/Config.in
> index 37b1e9fe4f..729d660d52 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -941,6 +941,7 @@ menu "External python modules"
>         source "package/python-whoosh/Config.in"
>         source "package/python-ws4py/Config.in"
>         source "package/python-wsaccel/Config.in"
> +       source "package/python-xlib/Config.in"
>         source "package/python-xlrd/Config.in"
>         source "package/python-xlsxwriter/Config.in"
>         source "package/python-xlutils/Config.in"
> diff --git a/package/python-xlib/Config.in b/package/python-xlib/Config.in
> new file mode 100644
> index 0000000000..3cd83f030c
> --- /dev/null
> +++ b/package/python-xlib/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_XLIB
> +       bool "python-xlib"
> +       select BR2_PACKAGE_PYTHON_SIX

please add "# runtime" tag to the selected dependency (see
https://git.busybox.net/buildroot/tree/package/python-tornado/Config.in
for the reference)

> +       help
> +         XLib in pure Python (Py2/Py3 compatible)
> +
> +         https://github.com/python-xlib/python-xlib
> diff --git a/package/python-xlib/python-xlib.hash b/package/python-xlib/python-xlib.hash
> new file mode 100644
> index 0000000000..05b407209c
> --- /dev/null
> +++ b/package/python-xlib/python-xlib.hash
> @@ -0,0 +1,6 @@
> +# md5 from https://pypi.python.org/pypi/python-xlib/json, sha256 locally computed
> +md5 cdf342aa145c2be0ccae46cfb7b62551 python-xlib-0.21.tar.bz2
> +sha256 25aad0056172920552c01a163e979b02336abaf47b0792dae9c93ecb29500431 python-xlib-0.21.tar.bz2
> +# License file, locally calculated

remove this comment

> +sha256 5ce9459bc19ced99cc9eb135d4f559ed01e336354bdf16dd998be85aa688c233 LICENSE
> +

remove this empty line

> diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
> new file mode 100644
> index 0000000000..ca200e6a97
> --- /dev/null
> +++ b/package/python-xlib/python-xlib.mk
> @@ -0,0 +1,15 @@
> +###############################################################################
> +#
> +# python-xlib
> +#
> +###############################################################################
> +
> +PYTHON_XLIB_VERSION = 0.21
> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
> +PYTHON_XLIB_SETUP_TYPE = setuptools
> +PYTHON_XLIB_LICENSE = LGPL-2.0+
> +PYTHON_XLIB_LICENSE_FILES = LICENSE
> +PYTHON_XLIB_DEPENDENCIES = python-six

this should be PYTHON_XLIB_DEPENDENCIES = host-python-setuptools-scm
see package/python-jaraco-classes/python-jaraco-classes.mk for the reference

> +
> +$(eval $(python-package))
> diff --git a/package/python-xlib/remove_setup_requires.patch b/package/python-xlib/remove_setup_requires.patch
> new file mode 100644
> index 0000000000..a2bb4656ac
> --- /dev/null
> +++ b/package/python-xlib/remove_setup_requires.patch
> @@ -0,0 +1,13 @@
> +diff --git a/setup.py b/setup.py
> +index 9b4a47e..cac95ba 100644
> +--- a/setup.py
> ++++ b/setup.py
> +@@ -5,7 +5,6 @@ from setuptools import setup
> +
> + setup(
> +     install_requires=['six>=1.10.0'],
> +-    setup_requires=['setuptools-scm'],
> +     packages=[
> +         'Xlib',
> +         'Xlib.ext',
> +

remove this patch, as with proper build time dependency you don't need it.

With all these issues fixed you can add my Reviewed-by: Yegor Yefremov
<yegorslists@googlemail.com> for the v2 patch version.

Yegor

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-05  0:04 [Buildroot] [PATCH 1/1] python-xlib: new package Joseph Kogut
  2018-01-05  7:55 ` Yegor Yefremov
@ 2018-01-05 21:13 ` Joseph Kogut
  2018-01-06 14:13   ` Thomas Petazzoni
  2018-01-13 22:10   ` Yann E. MORIN
  1 sibling, 2 replies; 13+ messages in thread
From: Joseph Kogut @ 2018-01-05 21:13 UTC (permalink / raw)
  To: buildroot

Thanks for the review, Yegor!

Changes since v1:
- added runtime tag to python-six Config dependency
- remove unneeded command and newline from python-xlib.hash
- added host-python-setuptools-scm to build dependencies
- removed setup.py patch

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 DEVELOPERS                           |  1 +
 package/Config.in                    |  1 +
 package/python-xlib/Config.in        |  7 +++++++
 package/python-xlib/python-xlib.hash |  4 ++++
 package/python-xlib/python-xlib.mk   | 15 +++++++++++++++
 5 files changed, 28 insertions(+)
 create mode 100644 package/python-xlib/Config.in
 create mode 100644 package/python-xlib/python-xlib.hash
 create mode 100644 package/python-xlib/python-xlib.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index a9a9ac5a39..999e7d3300 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -848,6 +848,7 @@ F:	package/gconf/
 F:	package/python-raven/
 F:	package/python-schedule/
 F:	package/python-websockets/
+F:	package/python-xlib/

 N:	Johan Derycke <johanderycke@gmail.com>
 F:	package/python-libconfig/
diff --git a/package/Config.in b/package/Config.in
index 37b1e9fe4f..729d660d52 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -941,6 +941,7 @@ menu "External python modules"
 	source "package/python-whoosh/Config.in"
 	source "package/python-ws4py/Config.in"
 	source "package/python-wsaccel/Config.in"
+	source "package/python-xlib/Config.in"
 	source "package/python-xlrd/Config.in"
 	source "package/python-xlsxwriter/Config.in"
 	source "package/python-xlutils/Config.in"
diff --git a/package/python-xlib/Config.in b/package/python-xlib/Config.in
new file mode 100644
index 0000000000..081af6a2fc
--- /dev/null
+++ b/package/python-xlib/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_XLIB
+	bool "python-xlib"
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	help
+	  XLib in pure Python (Py2/Py3 compatible)
+
+	  https://github.com/python-xlib/python-xlib
diff --git a/package/python-xlib/python-xlib.hash b/package/python-xlib/python-xlib.hash
new file mode 100644
index 0000000000..5cb9806856
--- /dev/null
+++ b/package/python-xlib/python-xlib.hash
@@ -0,0 +1,4 @@
+# md5 from https://pypi.python.org/pypi/python-xlib/json, sha256 locally computed
+md5 cdf342aa145c2be0ccae46cfb7b62551 python-xlib-0.21.tar.bz2
+sha256 25aad0056172920552c01a163e979b02336abaf47b0792dae9c93ecb29500431 python-xlib-0.21.tar.bz2
+sha256 5ce9459bc19ced99cc9eb135d4f559ed01e336354bdf16dd998be85aa688c233 LICENSE
diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
new file mode 100644
index 0000000000..5476edfe0d
--- /dev/null
+++ b/package/python-xlib/python-xlib.mk
@@ -0,0 +1,15 @@
+###############################################################################
+#
+# python-xlib
+#
+###############################################################################
+
+PYTHON_XLIB_VERSION = 0.21
+PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
+PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
+PYTHON_XLIB_SETUP_TYPE = setuptools
+PYTHON_XLIB_LICENSE = LGPL-2.0+
+PYTHON_XLIB_LICENSE_FILES = LICENSE
+PYTHON_XLIB_DEPENDENCIES = host-python-setuptools-scm
+
+$(eval $(python-package))
--
2.15.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-05 21:13 ` [Buildroot] [PATCH v2 " Joseph Kogut
@ 2018-01-06 14:13   ` Thomas Petazzoni
  2018-01-07  0:14     ` Matthew Weber
  2018-01-07  2:48     ` Joseph Kogut
  2018-01-13 22:10   ` Yann E. MORIN
  1 sibling, 2 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2018-01-06 14:13 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri,  5 Jan 2018 13:13:07 -0800, Joseph Kogut wrote:
> Thanks for the review, Yegor!
> 
> Changes since v1:
> - added runtime tag to python-six Config dependency
> - remove unneeded command and newline from python-xlib.hash
> - added host-python-setuptools-scm to build dependencies
> - removed setup.py patch

This personal message and changelog should have gone...

> 
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---

... here, so that Git doesn't include it as part of the commit log.
Indeed, we don't need to keep such details in the Git history (but they
are very useful to have during the patch review process).

> +PYTHON_XLIB_VERSION = 0.21
> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
> +PYTHON_XLIB_SETUP_TYPE = setuptools
> +PYTHON_XLIB_LICENSE = LGPL-2.0+

The license is in fact LGPL-2.1+, so I've fixed that and applied your
patch to the master branch.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-06 14:13   ` Thomas Petazzoni
@ 2018-01-07  0:14     ` Matthew Weber
  2018-01-07  2:48     ` Joseph Kogut
  1 sibling, 0 replies; 13+ messages in thread
From: Matthew Weber @ 2018-01-07  0:14 UTC (permalink / raw)
  To: buildroot

Joseph,

On Sat, Jan 6, 2018 at 8:13 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri,  5 Jan 2018 13:13:07 -0800, Joseph Kogut wrote:
>> Thanks for the review, Yegor!
>>
>> Changes since v1:
>> - added runtime tag to python-six Config dependency
>> - remove unneeded command and newline from python-xlib.hash
>> - added host-python-setuptools-scm to build dependencies
>> - removed setup.py patch
>
> This personal message and changelog should have gone...
>
>>
>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>
> ... here, so that Git doesn't include it as part of the commit log.
> Indeed, we don't need to keep such details in the Git history (but they
> are very useful to have during the patch review process).
>
>> +PYTHON_XLIB_VERSION = 0.21
>> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
>> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
>> +PYTHON_XLIB_SETUP_TYPE = setuptools
>> +PYTHON_XLIB_LICENSE = LGPL-2.0+
>
> The license is in fact LGPL-2.1+, so I've fixed that and applied your
> patch to the master branch.
>

Looks like license hash was updated and the legal-info integrity check
causes the following failure.  I'll send a quick patch tonight to keep
the builders going.

http://autobuild.buildroot.net/results/762/7627e9da786852d6b08e2fc6092a5ce3ba2f4ea0//

-- 
Thanks,
Matt

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-06 14:13   ` Thomas Petazzoni
  2018-01-07  0:14     ` Matthew Weber
@ 2018-01-07  2:48     ` Joseph Kogut
  2018-01-07 10:06       ` Yegor Yefremov
  1 sibling, 1 reply; 13+ messages in thread
From: Joseph Kogut @ 2018-01-07  2:48 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, Jan 6, 2018 at 6:13 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> This personal message and changelog should have gone...
>
>>
>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>
> ... here, so that Git doesn't include it as part of the commit log.
> Indeed, we don't need to keep such details in the Git history (but they
> are very useful to have during the patch review process).
>
>> +PYTHON_XLIB_VERSION = 0.21
>> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
>> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
>> +PYTHON_XLIB_SETUP_TYPE = setuptools
>> +PYTHON_XLIB_LICENSE = LGPL-2.0+
>
> The license is in fact LGPL-2.1+, so I've fixed that and applied your
> patch to the master branch.

Ah, thanks for the fixup. I'll keep that in mind next time.

> Thanks for your contribution!

Thanks for all your support!

Joseph

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-07  2:48     ` Joseph Kogut
@ 2018-01-07 10:06       ` Yegor Yefremov
  2018-01-14 20:28         ` Joseph Kogut
  0 siblings, 1 reply; 13+ messages in thread
From: Yegor Yefremov @ 2018-01-07 10:06 UTC (permalink / raw)
  To: buildroot

Hello Joseph,

On Sun, Jan 7, 2018 at 3:48 AM, Joseph Kogut <joseph.kogut@gmail.com> wrote:
> Hello,
>
> On Sat, Jan 6, 2018 at 6:13 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>>
>> This personal message and changelog should have gone...
>>
>>>
>>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>>> ---
>>
>> ... here, so that Git doesn't include it as part of the commit log.
>> Indeed, we don't need to keep such details in the Git history (but they
>> are very useful to have during the patch review process).
>>
>>> +PYTHON_XLIB_VERSION = 0.21
>>> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
>>> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
>>> +PYTHON_XLIB_SETUP_TYPE = setuptools
>>> +PYTHON_XLIB_LICENSE = LGPL-2.0+
>>
>> The license is in fact LGPL-2.1+, so I've fixed that and applied your
>> patch to the master branch.
>
> Ah, thanks for the fixup. I'll keep that in mind next time.
>
>> Thanks for your contribution!
>
> Thanks for all your support!

Btw. have you ever tried utils/scanpypi (see "17.8.3. Generating a
python-package from a PyPI repository" for the reference)?

Yegor

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-05 21:13 ` [Buildroot] [PATCH v2 " Joseph Kogut
  2018-01-06 14:13   ` Thomas Petazzoni
@ 2018-01-13 22:10   ` Yann E. MORIN
  2018-01-14 21:16     ` [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning Joseph Kogut
  1 sibling, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2018-01-13 22:10 UTC (permalink / raw)
  To: buildroot

Joseph, All,

On 2018-01-05 13:13 -0800, Joseph Kogut spake thusly:
[--SNIP--]
> diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
> new file mode 100644
> index 0000000000..5476edfe0d
> --- /dev/null
> +++ b/package/python-xlib/python-xlib.mk
> @@ -0,0 +1,15 @@
> +###############################################################################
> +#
> +# python-xlib
> +#
> +###############################################################################

Running the check-package script will return two issues:

    $ utils/check-package package/python-xlib/*
    package/python-xlib/python-xlib.mk:1: should be 80 hashes (http://nightly.buildroot.org/#writing-rules-mk)
    package/python-xlib/python-xlib.mk:5: should be 80 hashes (http://nightly.buildroot.org/#writing-rules-mk)
    26 lines processed
    2 warnings generated

CAn you fix, please?

Regards,
Yann E. MORIN.

> +PYTHON_XLIB_VERSION = 0.21
> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
> +PYTHON_XLIB_SETUP_TYPE = setuptools
> +PYTHON_XLIB_LICENSE = LGPL-2.0+
> +PYTHON_XLIB_LICENSE_FILES = LICENSE
> +PYTHON_XLIB_DEPENDENCIES = host-python-setuptools-scm
> +
> +$(eval $(python-package))
> --
> 2.15.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-07 10:06       ` Yegor Yefremov
@ 2018-01-14 20:28         ` Joseph Kogut
  2018-01-14 20:34           ` Yegor Yefremov
  0 siblings, 1 reply; 13+ messages in thread
From: Joseph Kogut @ 2018-01-14 20:28 UTC (permalink / raw)
  To: buildroot

Hi Yegor,

On Sun, Jan 7, 2018 at 2:06 AM, Yegor Yefremov
<yegorslists@googlemail.com> wrote:
> Hello Joseph,
>
> On Sun, Jan 7, 2018 at 3:48 AM, Joseph Kogut <joseph.kogut@gmail.com> wrote:
>> Hello,
>>
>> On Sat, Jan 6, 2018 at 6:13 AM, Thomas Petazzoni
>> <thomas.petazzoni@free-electrons.com> wrote:
>>>
>>> This personal message and changelog should have gone...
>>>
>>>>
>>>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>>>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>>>> ---
>>>
>>> ... here, so that Git doesn't include it as part of the commit log.
>>> Indeed, we don't need to keep such details in the Git history (but they
>>> are very useful to have during the patch review process).
>>>
>>>> +PYTHON_XLIB_VERSION = 0.21
>>>> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
>>>> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
>>>> +PYTHON_XLIB_SETUP_TYPE = setuptools
>>>> +PYTHON_XLIB_LICENSE = LGPL-2.0+
>>>
>>> The license is in fact LGPL-2.1+, so I've fixed that and applied your
>>> patch to the master branch.
>>
>> Ah, thanks for the fixup. I'll keep that in mind next time.
>>
>>> Thanks for your contribution!
>>
>> Thanks for all your support!
>
> Btw. have you ever tried utils/scanpypi (see "17.8.3. Generating a
> python-package from a PyPI repository" for the reference)?
>
> Yegor

I have, but I've had issues with using the tool for certain packages.
Practically speaking the correct course of action would probably be
for me to submit patches to improve the tool, rather than not use it.
Clearly, I made some mistakes with this submission as a result.

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-xlib: new package
  2018-01-14 20:28         ` Joseph Kogut
@ 2018-01-14 20:34           ` Yegor Yefremov
  0 siblings, 0 replies; 13+ messages in thread
From: Yegor Yefremov @ 2018-01-14 20:34 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 14, 2018 at 9:28 PM, Joseph Kogut <joseph.kogut@gmail.com> wrote:
> Hi Yegor,
>
> On Sun, Jan 7, 2018 at 2:06 AM, Yegor Yefremov
> <yegorslists@googlemail.com> wrote:
>> Hello Joseph,
>>
>> On Sun, Jan 7, 2018 at 3:48 AM, Joseph Kogut <joseph.kogut@gmail.com> wrote:
>>> Hello,
>>>
>>> On Sat, Jan 6, 2018 at 6:13 AM, Thomas Petazzoni
>>> <thomas.petazzoni@free-electrons.com> wrote:
>>>>
>>>> This personal message and changelog should have gone...
>>>>
>>>>>
>>>>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>>>>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>>>>> ---
>>>>
>>>> ... here, so that Git doesn't include it as part of the commit log.
>>>> Indeed, we don't need to keep such details in the Git history (but they
>>>> are very useful to have during the patch review process).
>>>>
>>>>> +PYTHON_XLIB_VERSION = 0.21
>>>>> +PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
>>>>> +PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
>>>>> +PYTHON_XLIB_SETUP_TYPE = setuptools
>>>>> +PYTHON_XLIB_LICENSE = LGPL-2.0+
>>>>
>>>> The license is in fact LGPL-2.1+, so I've fixed that and applied your
>>>> patch to the master branch.
>>>
>>> Ah, thanks for the fixup. I'll keep that in mind next time.
>>>
>>>> Thanks for your contribution!
>>>
>>> Thanks for all your support!
>>
>> Btw. have you ever tried utils/scanpypi (see "17.8.3. Generating a
>> python-package from a PyPI repository" for the reference)?
>>
>> Yegor
>
> I have, but I've had issues with using the tool for certain packages.
> Practically speaking the correct course of action would probably be
> for me to submit patches to improve the tool, rather than not use it.
> Clearly, I made some mistakes with this submission as a result.

scanpypi still has problems with some odd setup.py files, but the most
packages can be handled without fuss. And patches are always welcome
:-)

Yegor

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning
  2018-01-13 22:10   ` Yann E. MORIN
@ 2018-01-14 21:16     ` Joseph Kogut
  2018-01-14 22:05       ` Yann E. MORIN
  2018-01-15 15:38       ` Peter Korsgaard
  0 siblings, 2 replies; 13+ messages in thread
From: Joseph Kogut @ 2018-01-14 21:16 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
 package/python-xlib/python-xlib.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
index 93de424a3e..0ce6e43422 100644
--- a/package/python-xlib/python-xlib.mk
+++ b/package/python-xlib/python-xlib.mk
@@ -1,8 +1,8 @@
-###############################################################################
+################################################################################
 #
 # python-xlib
 #
-###############################################################################
+################################################################################
 
 PYTHON_XLIB_VERSION = 0.21
 PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning
  2018-01-14 21:16     ` [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning Joseph Kogut
@ 2018-01-14 22:05       ` Yann E. MORIN
  2018-01-15 15:38       ` Peter Korsgaard
  1 sibling, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2018-01-14 22:05 UTC (permalink / raw)
  To: buildroot

Joseph, All,

On 2018-01-14 13:16 -0800, Joseph Kogut spake thusly:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thanks! :-)

Regards,
Yann E. MORIN.

> ---
>  package/python-xlib/python-xlib.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
> index 93de424a3e..0ce6e43422 100644
> --- a/package/python-xlib/python-xlib.mk
> +++ b/package/python-xlib/python-xlib.mk
> @@ -1,8 +1,8 @@
> -###############################################################################
> +################################################################################
>  #
>  # python-xlib
>  #
> -###############################################################################
> +################################################################################
>  
>  PYTHON_XLIB_VERSION = 0.21
>  PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
> -- 
> 2.15.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning
  2018-01-14 21:16     ` [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning Joseph Kogut
  2018-01-14 22:05       ` Yann E. MORIN
@ 2018-01-15 15:38       ` Peter Korsgaard
  1 sibling, 0 replies; 13+ messages in thread
From: Peter Korsgaard @ 2018-01-15 15:38 UTC (permalink / raw)
  To: buildroot

>>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes:

 > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-01-15 15:38 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-05  0:04 [Buildroot] [PATCH 1/1] python-xlib: new package Joseph Kogut
2018-01-05  7:55 ` Yegor Yefremov
2018-01-05 21:13 ` [Buildroot] [PATCH v2 " Joseph Kogut
2018-01-06 14:13   ` Thomas Petazzoni
2018-01-07  0:14     ` Matthew Weber
2018-01-07  2:48     ` Joseph Kogut
2018-01-07 10:06       ` Yegor Yefremov
2018-01-14 20:28         ` Joseph Kogut
2018-01-14 20:34           ` Yegor Yefremov
2018-01-13 22:10   ` Yann E. MORIN
2018-01-14 21:16     ` [Buildroot] [PATCH 1/1] python-xlib: fix check-package warning Joseph Kogut
2018-01-14 22:05       ` Yann E. MORIN
2018-01-15 15:38       ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.