All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Eric Anholt <eric@anholt.net>,
	Dave Stevenson <dave.stevenson@raspberrypi.org>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	Michael Zoran <mzoran@crowfest.net>,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service
Date: Sun, 14 Jan 2018 08:08:40 +0200	[thread overview]
Message-ID: <20180114060840.ychhndc7ukulrbpe@sapphire.tkos.co.il> (raw)
In-Reply-To: <1313448378.43279.1515839595810@email.1und1.de>

Hi Stefan,

Thanks for reviewing. Please find below a few questions.

On Sat, Jan 13, 2018 at 11:33:15AM +0100, Stefan Wahren wrote: 
> > +	default RASPBERRYPI_FIRMWARE
> > +	depends on OF_GPIO && RASPBERRYPI_FIRMWARE && \
> > +		(ARCH_BCM2835 || COMPILE_TEST)
> 
> Since this is default on RASPBERRYPI_FIRMWARE, we could remove it from the dependencies.

This driver does not work when RASPBERRYPI_FIRMWARE is not enabled. So the 
driver should not be selectable, regardless of its default enable/disable 
state.

> > +	help
> > +	  Turn on GPIO support for the expander on Raspberry Pi 3 boards, using
> > +	  the firmware mailbox to communicate with VideoCore on BCM283x chips.
> > +

[...]

> > --- /dev/null
> > +++ b/drivers/gpio/gpio-raspberrypi-exp.c
> > @@ -0,0 +1,258 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + *  Raspberry Pi 3 expander GPIO driver
> > + *
> > + *  Uses the firmware mailbox service to communicate with the
> > + *  GPIO expander on the VPU.
> > + *
> > + *  Copyright (C) 2017 Raspberry Pi Trading Ltd.
> 
> 2018?

Why? Raspberry Pi Trading Ltd added no code to this driver in 2018.

[...]

> > +static struct platform_driver rpi_exp_gpio_driver = {
> > +	.driver	= {
> > +		.name		= MODULE_NAME,
> > +		.owner		= THIS_MODULE,
> 
> Please drop this, too.

Why? Recent GPIO drivers include this line. I have seen no commits removing 
.owner from GPIO drivers in mainline or in current development tree.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service
Date: Sun, 14 Jan 2018 08:08:40 +0200	[thread overview]
Message-ID: <20180114060840.ychhndc7ukulrbpe@sapphire.tkos.co.il> (raw)
In-Reply-To: <1313448378.43279.1515839595810@email.1und1.de>

Hi Stefan,

Thanks for reviewing. Please find below a few questions.

On Sat, Jan 13, 2018 at 11:33:15AM +0100, Stefan Wahren wrote: 
> > +	default RASPBERRYPI_FIRMWARE
> > +	depends on OF_GPIO && RASPBERRYPI_FIRMWARE && \
> > +		(ARCH_BCM2835 || COMPILE_TEST)
> 
> Since this is default on RASPBERRYPI_FIRMWARE, we could remove it from the dependencies.

This driver does not work when RASPBERRYPI_FIRMWARE is not enabled. So the 
driver should not be selectable, regardless of its default enable/disable 
state.

> > +	help
> > +	  Turn on GPIO support for the expander on Raspberry Pi 3 boards, using
> > +	  the firmware mailbox to communicate with VideoCore on BCM283x chips.
> > +

[...]

> > --- /dev/null
> > +++ b/drivers/gpio/gpio-raspberrypi-exp.c
> > @@ -0,0 +1,258 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + *  Raspberry Pi 3 expander GPIO driver
> > + *
> > + *  Uses the firmware mailbox service to communicate with the
> > + *  GPIO expander on the VPU.
> > + *
> > + *  Copyright (C) 2017 Raspberry Pi Trading Ltd.
> 
> 2018?

Why? Raspberry Pi Trading Ltd added no code to this driver in 2018.

[...]

> > +static struct platform_driver rpi_exp_gpio_driver = {
> > +	.driver	= {
> > +		.name		= MODULE_NAME,
> > +		.owner		= THIS_MODULE,
> 
> Please drop this, too.

Why? Recent GPIO drivers include this line. I have seen no commits removing 
.owner from GPIO drivers in mainline or in current development tree.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  parent reply	other threads:[~2018-01-14  6:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 19:44 [PATCH v2 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-11 19:44 ` Baruch Siach
     [not found] ` <cover.1515698418.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-11 19:44   ` [PATCH v2 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
2018-01-11 19:44     ` Baruch Siach
2018-01-13  9:57     ` Stefan Wahren
2018-01-13  9:57       ` Stefan Wahren
     [not found]       ` <1991337128.42939.1515837465503-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2018-01-16  9:57         ` Linus Walleij
     [not found]           ` <CACRpkdZ_g3-jR-7pOnS9MwpHprfEz8acB9SWcMLyoOVcB0iLvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-16 10:49             ` Baruch Siach
2018-01-16 12:01               ` Stefan Wahren
2018-01-18 20:50                 ` Eric Anholt
2018-01-18 20:50                   ` Eric Anholt
2018-01-11 19:44 ` [PATCH v2 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-11 19:44   ` Baruch Siach
2018-01-13 10:06   ` Stefan Wahren
2018-01-13 10:06     ` Stefan Wahren
2018-01-11 19:44 ` [PATCH v2 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service Baruch Siach
2018-01-11 19:44   ` Baruch Siach
     [not found]   ` <35b07d1aae959c357d671f5530311320d0f10cc8.1515698418.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-13 10:33     ` Stefan Wahren
2018-01-13 10:33       ` Stefan Wahren
2018-01-13 14:49       ` Peter Robinson
2018-01-13 14:49         ` Peter Robinson
2018-01-14  6:08       ` Baruch Siach [this message]
2018-01-14  6:08         ` Baruch Siach
     [not found]         ` <20180114060840.ychhndc7ukulrbpe-MwjkAAnuF3khR1HGirfZ1z4kX+cae0hd@public.gmane.org>
2018-01-14 10:42           ` Stefan Wahren
2018-01-14 10:42             ` Stefan Wahren
2018-01-11 19:44 ` [PATCH v2 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-11 19:44   ` Baruch Siach
     [not found]   ` <1cb81e3d7a1b1f7ccf374952fa7e8d2147c186fb.1515698418.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-13 10:44     ` Stefan Wahren
2018-01-13 10:44       ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180114060840.ychhndc7ukulrbpe@sapphire.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=dave.stevenson@raspberrypi.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mzoran@crowfest.net \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.