All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/kprobe: unbalanced preempt counter in kprobe_{fault,debug}_handler
@ 2018-01-15  4:28 Yang Bo
  0 siblings, 0 replies; only message in thread
From: Yang Bo @ 2018-01-15  4:28 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Ingo Molnar, H. Peter Anvin, x86, Masami Hiramatsu, Mark Rutland,
	Andrew Morton, Laura Abbott, linux-kernel, Yang Bo

Don't see any preempt_disable() in do_debug() and do_page_fault(),
there is no need to call preempt_enable_no_resched() here.

Signed-off-by: Yang Bo <yangbo@deepin.com>
---
 arch/x86/kernel/kprobes/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
index 1ea5c9caa8f1..6f2c43e33674 100644
--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -969,7 +969,6 @@ int kprobe_debug_handler(struct pt_regs *regs)
 	}
 	reset_current_kprobe();
 out:
-	preempt_enable_no_resched();
 
 	/*
 	 * if somebody else is singlestepping across a probe point, flags
@@ -1017,7 +1016,6 @@ int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
 			restore_previous_kprobe(kcb);
 		else
 			reset_current_kprobe();
-		preempt_enable_no_resched();
 	} else if (kcb->kprobe_status == KPROBE_HIT_ACTIVE ||
 		   kcb->kprobe_status == KPROBE_HIT_SSDONE) {
 		/*
-- 
2.15.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-15  4:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15  4:28 [PATCH] x86/kprobe: unbalanced preempt counter in kprobe_{fault,debug}_handler Yang Bo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.