All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] wolfssl: fix build on ARMV8
@ 2018-01-15  9:55 Sergio Prado
  2018-01-15 10:32 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Prado @ 2018-01-15  9:55 UTC (permalink / raw)
  To: buildroot

Build on ARMV8 fails when hardware acceleration is enabled:

/tmp/ccmGP5RI.s: Assembler messages:
/tmp/ccmGP5RI.s:532: Error: invalid addressing mode at operand 2 -- `ld1 {v0.2d},[x0,256]'
/tmp/ccmGP5RI.s:568: Error: invalid addressing mode at operand 2 -- `st1 {v0.2d},[x0,256]'
/tmp/ccmGP5RI.s:581: Error: invalid addressing mode at operand 2 -- `ld1 {v0.2d},[x0,256]'
/tmp/ccmGP5RI.s:621: Error: invalid addressing mode at operand 2 -- `st1 {v0.2d},[x0,256]'

So let's disable ARMv8 hardware acceleration for now.

Fixes:
http://autobuild.buildroot.net/results/6080648394d09a0d382087831ee6f063c7638be9

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
 package/wolfssl/wolfssl.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/wolfssl/wolfssl.mk b/package/wolfssl/wolfssl.mk
index c8ef50a9bc6e..3e661cd26ef4 100644
--- a/package/wolfssl/wolfssl.mk
+++ b/package/wolfssl/wolfssl.mk
@@ -29,10 +29,4 @@ else
 WOLFSSL_CONF_OPTS += --disable-sslv3
 endif
 
-ifeq ($(BR2_ARM_CPU_ARMV8A),y)
-WOLFSSL_CONF_OPTS += --enable-armasm
-else
-WOLFSSL_CONF_OPTS += --disable-armasm
-endif
-
 $(eval $(autotools-package))
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] wolfssl: fix build on ARMV8
  2018-01-15  9:55 [Buildroot] [PATCH] wolfssl: fix build on ARMV8 Sergio Prado
@ 2018-01-15 10:32 ` Thomas Petazzoni
  2018-01-15 10:59   ` Sergio Prado
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2018-01-15 10:32 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 15 Jan 2018 07:55:10 -0200, Sergio Prado wrote:

> diff --git a/package/wolfssl/wolfssl.mk b/package/wolfssl/wolfssl.mk
> index c8ef50a9bc6e..3e661cd26ef4 100644
> --- a/package/wolfssl/wolfssl.mk
> +++ b/package/wolfssl/wolfssl.mk
> @@ -29,10 +29,4 @@ else
>  WOLFSSL_CONF_OPTS += --disable-sslv3
>  endif
>  
> -ifeq ($(BR2_ARM_CPU_ARMV8A),y)
> -WOLFSSL_CONF_OPTS += --enable-armasm
> -else
> -WOLFSSL_CONF_OPTS += --disable-armasm
> -endif

So perhaps --disable-armasm should be passed unconditionally?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] wolfssl: fix build on ARMV8
  2018-01-15 10:32 ` Thomas Petazzoni
@ 2018-01-15 10:59   ` Sergio Prado
  2018-01-15 11:07     ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Prado @ 2018-01-15 10:59 UTC (permalink / raw)
  To: buildroot

Hello,

2018-01-15 8:32 GMT-02:00 Thomas Petazzoni <thomas.petazzoni@free-
electrons.com>:

> Hello,
>
> On Mon, 15 Jan 2018 07:55:10 -0200, Sergio Prado wrote:
>
> > diff --git a/package/wolfssl/wolfssl.mk b/package/wolfssl/wolfssl.mk
> > index c8ef50a9bc6e..3e661cd26ef4 100644
> > --- a/package/wolfssl/wolfssl.mk
> > +++ b/package/wolfssl/wolfssl.mk
> > @@ -29,10 +29,4 @@ else
> >  WOLFSSL_CONF_OPTS += --disable-sslv3
> >  endif
> >
> > -ifeq ($(BR2_ARM_CPU_ARMV8A),y)
> > -WOLFSSL_CONF_OPTS += --enable-armasm
> > -else
> > -WOLFSSL_CONF_OPTS += --disable-armasm
> > -endif
>
> So perhaps --disable-armasm should be passed unconditionally?
>

It's disabled by default. Should we still pass it?


>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180115/cae4db5a/attachment.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] wolfssl: fix build on ARMV8
  2018-01-15 10:59   ` Sergio Prado
@ 2018-01-15 11:07     ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-01-15 11:07 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 15 Jan 2018 08:59:22 -0200, Sergio Prado wrote:

> > So perhaps --disable-armasm should be passed unconditionally?
> >  
> 
> It's disabled by default. Should we still pass it?

Well, it's always good practice to be explicit about config options I
believe.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-15 11:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15  9:55 [Buildroot] [PATCH] wolfssl: fix build on ARMV8 Sergio Prado
2018-01-15 10:32 ` Thomas Petazzoni
2018-01-15 10:59   ` Sergio Prado
2018-01-15 11:07     ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.