* [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
@ 2018-01-15 19:16 Roman Gushchin
2018-01-15 19:32 ` Quentin Monnet
2018-01-15 19:42 ` Jakub Kicinski
0 siblings, 2 replies; 9+ messages in thread
From: Roman Gushchin @ 2018-01-15 19:16 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel-team, Roman Gushchin, Jakub Kicinski,
Quentin Monnet, Daniel Borkmann, Alexei Starovoitov
Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
so the prog show command prints the numeric type value:
$ bpftool prog show
1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74
loaded_at Jan 15/07:58 uid 0
xlated 96B jited 105B memlock 4096B
This patch defines the corresponding textual representation:
$ bpftool prog show
1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74
loaded_at Jan 15/07:58 uid 0
xlated 96B jited 105B memlock 4096B
Signed-off-by: Roman Gushchin <guro@fb.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Quentin Monnet <quentin.monnet@netronome.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>
---
tools/bpf/bpftool/prog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
index c6a28be4665c..099e21cf1b5c 100644
--- a/tools/bpf/bpftool/prog.c
+++ b/tools/bpf/bpftool/prog.c
@@ -66,6 +66,7 @@ static const char * const prog_type_name[] = {
[BPF_PROG_TYPE_LWT_XMIT] = "lwt_xmit",
[BPF_PROG_TYPE_SOCK_OPS] = "sock_ops",
[BPF_PROG_TYPE_SK_SKB] = "sk_skb",
+ [BPF_PROG_TYPE_CGROUP_DEVICE] = "cgroup_device",
};
static void print_boot_time(__u64 nsecs, char *buf, unsigned int size)
--
2.14.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-15 19:16 [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs Roman Gushchin
@ 2018-01-15 19:32 ` Quentin Monnet
2018-01-15 19:49 ` Roman Gushchin
2018-01-19 14:17 ` Roman Gushchin
2018-01-15 19:42 ` Jakub Kicinski
1 sibling, 2 replies; 9+ messages in thread
From: Quentin Monnet @ 2018-01-15 19:32 UTC (permalink / raw)
To: Roman Gushchin, netdev
Cc: linux-kernel, kernel-team, Jakub Kicinski, Daniel Borkmann,
Alexei Starovoitov
2018-01-15 19:16 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
> so the prog show command prints the numeric type value:
>
> $ bpftool prog show
> 1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74
> loaded_at Jan 15/07:58 uid 0
> xlated 96B jited 105B memlock 4096B
>
> This patch defines the corresponding textual representation:
>
> $ bpftool prog show
> 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74
> loaded_at Jan 15/07:58 uid 0
> xlated 96B jited 105B memlock 4096B
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> Cc: Quentin Monnet <quentin.monnet@netronome.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
> ---
> tools/bpf/bpftool/prog.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> index c6a28be4665c..099e21cf1b5c 100644
> --- a/tools/bpf/bpftool/prog.c
> +++ b/tools/bpf/bpftool/prog.c
> @@ -66,6 +66,7 @@ static const char * const prog_type_name[] = {
> [BPF_PROG_TYPE_LWT_XMIT] = "lwt_xmit",
> [BPF_PROG_TYPE_SOCK_OPS] = "sock_ops",
> [BPF_PROG_TYPE_SK_SKB] = "sk_skb",
> + [BPF_PROG_TYPE_CGROUP_DEVICE] = "cgroup_device",
> };
>
> static void print_boot_time(__u64 nsecs, char *buf, unsigned int size)
Looks good, thanks Roman!
Would you mind updating the map names as well? It seems the
BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
Quentin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-15 19:16 [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs Roman Gushchin
2018-01-15 19:32 ` Quentin Monnet
@ 2018-01-15 19:42 ` Jakub Kicinski
1 sibling, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2018-01-15 19:42 UTC (permalink / raw)
To: Roman Gushchin
Cc: netdev, linux-kernel, kernel-team, Quentin Monnet,
Daniel Borkmann, Alexei Starovoitov
On Mon, 15 Jan 2018 19:16:15 +0000, Roman Gushchin wrote:
> Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
> so the prog show command prints the numeric type value:
>
> $ bpftool prog show
> 1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74
> loaded_at Jan 15/07:58 uid 0
> xlated 96B jited 105B memlock 4096B
>
> This patch defines the corresponding textual representation:
>
> $ bpftool prog show
> 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74
> loaded_at Jan 15/07:58 uid 0
> xlated 96B jited 105B memlock 4096B
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> Cc: Quentin Monnet <quentin.monnet@netronome.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-15 19:32 ` Quentin Monnet
@ 2018-01-15 19:49 ` Roman Gushchin
2018-01-16 1:52 ` Daniel Borkmann
2018-01-19 14:17 ` Roman Gushchin
1 sibling, 1 reply; 9+ messages in thread
From: Roman Gushchin @ 2018-01-15 19:49 UTC (permalink / raw)
To: Quentin Monnet
Cc: netdev, linux-kernel, kernel-team, Jakub Kicinski,
Daniel Borkmann, Alexei Starovoitov
On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
> 2018-01-15 19:16 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> > Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
> > so the prog show command prints the numeric type value:
> >
> > $ bpftool prog show
> > 1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74
> > loaded_at Jan 15/07:58 uid 0
> > xlated 96B jited 105B memlock 4096B
> >
> > This patch defines the corresponding textual representation:
> >
> > $ bpftool prog show
> > 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74
> > loaded_at Jan 15/07:58 uid 0
> > xlated 96B jited 105B memlock 4096B
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Cc: Quentin Monnet <quentin.monnet@netronome.com>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > ---
> > tools/bpf/bpftool/prog.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> > index c6a28be4665c..099e21cf1b5c 100644
> > --- a/tools/bpf/bpftool/prog.c
> > +++ b/tools/bpf/bpftool/prog.c
> > @@ -66,6 +66,7 @@ static const char * const prog_type_name[] = {
> > [BPF_PROG_TYPE_LWT_XMIT] = "lwt_xmit",
> > [BPF_PROG_TYPE_SOCK_OPS] = "sock_ops",
> > [BPF_PROG_TYPE_SK_SKB] = "sk_skb",
> > + [BPF_PROG_TYPE_CGROUP_DEVICE] = "cgroup_device",
> > };
> >
> > static void print_boot_time(__u64 nsecs, char *buf, unsigned int size)
>
> Looks good, thanks Roman!
> Would you mind updating the map names as well? It seems the
> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
Hello, Quentin!
Sure, I'll take a look.
Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-15 19:49 ` Roman Gushchin
@ 2018-01-16 1:52 ` Daniel Borkmann
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Borkmann @ 2018-01-16 1:52 UTC (permalink / raw)
To: Roman Gushchin, Quentin Monnet
Cc: netdev, linux-kernel, kernel-team, Jakub Kicinski, Alexei Starovoitov
On 01/15/2018 08:49 PM, Roman Gushchin wrote:
> On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
>> 2018-01-15 19:16 UTC+0000 ~ Roman Gushchin <guro@fb.com>
>>> Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
>>> so the prog show command prints the numeric type value:
>>>
>>> $ bpftool prog show
>>> 1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74
>>> loaded_at Jan 15/07:58 uid 0
>>> xlated 96B jited 105B memlock 4096B
>>>
>>> This patch defines the corresponding textual representation:
>>>
>>> $ bpftool prog show
>>> 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74
>>> loaded_at Jan 15/07:58 uid 0
>>> xlated 96B jited 105B memlock 4096B
>>>
>>> Signed-off-by: Roman Gushchin <guro@fb.com>
>>> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
>>> Cc: Quentin Monnet <quentin.monnet@netronome.com>
>>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>>> Cc: Alexei Starovoitov <ast@kernel.org>
>>> ---
>>> tools/bpf/bpftool/prog.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
>>> index c6a28be4665c..099e21cf1b5c 100644
>>> --- a/tools/bpf/bpftool/prog.c
>>> +++ b/tools/bpf/bpftool/prog.c
>>> @@ -66,6 +66,7 @@ static const char * const prog_type_name[] = {
>>> [BPF_PROG_TYPE_LWT_XMIT] = "lwt_xmit",
>>> [BPF_PROG_TYPE_SOCK_OPS] = "sock_ops",
>>> [BPF_PROG_TYPE_SK_SKB] = "sk_skb",
>>> + [BPF_PROG_TYPE_CGROUP_DEVICE] = "cgroup_device",
>>> };
>>>
>>> static void print_boot_time(__u64 nsecs, char *buf, unsigned int size)
>>
>> Looks good, thanks Roman!
>> Would you mind updating the map names as well? It seems the
>> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>
> Hello, Quentin!
>
> Sure, I'll take a look.
Ok, I presume this comes in as a separate one anyway, so I've applied
this one into bpf-next already, thanks Roman!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-15 19:32 ` Quentin Monnet
2018-01-15 19:49 ` Roman Gushchin
@ 2018-01-19 14:17 ` Roman Gushchin
2018-01-19 14:37 ` Quentin Monnet
2018-01-19 22:23 ` Jakub Kicinski
1 sibling, 2 replies; 9+ messages in thread
From: Roman Gushchin @ 2018-01-19 14:17 UTC (permalink / raw)
To: Quentin Monnet
Cc: netdev, linux-kernel, kernel-team, Jakub Kicinski,
Daniel Borkmann, Alexei Starovoitov
On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
> 2018-01-15 19:16 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> > Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
> > so the prog show command prints the numeric type value:
> >
> > $ bpftool prog show
> > 1: type 15 name bpf_prog1 tag ac9f93dbfd6d9b74
> > loaded_at Jan 15/07:58 uid 0
> > xlated 96B jited 105B memlock 4096B
> >
> > This patch defines the corresponding textual representation:
> >
> > $ bpftool prog show
> > 1: cgroup_device name bpf_prog1 tag ac9f93dbfd6d9b74
> > loaded_at Jan 15/07:58 uid 0
> > xlated 96B jited 105B memlock 4096B
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Cc: Quentin Monnet <quentin.monnet@netronome.com>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > ---
> > tools/bpf/bpftool/prog.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> > index c6a28be4665c..099e21cf1b5c 100644
> > --- a/tools/bpf/bpftool/prog.c
> > +++ b/tools/bpf/bpftool/prog.c
> > @@ -66,6 +66,7 @@ static const char * const prog_type_name[] = {
> > [BPF_PROG_TYPE_LWT_XMIT] = "lwt_xmit",
> > [BPF_PROG_TYPE_SOCK_OPS] = "sock_ops",
> > [BPF_PROG_TYPE_SK_SKB] = "sk_skb",
> > + [BPF_PROG_TYPE_CGROUP_DEVICE] = "cgroup_device",
> > };
> >
> > static void print_boot_time(__u64 nsecs, char *buf, unsigned int size)
>
> Looks good, thanks Roman!
> Would you mind updating the map names as well? It seems the
> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
Hello, Quentin!
Here is the patch.
Thanks!
--
>From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001
From: Roman Gushchin <guro@fb.com>
Date: Fri, 19 Jan 2018 14:07:38 +0000
Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps
Add BPF_MAP_TYPE_CPUMAP map type to the list
of map type recognized by bpftool and define
corresponding text representation.
Signed-off-by: Roman Gushchin <guro@fb.com>
Cc: Quentin Monnet <quentin.monnet@netronome.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>
---
tools/bpf/bpftool/map.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index a152c1a5c94c..f95fa67bb498 100644
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
@@ -66,6 +66,7 @@ static const char * const map_type_name[] = {
[BPF_MAP_TYPE_HASH_OF_MAPS] = "hash_of_maps",
[BPF_MAP_TYPE_DEVMAP] = "devmap",
[BPF_MAP_TYPE_SOCKMAP] = "sockmap",
+ [BPF_MAP_TYPE_CPUMAP] = "cpumap",
};
static unsigned int get_possible_cpus(void)
--
2.14.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-19 14:17 ` Roman Gushchin
@ 2018-01-19 14:37 ` Quentin Monnet
2018-01-19 22:19 ` Daniel Borkmann
2018-01-19 22:23 ` Jakub Kicinski
1 sibling, 1 reply; 9+ messages in thread
From: Quentin Monnet @ 2018-01-19 14:37 UTC (permalink / raw)
To: Roman Gushchin
Cc: netdev, linux-kernel, kernel-team, Jakub Kicinski,
Daniel Borkmann, Alexei Starovoitov
2018-01-19 14:17 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
[...]
>> Looks good, thanks Roman!
>> Would you mind updating the map names as well? It seems the
>> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>
> Hello, Quentin!
>
>
> Here is the patch.
>
>
> Thanks!
>
> --
>
> From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001
> From: Roman Gushchin <guro@fb.com>
> Date: Fri, 19 Jan 2018 14:07:38 +0000
> Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps
>
> Add BPF_MAP_TYPE_CPUMAP map type to the list
> of map type recognized by bpftool and define
> corresponding text representation.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Quentin Monnet <quentin.monnet@netronome.com>
> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
> ---
> tools/bpf/bpftool/map.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> index a152c1a5c94c..f95fa67bb498 100644
> --- a/tools/bpf/bpftool/map.c
> +++ b/tools/bpf/bpftool/map.c
> @@ -66,6 +66,7 @@ static const char * const map_type_name[] = {
> [BPF_MAP_TYPE_HASH_OF_MAPS] = "hash_of_maps",
> [BPF_MAP_TYPE_DEVMAP] = "devmap",
> [BPF_MAP_TYPE_SOCKMAP] = "sockmap",
> + [BPF_MAP_TYPE_CPUMAP] = "cpumap",
> };
>
> static unsigned int get_possible_cpus(void)
>
Good, thank you!
Acked-by: Quentin Monnet <quentin.monnet@netronome.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-19 14:37 ` Quentin Monnet
@ 2018-01-19 22:19 ` Daniel Borkmann
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Borkmann @ 2018-01-19 22:19 UTC (permalink / raw)
To: Quentin Monnet, Roman Gushchin
Cc: netdev, linux-kernel, kernel-team, Jakub Kicinski, Alexei Starovoitov
On 01/19/2018 03:37 PM, Quentin Monnet wrote:
> 2018-01-19 14:17 UTC+0000 ~ Roman Gushchin <guro@fb.com>
>> On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
>
> [...]
>
>>> Looks good, thanks Roman!
>>> Would you mind updating the map names as well? It seems the
>>> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>>
>> Hello, Quentin!
>>
>>
>> Here is the patch.
>>
>>
>> Thanks!
>>
>> --
>>
>> From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001
>> From: Roman Gushchin <guro@fb.com>
>> Date: Fri, 19 Jan 2018 14:07:38 +0000
>> Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps
>>
>> Add BPF_MAP_TYPE_CPUMAP map type to the list
>> of map type recognized by bpftool and define
>> corresponding text representation.
>>
>> Signed-off-by: Roman Gushchin <guro@fb.com>
>> Cc: Quentin Monnet <quentin.monnet@netronome.com>
>> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>> Cc: Alexei Starovoitov <ast@kernel.org>
>> ---
>> tools/bpf/bpftool/map.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
>> index a152c1a5c94c..f95fa67bb498 100644
>> --- a/tools/bpf/bpftool/map.c
>> +++ b/tools/bpf/bpftool/map.c
>> @@ -66,6 +66,7 @@ static const char * const map_type_name[] = {
>> [BPF_MAP_TYPE_HASH_OF_MAPS] = "hash_of_maps",
>> [BPF_MAP_TYPE_DEVMAP] = "devmap",
>> [BPF_MAP_TYPE_SOCKMAP] = "sockmap",
>> + [BPF_MAP_TYPE_CPUMAP] = "cpumap",
>> };
>>
>> static unsigned int get_possible_cpus(void)
>>
>
> Good, thank you!
>
> Acked-by: Quentin Monnet <quentin.monnet@netronome.com>
Applied to bpf-next, thanks for following up Roman!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
2018-01-19 14:17 ` Roman Gushchin
2018-01-19 14:37 ` Quentin Monnet
@ 2018-01-19 22:23 ` Jakub Kicinski
1 sibling, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2018-01-19 22:23 UTC (permalink / raw)
To: Roman Gushchin
Cc: Quentin Monnet, netdev, linux-kernel, kernel-team,
Daniel Borkmann, Alexei Starovoitov
On Fri, 19 Jan 2018 14:17:45 +0000, Roman Gushchin wrote:
> > Looks good, thanks Roman!
> > Would you mind updating the map names as well? It seems the
> > BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>
> Hello, Quentin!
>
> Here is the patch.
Thank you for following up, would you also be abble to find time to
look into bash completions for cgroups before 4.16-rc1? It would be
cool to have the completions... complete ;)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-19 22:24 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 19:16 [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs Roman Gushchin
2018-01-15 19:32 ` Quentin Monnet
2018-01-15 19:49 ` Roman Gushchin
2018-01-16 1:52 ` Daniel Borkmann
2018-01-19 14:17 ` Roman Gushchin
2018-01-19 14:37 ` Quentin Monnet
2018-01-19 22:19 ` Daniel Borkmann
2018-01-19 22:23 ` Jakub Kicinski
2018-01-15 19:42 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.