From: Lars Ellenberg <lars.ellenberg@linbit.com> To: Eric Wheeler <drbd-dev@lists.ewheeler.net> Cc: axboe@kernel.dk, linux-raid@vger.kernel.org, martin.petersen@oracle.com, snitzer@redhat.com, philipp.reisner@linbit.com, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, shli@kernel.org, Christoph Hellwig <hch@lst.de>, agk@redhat.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 23/27] drbd: make intelligent use of blkdev_issue_zeroout Date: Mon, 15 Jan 2018 13:46:35 +0100 [thread overview] Message-ID: <20180115124635.GA4107@soda.linbit> (raw) In-Reply-To: <alpine.LRH.2.11.1801130035010.13147@mail.ewheeler.net> On Sat, Jan 13, 2018 at 12:46:40AM +0000, Eric Wheeler wrote: > Hello All, > > We just noticed that discards to DRBD devices backed by dm-thin devices > are fully allocating the thin blocks. > > This behavior does not exist before > ee472d83 block: add a flags argument to (__)blkdev_issue_zeroout > > The problem exists somewhere between > [working] c20cfc27 block: stop using blkdev_issue_write_same for zeroing > and > [broken] 45c21793 drbd: implement REQ_OP_WRITE_ZEROES > > Note that c20cfc27 works as expected, but 45c21793 discards blocks > being zeroed on the dm-thin backing device. All commits between those two > produce the following error: > > blkdiscard: /dev/drbd/by-res/test: BLKDISCARD ioctl failed: Input/output error > > Also note that issuing a blkdiscard to the backing device directly > discards as you would expect. This is just a problem when sending discards > through DRBD. > > Is there an easy way to solve this in the short term, even if the ultimate > fix is more involved? > On Wed, 5 Apr 2017, Christoph Hellwig wrote: > commit 0dbed96a3cc9786bc4814dab98a7218753bde934 Author: Christoph Hellwig <hch@lst.de> Date: Wed Apr 5 19:21:21 2017 +0200 drbd: make intelligent use of blkdev_issue_zeroout > > drbd always wants its discard wire operations to zero the blocks, so > > use blkdev_issue_zeroout with the BLKDEV_ZERO_UNMAP flag instead of > > reinventing it poorly. > > -/* > > - * We *may* ignore the discard-zeroes-data setting, if so configured. > > - * > > - * Assumption is that it "discard_zeroes_data=0" is only because the backend > > - * may ignore partial unaligned discards. > > - * > > - * LVM/DM thin as of at least > > - * LVM version: 2.02.115(2)-RHEL7 (2015-01-28) > > - * Library version: 1.02.93-RHEL7 (2015-01-28) > > - * Driver version: 4.29.0 > > - * still behaves this way. > > - * > > - * For unaligned (wrt. alignment and granularity) or too small discards, > > - * we zero-out the initial (and/or) trailing unaligned partial chunks, > > - * but discard all the aligned full chunks. > > - * > > - * At least for LVM/DM thin, the result is effectively "discard_zeroes_data=1". > > - */ > > -int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, unsigned int nr_sectors, bool discard) As I understood it, blkdev_issue_zeroout() was supposed to "always try to unmap", deprovision, the relevant region, and zero-out any unaligned head or tail, just like my work around above was doing. And that device mapper thin was "about to" learn this, "soon", or maybe block core would do the equivalent of my workaround described above. But it then did not. See also: https://www.redhat.com/archives/dm-devel/2017-March/msg00213.html https://www.redhat.com/archives/dm-devel/2017-March/msg00226.html I then did not follow this closely enough anymore, and I missed that with recent enough kernel, discard on DRBD on dm-thin would fully allocate. In our out-of-tree module, we had to keep the older code for compat reasons, anyways. I will just re-enable our zeroout workaround there again. In tree, either dm-thin learns to do REQ_OP_WRITE_ZEROES "properly", so the result in this scenario is what we expect: _: unprovisioned, not allocated, returns zero on read anyways *: provisioned, some arbitrary data 0: explicitly zeroed: |gran|ular|ity | | | | |****|****|____|****| to|-be-|zero|ed |**00|____|____|00**| (leave unallocated blocks alone, de-allocate full blocks just like with discard, explicitly zero unaligned head and tail) Or DRBD will have to resurrect that reinvented zeroout again, with exactly those semantics. I did reinvent it for a reason ;) -- : Lars Ellenberg : LINBIT | Keeping the Digital World Running : DRBD -- Heartbeat -- Corosync -- Pacemaker : R&D, Integration, Ops, Consulting, Support DRBD® and LINBIT® are registered trademarks of LINBIT
WARNING: multiple messages have this Message-ID (diff)
From: Lars Ellenberg <lars.ellenberg@linbit.com> To: Eric Wheeler <drbd-dev@lists.ewheeler.net> Cc: Christoph Hellwig <hch@lst.de>, axboe@kernel.dk, martin.petersen@oracle.com, agk@redhat.com, snitzer@redhat.com, shli@kernel.org, philipp.reisner@linbit.com, linux-block@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 23/27] drbd: make intelligent use of blkdev_issue_zeroout Date: Mon, 15 Jan 2018 13:46:35 +0100 [thread overview] Message-ID: <20180115124635.GA4107@soda.linbit> (raw) In-Reply-To: <alpine.LRH.2.11.1801130035010.13147@mail.ewheeler.net> On Sat, Jan 13, 2018 at 12:46:40AM +0000, Eric Wheeler wrote: > Hello All, > > We just noticed that discards to DRBD devices backed by dm-thin devices > are fully allocating the thin blocks. > > This behavior does not exist before > ee472d83 block: add a flags argument to (__)blkdev_issue_zeroout > > The problem exists somewhere between > [working] c20cfc27 block: stop using blkdev_issue_write_same for zeroing > and > [broken] 45c21793 drbd: implement REQ_OP_WRITE_ZEROES > > Note that c20cfc27 works as expected, but 45c21793 discards blocks > being zeroed on the dm-thin backing device. All commits between those two > produce the following error: > > blkdiscard: /dev/drbd/by-res/test: BLKDISCARD ioctl failed: Input/output error > > Also note that issuing a blkdiscard to the backing device directly > discards as you would expect. This is just a problem when sending discards > through DRBD. > > Is there an easy way to solve this in the short term, even if the ultimate > fix is more involved? > On Wed, 5 Apr 2017, Christoph Hellwig wrote: > commit 0dbed96a3cc9786bc4814dab98a7218753bde934 Author: Christoph Hellwig <hch@lst.de> Date: Wed Apr 5 19:21:21 2017 +0200 drbd: make intelligent use of blkdev_issue_zeroout > > drbd always wants its discard wire operations to zero the blocks, so > > use blkdev_issue_zeroout with the BLKDEV_ZERO_UNMAP flag instead of > > reinventing it poorly. > > -/* > > - * We *may* ignore the discard-zeroes-data setting, if so configured. > > - * > > - * Assumption is that it "discard_zeroes_data=0" is only because the backend > > - * may ignore partial unaligned discards. > > - * > > - * LVM/DM thin as of at least > > - * LVM version: 2.02.115(2)-RHEL7 (2015-01-28) > > - * Library version: 1.02.93-RHEL7 (2015-01-28) > > - * Driver version: 4.29.0 > > - * still behaves this way. > > - * > > - * For unaligned (wrt. alignment and granularity) or too small discards, > > - * we zero-out the initial (and/or) trailing unaligned partial chunks, > > - * but discard all the aligned full chunks. > > - * > > - * At least for LVM/DM thin, the result is effectively "discard_zeroes_data=1". > > - */ > > -int drbd_issue_discard_or_zero_out(struct drbd_device *device, sector_t start, unsigned int nr_sectors, bool discard) As I understood it, blkdev_issue_zeroout() was supposed to "always try to unmap", deprovision, the relevant region, and zero-out any unaligned head or tail, just like my work around above was doing. And that device mapper thin was "about to" learn this, "soon", or maybe block core would do the equivalent of my workaround described above. But it then did not. See also: https://www.redhat.com/archives/dm-devel/2017-March/msg00213.html https://www.redhat.com/archives/dm-devel/2017-March/msg00226.html I then did not follow this closely enough anymore, and I missed that with recent enough kernel, discard on DRBD on dm-thin would fully allocate. In our out-of-tree module, we had to keep the older code for compat reasons, anyways. I will just re-enable our zeroout workaround there again. In tree, either dm-thin learns to do REQ_OP_WRITE_ZEROES "properly", so the result in this scenario is what we expect: _: unprovisioned, not allocated, returns zero on read anyways *: provisioned, some arbitrary data 0: explicitly zeroed: |gran|ular|ity | | | | |****|****|____|****| to|-be-|zero|ed |**00|____|____|00**| (leave unallocated blocks alone, de-allocate full blocks just like with discard, explicitly zero unaligned head and tail) Or DRBD will have to resurrect that reinvented zeroout again, with exactly those semantics. I did reinvent it for a reason ;) -- : Lars Ellenberg : LINBIT | Keeping the Digital World Running : DRBD -- Heartbeat -- Corosync -- Pacemaker : R&D, Integration, Ops, Consulting, Support DRBD� and LINBIT� are registered trademarks of LINBIT
next prev parent reply other threads:[~2018-01-15 12:46 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-05 17:20 always use REQ_OP_WRITE_ZEROES for zeroing offload V2 Christoph Hellwig 2017-04-05 17:20 ` Christoph Hellwig 2017-04-05 17:20 ` [PATCH 01/27] sd: split sd_setup_discard_cmnd Christoph Hellwig 2017-04-05 17:20 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 02/27] block: renumber REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 03/27] block: implement splitting of REQ_OP_WRITE_ZEROES bios Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 04/27] sd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 05/27] md: support REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 06/27] dm io: discards don't take a payload Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 07/27] dm: support REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 08/27] dm kcopyd: switch to use REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 09/27] block: stop using blkdev_issue_write_same for zeroing Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 10/27] block: add a flags argument to (__)blkdev_issue_zeroout Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 11/27] block: add a REQ_NOUNMAP flag for REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 12/27] block: add a new BLKDEV_ZERO_NOFALLBACK flag Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 13/27] block_dev: use blkdev_issue_zerout for hole punches Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 14/27] sd: implement unmapping Write Zeroes Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 15/27] nvme: implement REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 16/27] zram: " Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 17/27] loop: " Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 18/27] brd: remove discard support Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 19/27] rbd: remove the discard_zeroes_data flag Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 20/27] rsxx: " Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 21/27] mmc: " Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 22/27] block: stop using discards for zeroing Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 23/27] drbd: make intelligent use of blkdev_issue_zeroout Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2018-01-13 0:46 ` [Drbd-dev] " Eric Wheeler 2018-01-15 12:46 ` Lars Ellenberg [this message] 2018-01-15 12:46 ` Lars Ellenberg [not found] ` <20180115124635.GA4107-w1SgEEioFePxa46PmUWvFg@public.gmane.org> 2018-01-15 15:07 ` Mike Snitzer 2018-01-15 15:07 ` Mike Snitzer 2018-01-16 8:55 ` [Drbd-dev] " Lars Ellenberg 2017-04-05 17:21 ` [PATCH 24/27] drbd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig 2017-04-05 17:21 ` Christoph Hellwig 2017-04-05 17:21 ` [PATCH 25/27] block: remove the discard_zeroes_data flag Christoph Hellwig 2017-05-01 20:45 ` Bart Van Assche 2017-05-01 20:45 ` Bart Van Assche [not found] ` <1493671519.2665.15.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> 2017-05-02 6:43 ` Nicholas A. Bellinger 2017-05-02 6:43 ` Nicholas A. Bellinger [not found] ` <1493707425.23202.77.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org> 2017-05-02 7:16 ` Nicholas A. Bellinger 2017-05-02 7:16 ` Nicholas A. Bellinger [not found] ` <1493709373.23202.79.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org> 2017-05-02 7:23 ` hch-jcswGhMUV9g 2017-05-02 7:23 ` hch 2017-05-03 3:33 ` Nicholas A. Bellinger 2017-05-03 3:33 ` Nicholas A. Bellinger 2017-05-03 14:33 ` Mike Snitzer 2017-05-05 3:10 ` Nicholas A. Bellinger 2017-05-05 3:10 ` Nicholas A. Bellinger [not found] ` <1493782395.23202.84.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org> 2017-05-07 9:22 ` hch-jcswGhMUV9g 2017-05-07 9:22 ` hch [not found] ` <20170507092209.GA27370-jcswGhMUV9g@public.gmane.org> 2017-05-09 6:46 ` Nicholas A. Bellinger 2017-05-09 6:46 ` Nicholas A. Bellinger 2017-05-10 14:06 ` hch [not found] ` <20170510140627.GA23759-jcswGhMUV9g@public.gmane.org> 2017-05-11 4:50 ` Nicholas A. Bellinger 2017-05-11 4:50 ` Nicholas A. Bellinger [not found] ` <1494478235.16894.115.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org> 2017-05-11 6:26 ` hch-jcswGhMUV9g 2017-05-11 6:26 ` hch [not found] ` <20170511062630.GA18517-jcswGhMUV9g@public.gmane.org> 2017-05-11 6:36 ` Nicholas A. Bellinger 2017-05-11 6:36 ` Nicholas A. Bellinger 2017-04-05 17:21 ` [PATCH 26/27] scsi: sd: Separate zeroout and discard command choices Christoph Hellwig 2017-04-06 6:17 ` Hannes Reinecke 2017-04-06 6:17 ` Hannes Reinecke 2017-04-19 14:56 ` Paolo Bonzini [not found] ` <58c3d6a6-924e-cc86-1907-a9fd02a39c0e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-04-20 1:34 ` Martin K. Petersen 2017-04-20 1:34 ` Martin K. Petersen 2017-04-05 17:21 ` [PATCH 27/27] scsi: sd: Remove LBPRZ dependency for discards Christoph Hellwig 2017-04-06 6:18 ` Hannes Reinecke 2017-04-06 6:18 ` Hannes Reinecke 2017-04-08 17:26 ` always use REQ_OP_WRITE_ZEROES for zeroing offload V2 Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180115124635.GA4107@soda.linbit \ --to=lars.ellenberg@linbit.com \ --cc=agk@redhat.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=drbd-dev@lists.ewheeler.net \ --cc=drbd-dev@lists.linbit.com \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=philipp.reisner@linbit.com \ --cc=shli@kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.