From: Christoffer Dall <christoffer.dall@linaro.org> To: Marc Zyngier <marc.zyngier@arm.com> Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, James Morse <james.morse@arm.com>, Steve Capper <steve.capper@arm.com>, Peter Maydell <peter.maydell@linaro.org> Subject: Re: [PATCH v4 11/19] KVM: arm/arm64: Demote HYP VA range display to being a debug feature Date: Mon, 15 Jan 2018 16:54:59 +0100 [thread overview] Message-ID: <20180115155459.GM21403@cbox> (raw) In-Reply-To: <20180104184334.16571-12-marc.zyngier@arm.com> On Thu, Jan 04, 2018 at 06:43:26PM +0000, Marc Zyngier wrote: > Displaying the HYP VA information is slightly counterproductive when > using VA randomization. Turn it into a debug feature only, and adjust > the last displayed value to reflect the top of RAM instead of ~0. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Acked-by: Christoffer Dall <christoffer.dall@linaro.org> > --- > virt/kvm/arm/mmu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index b4b69c2d1012..84d09f1a44d4 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -1760,9 +1760,10 @@ int kvm_mmu_init(void) > */ > BUG_ON((hyp_idmap_start ^ (hyp_idmap_end - 1)) & PAGE_MASK); > > - kvm_info("IDMAP page: %lx\n", hyp_idmap_start); > - kvm_info("HYP VA range: %lx:%lx\n", > - kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL)); > + kvm_debug("IDMAP page: %lx\n", hyp_idmap_start); > + kvm_debug("HYP VA range: %lx:%lx\n", > + kern_hyp_va(PAGE_OFFSET), > + kern_hyp_va((unsigned long)high_memory - 1)); > > if (hyp_idmap_start >= kern_hyp_va(PAGE_OFFSET) && > hyp_idmap_start < kern_hyp_va(~0UL) && > -- > 2.14.2 >
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 11/19] KVM: arm/arm64: Demote HYP VA range display to being a debug feature Date: Mon, 15 Jan 2018 16:54:59 +0100 [thread overview] Message-ID: <20180115155459.GM21403@cbox> (raw) In-Reply-To: <20180104184334.16571-12-marc.zyngier@arm.com> On Thu, Jan 04, 2018 at 06:43:26PM +0000, Marc Zyngier wrote: > Displaying the HYP VA information is slightly counterproductive when > using VA randomization. Turn it into a debug feature only, and adjust > the last displayed value to reflect the top of RAM instead of ~0. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Acked-by: Christoffer Dall <christoffer.dall@linaro.org> > --- > virt/kvm/arm/mmu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index b4b69c2d1012..84d09f1a44d4 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -1760,9 +1760,10 @@ int kvm_mmu_init(void) > */ > BUG_ON((hyp_idmap_start ^ (hyp_idmap_end - 1)) & PAGE_MASK); > > - kvm_info("IDMAP page: %lx\n", hyp_idmap_start); > - kvm_info("HYP VA range: %lx:%lx\n", > - kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL)); > + kvm_debug("IDMAP page: %lx\n", hyp_idmap_start); > + kvm_debug("HYP VA range: %lx:%lx\n", > + kern_hyp_va(PAGE_OFFSET), > + kern_hyp_va((unsigned long)high_memory - 1)); > > if (hyp_idmap_start >= kern_hyp_va(PAGE_OFFSET) && > hyp_idmap_start < kern_hyp_va(~0UL) && > -- > 2.14.2 >
next prev parent reply other threads:[~2018-01-15 15:55 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-04 18:43 [PATCH v4 00/19] KVM/arm64: Randomise EL2 mappings Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-04 18:43 ` [PATCH v4 01/19] arm64: asm-offsets: Avoid clashing DMA definitions Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-04 18:43 ` [PATCH v4 02/19] arm64: asm-offsets: Remove unused definitions Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-04 18:43 ` [PATCH v4 03/19] arm64: asm-offsets: Remove potential circular dependency Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 8:34 ` Christoffer Dall 2018-01-15 8:34 ` Christoffer Dall 2018-01-15 8:42 ` Marc Zyngier 2018-01-15 8:42 ` Marc Zyngier 2018-01-15 9:46 ` Christoffer Dall 2018-01-15 9:46 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 04/19] arm64: alternatives: Enforce alignment of struct alt_instr Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 9:11 ` Christoffer Dall 2018-01-15 9:11 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 05/19] arm64: alternatives: Add dynamic patching feature Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 11:26 ` Christoffer Dall 2018-01-15 11:26 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 06/19] arm64: insn: Add N immediate encoding Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 11:26 ` Christoffer Dall 2018-01-15 11:26 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 07/19] arm64: insn: Add encoder for bitwise operations using literals Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 11:26 ` Christoffer Dall 2018-01-15 11:26 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 08/19] arm64: KVM: Dynamically patch the kernel/hyp VA mask Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 11:47 ` Christoffer Dall 2018-01-15 11:47 ` Christoffer Dall 2018-02-15 13:11 ` Marc Zyngier 2018-02-15 13:11 ` Marc Zyngier 2018-02-16 9:02 ` Christoffer Dall 2018-02-16 9:02 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 09/19] arm64: cpufeatures: Drop the ARM64_HYP_OFFSET_LOW feature flag Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 11:48 ` Christoffer Dall 2018-01-15 11:48 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 15:36 ` Christoffer Dall 2018-01-15 15:36 ` Christoffer Dall 2018-02-15 13:22 ` Marc Zyngier 2018-02-15 13:22 ` Marc Zyngier 2018-02-16 9:05 ` Christoffer Dall 2018-02-16 9:05 ` Christoffer Dall 2018-02-16 9:33 ` Marc Zyngier 2018-02-16 9:33 ` Marc Zyngier 2018-02-19 14:39 ` Christoffer Dall 2018-02-19 14:39 ` Christoffer Dall 2018-02-20 11:40 ` Marc Zyngier 2018-02-20 11:40 ` Marc Zyngier 2018-01-04 18:43 ` [PATCH v4 11/19] KVM: arm/arm64: Demote HYP VA range display to being a debug feature Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 15:54 ` Christoffer Dall [this message] 2018-01-15 15:54 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 12/19] KVM: arm/arm64: Move ioremap calls to create_hyp_io_mappings Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-15 18:07 ` Christoffer Dall 2018-01-15 18:07 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 13/19] KVM: arm/arm64: Keep GICv2 HYP VAs in kvm_vgic_global_state Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 14:39 ` Christoffer Dall 2018-01-18 14:39 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 14/19] KVM: arm/arm64: Move HYP IO VAs to the "idmap" range Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 14:39 ` Christoffer Dall 2018-01-18 14:39 ` Christoffer Dall 2018-02-15 13:52 ` Marc Zyngier 2018-02-15 13:52 ` Marc Zyngier 2018-02-16 9:25 ` Christoffer Dall 2018-02-16 9:25 ` Christoffer Dall 2018-02-16 15:20 ` Marc Zyngier 2018-02-16 15:20 ` Marc Zyngier 2018-01-04 18:43 ` [PATCH v4 15/19] arm64; insn: Add encoder for the EXTR instruction Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 20:27 ` Christoffer Dall 2018-01-18 20:27 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 16/19] arm64: insn: Allow ADD/SUB (immediate) with LSL #12 Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 20:28 ` Christoffer Dall 2018-01-18 20:28 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 17/19] arm64: KVM: Dynamically compute the HYP VA mask Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 20:28 ` Christoffer Dall 2018-01-18 20:28 ` Christoffer Dall 2018-02-15 13:58 ` Marc Zyngier 2018-02-15 13:58 ` Marc Zyngier 2018-01-04 18:43 ` [PATCH v4 18/19] arm64: KVM: Introduce EL2 VA randomisation Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 20:28 ` Christoffer Dall 2018-01-18 20:28 ` Christoffer Dall 2018-02-15 15:32 ` Marc Zyngier 2018-02-15 15:32 ` Marc Zyngier 2018-02-16 9:33 ` Christoffer Dall 2018-02-16 9:33 ` Christoffer Dall 2018-01-04 18:43 ` [PATCH v4 19/19] arm64: Update the KVM memory map documentation Marc Zyngier 2018-01-04 18:43 ` Marc Zyngier 2018-01-18 20:28 ` Christoffer Dall 2018-01-18 20:28 ` Christoffer Dall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180115155459.GM21403@cbox \ --to=christoffer.dall@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=james.morse@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=peter.maydell@linaro.org \ --cc=steve.capper@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.