* Re: [ANNOUNCE] nftables 0.8.1 release
@ 2018-01-16 14:48 Jan Engelhardt
2018-01-16 14:53 ` Pablo Neira Ayuso
0 siblings, 1 reply; 5+ messages in thread
From: Jan Engelhardt @ 2018-01-16 14:48 UTC (permalink / raw)
To: pablo; +Cc: Netfilter Developer Mailing List
> nftables 0.8.1
>
>This release contains mostly incremental fixes and documentation
>updates, such as fixing up ./configure --with-mini-gmp for embedded
>setups that don't have libgmp.
Why is this now installing a libnftables.pc file when there is no
library or headers to go with it? (Remember that libnftables.la is
listed for "noinst_LTLIBRARIES".)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] nftables 0.8.1 release
2018-01-16 14:48 [ANNOUNCE] nftables 0.8.1 release Jan Engelhardt
@ 2018-01-16 14:53 ` Pablo Neira Ayuso
2018-01-16 16:18 ` Phil Sutter
0 siblings, 1 reply; 5+ messages in thread
From: Pablo Neira Ayuso @ 2018-01-16 14:53 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Netfilter Developer Mailing List, Phil Sutter
On Tue, Jan 16, 2018 at 03:48:24PM +0100, Jan Engelhardt wrote:
>
> > nftables 0.8.1
> >
> >This release contains mostly incremental fixes and documentation
> >updates, such as fixing up ./configure --with-mini-gmp for embedded
> >setups that don't have libgmp.
>
> Why is this now installing a libnftables.pc file when there is no
> library or headers to go with it? (Remember that libnftables.la is
> listed for "noinst_LTLIBRARIES".)
That sounds like a leftover when we were aiming to roll back/not to expose
libnftables yet in this release.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] nftables 0.8.1 release
2018-01-16 14:53 ` Pablo Neira Ayuso
@ 2018-01-16 16:18 ` Phil Sutter
2018-01-16 16:19 ` [nft PATCH] Eliminate forgotten traces of libnftables exporting Phil Sutter
0 siblings, 1 reply; 5+ messages in thread
From: Phil Sutter @ 2018-01-16 16:18 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Jan Engelhardt, Netfilter Developer Mailing List
On Tue, Jan 16, 2018 at 03:53:30PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Jan 16, 2018 at 03:48:24PM +0100, Jan Engelhardt wrote:
> >
> > > nftables 0.8.1
> > >
> > >This release contains mostly incremental fixes and documentation
> > >updates, such as fixing up ./configure --with-mini-gmp for embedded
> > >setups that don't have libgmp.
> >
> > Why is this now installing a libnftables.pc file when there is no
> > library or headers to go with it? (Remember that libnftables.la is
> > listed for "noinst_LTLIBRARIES".)
>
> That sounds like a leftover when we were aiming to roll back/not to expose
> libnftables yet in this release.
Oh yes, sorry. I'll follow-up with a patch immediately.
Cheers, Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
* [nft PATCH] Eliminate forgotten traces of libnftables exporting
2018-01-16 16:18 ` Phil Sutter
@ 2018-01-16 16:19 ` Phil Sutter
2018-01-19 12:10 ` Pablo Neira Ayuso
0 siblings, 1 reply; 5+ messages in thread
From: Phil Sutter @ 2018-01-16 16:19 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
This removes libnftables pkg-config file along with the few lines of
code to adjust and install it.
Fixes: d572d59788143 ("Make libnftables a local static library")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
Makefile.am | 3 ---
configure.ac | 1 -
libnftables.pc.in | 15 ---------------
3 files changed, 19 deletions(-)
delete mode 100644 libnftables.pc.in
diff --git a/Makefile.am b/Makefile.am
index 9af25ded836b8..10aa40f14127f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -6,6 +6,3 @@ SUBDIRS = src \
files
EXTRA_DIST = tests
-
-pkgconfigdir = $(libdir)/pkgconfig
-pkgconfig_DATA = libnftables.pc
diff --git a/configure.ac b/configure.ac
index 6ed3edca1fe5c..60c8c08bff2a1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -141,7 +141,6 @@ AC_CHECK_FUNCS([memmove memset strchr strdup strerror strtoull])
AC_CONFIG_FILES([ \
Makefile \
- libnftables.pc \
src/Makefile \
include/Makefile \
include/nftables/Makefile \
diff --git a/libnftables.pc.in b/libnftables.pc.in
deleted file mode 100644
index 6431d48cf6f2c..0000000000000
--- a/libnftables.pc.in
+++ /dev/null
@@ -1,15 +0,0 @@
-# libnftables pkg-config file
-
-prefix=@prefix@
-exec_prefix=@exec_prefix@
-libdir=@libdir@
-includedir=@includedir@
-
-Name: libnftables
-Description: Netfilter nf_tables user library
-URL: http://netfilter.org/projects/nftables/
-Version: @VERSION@
-Requires:
-Conflicts:
-Libs: -L${libdir} -lnftables
-Cflags: -I${includedir}
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [nft PATCH] Eliminate forgotten traces of libnftables exporting
2018-01-16 16:19 ` [nft PATCH] Eliminate forgotten traces of libnftables exporting Phil Sutter
@ 2018-01-19 12:10 ` Pablo Neira Ayuso
0 siblings, 0 replies; 5+ messages in thread
From: Pablo Neira Ayuso @ 2018-01-19 12:10 UTC (permalink / raw)
To: Phil Sutter; +Cc: netfilter-devel
On Tue, Jan 16, 2018 at 05:19:57PM +0100, Phil Sutter wrote:
> This removes libnftables pkg-config file along with the few lines of
> code to adjust and install it.
Applied, thanks Phil.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-19 12:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-16 14:48 [ANNOUNCE] nftables 0.8.1 release Jan Engelhardt
2018-01-16 14:53 ` Pablo Neira Ayuso
2018-01-16 16:18 ` Phil Sutter
2018-01-16 16:19 ` [nft PATCH] Eliminate forgotten traces of libnftables exporting Phil Sutter
2018-01-19 12:10 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.