* [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early.
@ 2018-01-16 15:53 Maarten Lankhorst
2018-01-16 16:23 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2018-01-16 15:53 UTC (permalink / raw)
To: intel-gfx
intel_power_domains_init_hw() calls set_init_power, but when using
runtime power management this call is skipped. This prevents hw readout
from taking place.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104172
Cc: imre.deak@intel.com
---
drivers/gpu/drm/i915/i915_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 9cace8732dcf..4cecf5c01265 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1836,6 +1836,8 @@ static int i915_drm_resume_early(struct drm_device *dev)
if (IS_GEN9_LP(dev_priv) ||
!(dev_priv->suspended_to_idle && dev_priv->csr.dmc_payload))
intel_power_domains_init_hw(dev_priv, true);
+ else
+ intel_display_set_init_power(dev_priv, true);
i915_gem_sanitize(dev_priv);
--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Always call to intel_display_set_init_power() in resume_early.
2018-01-16 15:53 [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early Maarten Lankhorst
@ 2018-01-16 16:23 ` Patchwork
2018-01-16 16:44 ` [PATCH] " Imre Deak
2018-01-16 17:58 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-01-16 16:23 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Always call to intel_display_set_init_power() in resume_early.
URL : https://patchwork.freedesktop.org/series/36557/
State : success
== Summary ==
Series 36557v1 drm/i915: Always call to intel_display_set_init_power() in resume_early.
https://patchwork.freedesktop.org/api/1.0/series/36557/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> FAIL (fi-elk-e7500) fdo#103989 +1
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-kbl-r) fdo#104172
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:421s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:429s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:377s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:488s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:281s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:483s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:466s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:466s
fi-elk-e7500 total:224 pass:167 dwarn:10 dfail:0 fail:1 skip:45
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:276s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:510s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:392s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:404s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:408s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:415s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:459s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:495s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:453s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:502s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:576s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:433s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:506s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:526s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:486s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:489s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:522s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:394s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:570s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:473s
a0ca279440c8d7c40d798fed9939a2a25b31434b drm-tip: 2018y-01m-16d-10h-49m-51s UTC integration manifest
fd072d020485 drm/i915: Always call to intel_display_set_init_power() in resume_early.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7686/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early.
2018-01-16 15:53 [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early Maarten Lankhorst
2018-01-16 16:23 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-01-16 16:44 ` Imre Deak
2018-01-16 18:02 ` Maarten Lankhorst
2018-01-16 17:58 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2018-01-16 16:44 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Tue, Jan 16, 2018 at 04:53:24PM +0100, Maarten Lankhorst wrote:
> intel_power_domains_init_hw() calls set_init_power, but when using
> runtime power management this call is skipped.
It's skipped during suspend-to-idle.
> This prevents hw readout from taking place.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104172
> Cc: imre.deak@intel.com
Fixes: 4900727d35bb ("drm/i915/skl: enable PC9/10 power states during suspend-to-idle")
Thanks for following up on this,
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 9cace8732dcf..4cecf5c01265 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1836,6 +1836,8 @@ static int i915_drm_resume_early(struct drm_device *dev)
> if (IS_GEN9_LP(dev_priv) ||
> !(dev_priv->suspended_to_idle && dev_priv->csr.dmc_payload))
> intel_power_domains_init_hw(dev_priv, true);
> + else
> + intel_display_set_init_power(dev_priv, true);
>
> i915_gem_sanitize(dev_priv);
>
> --
> 2.15.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Always call to intel_display_set_init_power() in resume_early.
2018-01-16 15:53 [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early Maarten Lankhorst
2018-01-16 16:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-16 16:44 ` [PATCH] " Imre Deak
@ 2018-01-16 17:58 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-01-16 17:58 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Always call to intel_display_set_init_power() in resume_early.
URL : https://patchwork.freedesktop.org/series/36557/
State : success
== Summary ==
Test kms_cursor_crc:
Subgroup cursor-128x128-suspend:
pass -> SKIP (shard-snb) fdo#103880
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623
Test kms_flip:
Subgroup flip-vs-fences-interruptible:
dmesg-warn -> PASS (shard-hsw) fdo#102614
fdo#103880 https://bugs.freedesktop.org/show_bug.cgi?id=103880
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
shard-hsw total:2729 pass:1549 dwarn:1 dfail:0 fail:10 skip:1169 time:9148s
shard-snb total:2729 pass:1317 dwarn:1 dfail:0 fail:10 skip:1400 time:7551s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7686/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early.
2018-01-16 16:44 ` [PATCH] " Imre Deak
@ 2018-01-16 18:02 ` Maarten Lankhorst
0 siblings, 0 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2018-01-16 18:02 UTC (permalink / raw)
To: imre.deak; +Cc: intel-gfx
Op 16-01-18 om 17:44 schreef Imre Deak:
> On Tue, Jan 16, 2018 at 04:53:24PM +0100, Maarten Lankhorst wrote:
>> intel_power_domains_init_hw() calls set_init_power, but when using
>> runtime power management this call is skipped.
> It's skipped during suspend-to-idle.
>
>> This prevents hw readout from taking place.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104172
>> Cc: imre.deak@intel.com
> Fixes: 4900727d35bb ("drm/i915/skl: enable PC9/10 power states during suspend-to-idle")
>
> Thanks for following up on this,
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Thanks, your commit id was wrong but pushed with the right $id. :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-16 18:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-16 15:53 [PATCH] drm/i915: Always call to intel_display_set_init_power() in resume_early Maarten Lankhorst
2018-01-16 16:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-16 16:44 ` [PATCH] " Imre Deak
2018-01-16 18:02 ` Maarten Lankhorst
2018-01-16 17:58 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.